Displaying 20 results from an estimated 37 matches for "weiny".
2019 Jun 28
2
[PATCH 16/25] device-dax: use the dev_pagemap internal refcount
On Wed, Jun 26, 2019 at 02:27:15PM +0200, Christoph Hellwig wrote:
> The functionality is identical to the one currently open coded in
> device-dax.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> ---
> drivers/dax/dax-private.h | 4 ----
> drivers/dax/device.c | 43 ---------------------------------------
> 2 files changed, 47 deletions(-)
DanW: I think this series has reached enough review, did you want
to ack/test any further?
This nee...
2019 Jun 28
2
[PATCH 16/25] device-dax: use the dev_pagemap internal refcount
...t; > On Wed, Jun 26, 2019 at 02:27:15PM +0200, Christoph Hellwig wrote:
> > > The functionality is identical to the one currently open coded in
> > > device-dax.
> > >
> > > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > > Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> > > drivers/dax/dax-private.h | 4 ----
> > > drivers/dax/device.c | 43 ---------------------------------------
> > > 2 files changed, 47 deletions(-)
> >
> > DanW: I think this series has reached enough review, did you...
2019 Jun 28
2
[PATCH 16/25] device-dax: use the dev_pagemap internal refcount
...Christoph Hellwig wrote:
> > > > > The functionality is identical to the one currently open coded in
> > > > > device-dax.
> > > > >
> > > > > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > > > > Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> > > > > drivers/dax/dax-private.h | 4 ----
> > > > > drivers/dax/device.c | 43 ---------------------------------------
> > > > > 2 files changed, 47 deletions(-)
> > > >
> > > > DanW: I th...
2019 Jun 26
2
[PATCH 04/25] mm: remove MEMORY_DEVICE_PUBLIC support
...}
> -
This collides with Ira's bug fix [1]. The MEMORY_DEVICE_FSDAX case
needs this to be converted to be independent of "public" pages.
Perhaps it should be pulled out of -mm and incorporated in this
series.
[1]: https://lore.kernel.org/lkml/20190605214922.17684-1-ira.weiny at intel.com/
2019 Feb 20
0
[RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it
On Tue, Feb 19, 2019 at 09:30:33PM -0800, ira.weiny at intel.com wrote:
> From: Ira Weiny <ira.weiny at intel.com>
>
> Resending these as I had only 1 minor comment which I believe we have covered
> in this series. I was anticipating these going through the mm tree as they
> depend on a cleanup patch there and the IB changes a...
2019 Jun 19
3
[PATCH 18/22] mm: mark DEVICE_PUBLIC as broken
On Thu, Jun 13, 2019 at 06:23:04PM -0700, John Hubbard wrote:
> On 6/13/19 5:43 PM, Ira Weiny wrote:
> > On Thu, Jun 13, 2019 at 07:58:29PM +0000, Jason Gunthorpe wrote:
> >> On Thu, Jun 13, 2019 at 12:53:02PM -0700, Ralph Campbell wrote:
> >>>
> ...
> >> Hum, so the only thing this config does is short circuit here:
> >>
> >> static...
2019 Jun 26
1
[PATCH 11/25] memremap: lift the devmap_enable manipulation into devm_memremap_pages
...gt; +
> +static int devmap_managed_enable_get(struct device *dev, struct dev_pagemap *pgmap)
> +{
> + if (!pgmap->ops->page_free) {
NIT: later on you add the check for pgmap->ops... it should probably be here.
But not sure that bisection will be an issue here.
Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> + WARN(1, "Missing page_free method\n");
> + return -EINVAL;
> + }
> +
> + if (atomic_inc_return(&devmap_managed_enable) == 1)
> + static_branch_enable(&devmap_managed_key);
> + return devm_add_action_or_reset(dev, devmap_m...
2019 Jun 14
3
[PATCH 18/22] mm: mark DEVICE_PUBLIC as broken
On Thu, Jun 13, 2019 at 07:58:29PM +0000, Jason Gunthorpe wrote:
> On Thu, Jun 13, 2019 at 12:53:02PM -0700, Ralph Campbell wrote:
> >
> > On 6/13/19 12:44 PM, Jason Gunthorpe wrote:
> > > On Thu, Jun 13, 2019 at 11:43:21AM +0200, Christoph Hellwig wrote:
> > > > The code hasn't been used since it was added to the tree, and doesn't
> > > >
2019 Jun 28
0
[PATCH 16/25] device-dax: use the dev_pagemap internal refcount
...ellanox.com> wrote:
>
> On Wed, Jun 26, 2019 at 02:27:15PM +0200, Christoph Hellwig wrote:
> > The functionality is identical to the one currently open coded in
> > device-dax.
> >
> > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> > ---
> > drivers/dax/dax-private.h | 4 ----
> > drivers/dax/device.c | 43 ---------------------------------------
> > 2 files changed, 47 deletions(-)
>
> DanW: I think this series has reached enough review, did you want
>...
2019 Jun 28
0
[PATCH 16/25] device-dax: use the dev_pagemap internal refcount
...019 at 02:27:15PM +0200, Christoph Hellwig wrote:
> > > > The functionality is identical to the one currently open coded in
> > > > device-dax.
> > > >
> > > > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > > > Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> > > > drivers/dax/dax-private.h | 4 ----
> > > > drivers/dax/device.c | 43 ---------------------------------------
> > > > 2 files changed, 47 deletions(-)
> > >
> > > DanW: I think this series has reach...
2019 Jun 28
0
[PATCH 16/25] device-dax: use the dev_pagemap internal refcount
...> > > > > > The functionality is identical to the one currently open coded in
> > > > > > device-dax.
> > > > > >
> > > > > > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > > > > > Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> > > > > > drivers/dax/dax-private.h | 4 ----
> > > > > > drivers/dax/device.c | 43 ---------------------------------------
> > > > > > 2 files changed, 47 deletions(-)
> > > > >
> >...
2019 Jun 26
1
[PATCH 15/25] memremap: provide an optional internal refcount in struct dev_pagemap
...ll || !pgmap->ops->cleanup) {
> + WARN(1, "Missing reference count teardown definition\n");
> + return ERR_PTR(-EINVAL);
> + }
After this series are there any users who continue to supply their own
reference object and these callbacks?
As it stands:
Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> }
>
> if (need_devmap_managed) {
> @@ -296,8 +334,8 @@ void *devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap)
> err_pfn_remap:
> pgmap_array_delete(res);
> err_array:
> - pgmap->ops->kill(pgmap);
> - pg...
2019 Jun 28
2
[PATCH 16/25] device-dax: use the dev_pagemap internal refcount
...> > The functionality is identical to the one currently open coded in
> > > > > > > device-dax.
> > > > > > >
> > > > > > > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > > > > > > Reviewed-by: Ira Weiny <ira.weiny at intel.com>
> > > > > > > drivers/dax/dax-private.h | 4 ----
> > > > > > > drivers/dax/device.c | 43 ---------------------------------------
> > > > > > > 2 files changed, 47 deletions(-)
> > > >...
2019 Jul 01
30
dev_pagemap related cleanups v4
Hi Dan, Jérôme and Jason,
below is a series that cleans up the dev_pagemap interface so that
it is more easily usable, which removes the need to wrap it in hmm
and thus allowing to kill a lot of code
Note: this series is on top of Linux 5.2-rc6 and has some minor
conflicts with the hmm tree that are easy to resolve.
Diffstat summary:
34 files changed, 379 insertions(+), 1016 deletions(-)
Git
2019 Jun 26
1
[PATCH 18/22] mm: mark DEVICE_PUBLIC as broken
On Tue 25-06-19 20:15:28, John Hubbard wrote:
> On 6/19/19 12:27 PM, Jason Gunthorpe wrote:
> > On Thu, Jun 13, 2019 at 06:23:04PM -0700, John Hubbard wrote:
> >> On 6/13/19 5:43 PM, Ira Weiny wrote:
> >>> On Thu, Jun 13, 2019 at 07:58:29PM +0000, Jason Gunthorpe wrote:
> >>>> On Thu, Jun 13, 2019 at 12:53:02PM -0700, Ralph Campbell wrote:
> >>>>>
> >> ...
> >>> So I think it is ok. Frankly I was wondering if we should re...
2019 Sep 19
0
[PATCH RFC v3 6/9] mm: Allow to offline PageOffline() pages with a reference count of 0
...othwell <sfr at canb.auug.org.au>
Cc: Mauro Carvalho Chehab <mchehab+samsung at kernel.org>
Cc: Matthew Wilcox <willy at infradead.org>
Cc: Yu Zhao <yuzhao at google.com>
Cc: Minchan Kim <minchan at kernel.org>
Cc: Yang Shi <yang.shi at linux.alibaba.com>
Cc: Ira Weiny <ira.weiny at intel.com>
Cc: Andrey Ryabinin <aryabinin at virtuozzo.com>
Signed-off-by: David Hildenbrand <david at redhat.com>
---
include/linux/page-flags.h | 4 ++++
include/linux/page-isolation.h | 4 +++-
mm/memory_hotplug.c | 9 ++++++---
mm/page_alloc.c...
2019 Jun 26
41
dev_pagemap related cleanups v3
Hi Dan, Jérôme and Jason,
below is a series that cleans up the dev_pagemap interface so that
it is more easily usable, which removes the need to wrap it in hmm
and thus allowing to kill a lot of code
Note: this series is on top of Linux 5.2-rc5 and has some minor
conflicts with the hmm tree that are easy to resolve.
Diffstat summary:
32 files changed, 361 insertions(+), 1012 deletions(-)
Git
2019 Jun 14
0
[PATCH 18/22] mm: mark DEVICE_PUBLIC as broken
On 6/13/19 5:43 PM, Ira Weiny wrote:
> On Thu, Jun 13, 2019 at 07:58:29PM +0000, Jason Gunthorpe wrote:
>> On Thu, Jun 13, 2019 at 12:53:02PM -0700, Ralph Campbell wrote:
>>>
...
>> Hum, so the only thing this config does is short circuit here:
>>
>> static inline bool is_device_public_page(c...
2019 Jun 14
0
[PATCH 13/22] device-dax: use the dev_pagemap internal refcount
On Thu, Jun 13, 2019 at 05:22:17PM -0700, Ira Weiny wrote:
> > - dev_dax->pgmap.ref = &dev_dax->ref;
>
> I don't think this exactly correct. pgmap.ref is a pointer to the dev_dax ref
> structure. Taking it away will cause devm_memremap_pages() to fail AFAICS.
>
> I think you need to change struct dev_pagemap as...
2019 Jun 14
0
[PATCH 18/22] mm: mark DEVICE_PUBLIC as broken
On Thu, Jun 13, 2019 at 05:43:15PM -0700, Ira Weiny wrote:
> <sigh> yes but the earlier patch:
>
> [PATCH 03/22] mm: remove hmm_devmem_add_resource
>
> Removes the only place type is set to MEMORY_DEVICE_PUBLIC.
>
> So I think it is ok. Frankly I was wondering if we should remove the public
> type altogether but co...