search for: weakdefcanbehiddendirect

I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. Steven > On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com> wrote: > > I agree with Teresa, we should probably do #2 to preserve behavior for now. > > On Wed, F...

...)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? -- Mehdi 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org>: > I didn't realize that that WeakDefCanBeHiddenDirective is only available > on Darwin. So if we are doing it for #2, it should be a Darwin only fix as > well. > > Steven > > > On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com> wrote: > > I agree with Teresa, we should probably do #2 to preserve behavior fo...

...n't the idea that this could be added any time by a module-level `infer_attribute` pass? > > -- > Mehdi > > > 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: > I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. > > Steven > > >> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com <mailto:rnk at google.com>> wrote: >> >> I agree with Teresa, we should...

...o-hide` > semantic. Wasn't the idea that this could be added any time by a > module-level `infer_attribute` pass? > > -- > Mehdi > > > 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org > >: > >> I didn't realize that that WeakDefCanBeHiddenDirective is only available >> on Darwin. So if we are doing it for #2, it should be a Darwin only fix as >> well. >> >> Steven >> >> >> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com> wrote: >> >> I agree with Teresa, we should pr...

...ea that this could be added any time by a >> module-level `infer_attribute` pass? >> >> -- >> Mehdi >> >> >> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev < >> llvm-dev at lists.llvm.org>: >> >>> I didn't realize that that WeakDefCanBeHiddenDirective is only available >>> on Darwin. So if we are doing it for #2, it should be a Darwin only fix as >>> well. >>> >>> Steven >>> >>> >>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com> wrote: >>> >>&g...

...ould be added any time by a module-level `infer_attribute` pass? >> >> -- >> Mehdi >> >> >> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >> I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. >> >> Steven >> >> >>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com <mailto:rnk at google.com>> wrote: >>> >>> I...

...a >>> module-level `infer_attribute` pass? >>> >>> -- >>> Mehdi >>> >>> >>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev < >>> llvm-dev at lists.llvm.org>: >>> >>>> I didn't realize that that WeakDefCanBeHiddenDirective is only >>>> available on Darwin. So if we are doing it for #2, it should be a Darwin >>>> only fix as well. >>>> >>>> Steven >>>> >>>> >>>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com> wr...

...module-level `infer_attribute` pass? >>> >>> -- >>> Mehdi >>> >>> >>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >>> I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. >>> >>> Steven >>> >>> >>>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com <mailto:rnk at google.com>> wrote: >>&...

I agree with Teresa, we should probably do #2 to preserve behavior for now. On Wed, Feb 7, 2018 at 9:34 AM, Teresa Johnson via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi Steven, > > I'd prefer not to inhibit importing. I am also concerned about putting > these symbols in the llvm.compiler_used (I don't recall earlier discussion > around this, but it seems

...e` pass? >>>> >>>> -- >>>> Mehdi >>>> >>>> >>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >>>> I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. >>>> >>>> Steven >>>> >>>> >>>>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com <mailto:rnk at google.com>&...

...ttribute` pass? >>>> >>>> -- >>>> Mehdi >>>> >>>> >>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm. >>>> org>: >>>> >>>>> I didn't realize that that WeakDefCanBeHiddenDirective is only >>>>> available on Darwin. So if we are doing it for #2, it should be a Darwin >>>>> only fix as well. >>>>> >>>>> Steven >>>>> >>>>> >>>>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner...

...>>>>> -- >>>>> Mehdi >>>>> >>>>> >>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev < >>>>> llvm-dev at lists.llvm.org>: >>>>> >>>>>> I didn't realize that that WeakDefCanBeHiddenDirective is only >>>>>> available on Darwin. So if we are doing it for #2, it should be a Darwin >>>>>> only fix as well. >>>>>> >>>>>> Steven >>>>>> >>>>>> >>>>>> On Feb 7, 2018,...

...; >>>>> -- >>>>> Mehdi >>>>> >>>>> >>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >>>>> I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. >>>>> >>>>> Steven >>>>> >>>>> >>>>>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com <mailto:rn...

...ttribute` pass? >>>> >>>> -- >>>> Mehdi >>>> >>>> >>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm. >>>> org>: >>>> >>>>> I didn't realize that that WeakDefCanBeHiddenDirective is only >>>>> available on Darwin. So if we are doing it for #2, it should be a Darwin >>>>> only fix as well. >>>>> >>>>> Steven >>>>> >>>>> >>>>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner...

...gt; -- >>>>>> Mehdi >>>>>> >>>>>> >>>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >>>>>> I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. >>>>>> >>>>>> Steven >>>>>> >>>>>> >>>>>>> On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at goog...

...;>>>>> Mehdi >>>>>> >>>>>> >>>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev < >>>>>> llvm-dev at lists.llvm.org>: >>>>>> >>>>>>> I didn't realize that that WeakDefCanBeHiddenDirective is only >>>>>>> available on Darwin. So if we are doing it for #2, it should be a Darwin >>>>>>> only fix as well. >>>>>>> >>>>>>> Steven >>>>>>> >>>>>>> >>>>...

...>>>> Mehdi >>>>>>> >>>>>>> >>>>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >>>>>>> I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. >>>>>>> >>>>>>> Steven >>>>>>> >>>>>>> >>>>>>>> On Feb 7, 2018, at 11:29 AM, Reid Klec...