search for: wdog_pid

Package: xen-utils-common Version: 3.0.3-0-2 Severity: normal While reviewing the contents of /etc/init.d/xendomains, I noticed that the script sets a variable named WDOG_PID but later references an uninitialized variable named WDOG_PIG. I'm not sure how much this impairs the behavior of Xen, so I left the severity at "normal". See below for a simple patch: --- xendomains.orig 2007-01-27 18:42:02.000000000 -0600 +++ xendomains 2007-01-27 18:42:22.0...

...NDOMAINS_USLEEP done fi if test "$state" = "-b---d" -o "$state" = "-----d"; then echo -n "(zomb)" continue fi if test -n "$XENDOMAINS_MIGRATE"; then echo -n "(migr)" watchdog_xencmd migrate & WDOG_PID=$! XMR=`$CMD migrate $id $XENDOMAINS_MIGRATE 2>&1 1>/dev/null` if test $? -ne 0; then echo -e "\nAn error occurred while migrating domain:\n$XMR\n" rc_failed $? echo -e '!' kill $WDOG_PID >/dev/null 2>&1 else kill $WDOG_PID >/dev/nul...

...s, I modified /etc/init.d/xendomains, sleeping for 2 seconds a the end of the stop() function. One second of sleep sometimes wasn't enough. *** xendomains-org Sun Jun 19 15:26:49 2011 --- xendomains Sun Jun 19 15:27:13 2011 *************** *** 342,347 **** --- 342,350 ---- kill $WDOG_PID >/dev/null 2>&1 fi + # prevent race condition + sleep 2 + # Unconditionally delete lock file rm -f $LOCKFILE } -- System Information: Debian Release: 6.0.1 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable...

...;-----d"; then return 1; fi - done < <(xm list | grep -v '^Name') + done < <(xm_list | grep -v '^Name') return 0 } @@ -316,14 +332,14 @@ echo -n "(shut)" watchdog_xm shutdown & WDOG_PID=$! - xm shutdown $id $XENDOMAINS_SHUTDOWN + xm shutdown $id $XENDOMAINS_SHUTDOWN > /dev/null if test $? -ne 0; then rc_failed $? echo -n '!' fi kill $WDOG_PIG >/dev/null 2>&1 f...

...case \"$name\" in + $NAMES) # nothing ;; - (*) + *) echo -e ''(skip)'' continue ;; @@ -430,6 +430,7 @@ kill $WDOG_PID >/dev/null 2>&1 echo -e . usleep 1000 + name=;id= continue fi fi @@ -446,6 +447,7 @@ fi kill $WDOG_PID >/dev/null 2>&1 fi + name=;id= done < &...