search for: wdfcoinstal

Commit 47b5f245bec908f803f0a89c3b1e3166cfe33aad originally introduced the filtering of files by extension. For the QXL driver at least, there is a qxldd.dll file which is part of the driver, so that must be copied to the guest as well. This patch will cause 'WdfCoInstaller*.dll' files to be copied too. While I'm not sure if this is correct, it seems as if it will be safe as although there are multiple copies of this file, they are all the same (per architecture). Thanks: Vadim Rozenfeld, Tingting Zheng. --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1...

...gt; > - let extensions = ["cat"; "inf"; "pdb"; "sys"] in > > + let extensions = ["cat"; "dll"; "inf"; "pdb"; "sys"] in > > Actually no, this part is (may be) wrong. > > This causes WdfCoInstaller*.dll from the ISO to be copied in. It's > not clear to me whether these files are needed - I suspect not. Yes it is, see the corresponding *.inf where it's mentioned in the corresponding CopyFiles directive (and yes, I just verified that with that file missing the balloon driver ins...

...quot;inf"; "pdb"; "sys"] in > > > > + let extensions = ["cat"; "dll"; "inf"; "pdb"; "sys"] in > > > > > > Actually no, this part is (may be) wrong. > > > > > > This causes WdfCoInstaller*.dll from the ISO to be copied in. It's > > > not clear to me whether these files are needed - I suspect not. > > > > Yes it is, see the corresponding *.inf where it's mentioned in the > > corresponding CopyFiles directive (and yes, I just verified that with...

Since v1: - Fix a bug in the calculation of lc_basename. By luck this doesn't affect anything given the contents of the current ISO. - Don't copy the WdfCoInstaller*.dll files. Rich.

...bec908f803f0a89c3b1e3166cfe33aad originally introduced > > the filtering of files by extension. For the QXL driver at least, > > there is a qxldd.dll file which is part of the driver, so that must be > > copied to the guest as well. > > > > This patch will cause 'WdfCoInstaller*.dll' files to be copied too. > > While I'm not sure if this is correct, > > It is. They are coinstaller dlls and are mentioned in the corresponding > .inf and .cat files, so the driver wouldn't install without them. > > There are also other files that sometim...

...t; > > + let extensions = ["cat"; "dll"; "inf"; "pdb"; "sys"] in > > > > > > > > > > > > Actually no, this part is (may be) wrong. > > > > > > > > > > > > This causes WdfCoInstaller*.dll from the ISO to be copied in. It's > > > > > > not clear to me whether these files are needed - I suspect not. > > > > > Having WdfCoInstaller* is absolutely necessary for successful installation any of our WDF based drivers (serial, balloon, and rng)...

Windows QXL drivers include also qxldd.dll which used to get filtered out and not copied over into the guest. As a result QXL driver failed to install due to a missing file. Correct that, and update the tests accordingly. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/fake-virtio-win/drivers/i386/Win7/qxldd.dll | 1 + v2v/test-v2v-in-place.sh | 1 +

...hout specific extensions. *) > - let extensions = ["cat"; "inf"; "pdb"; "sys"] in > + let extensions = ["cat"; "dll"; "inf"; "pdb"; "sys"] in Actually no, this part is (may be) wrong. This causes WdfCoInstaller*.dll from the ISO to be copied in. It's not clear to me whether these files are needed - I suspect not. It also causes the tests to fail, although only when you have installed the optional ocaml oUnit2 package: ---------------------------------------------------------------------- Error:...

...ons = ["cat"; "inf"; "pdb"; "sys"] in > > > + let extensions = ["cat"; "dll"; "inf"; "pdb"; "sys"] in > > > > Actually no, this part is (may be) wrong. > > > > This causes WdfCoInstaller*.dll from the ISO to be copied in. It's > > not clear to me whether these files are needed - I suspect not. > > Yes it is, see the corresponding *.inf where it's mentioned in the > corresponding CopyFiles directive (and yes, I just verified that with > that file missi...

...ote: > Commit 47b5f245bec908f803f0a89c3b1e3166cfe33aad originally introduced > the filtering of files by extension. For the QXL driver at least, > there is a qxldd.dll file which is part of the driver, so that must be > copied to the guest as well. > > This patch will cause 'WdfCoInstaller*.dll' files to be copied too. > While I'm not sure if this is correct, It is. They are coinstaller dlls and are mentioned in the corresponding .inf and .cat files, so the driver wouldn't install without them. There are also other files that sometimes are and sometimes aren'...

v2 -> v3 - Don't make a special case for WdfCoInstaller* files. There is a difference of opinion about whether copying these is necessary, but it seems like it is not harmful. Rich.