search for: warn_cflag

...++- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/mltools/Makefile.am b/mltools/Makefile.am index ce4d1ac..3b4172d 100644 --- a/mltools/Makefile.am +++ b/mltools/Makefile.am @@ -103,7 +103,9 @@ libmltools_a_CPPFLAGS = \ -I$(top_srcdir)/common/mlutils libmltools_a_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ - $(LIBVIRT_CFLAGS) $(LIBXML2_CFLAGS) \ + $(LIBVIRT_CFLAGS) \ + $(LIBXML2_CFLAGS) \ + $(LIBGUESTFS_CFLAGS) \ $(JANSSON_CFLAGS) \ -fPIC diff --git a/mlutils/Makefile.am b/mlutils/Makefile.am index e86d7bb..38a683f 100644 --- a/mlutils/Makefile.am +++ b/mlutils/Makefile.am...

...I $(top_builddir)/gnulib/lib/.libs \ -I $(top_builddir)/ocaml \ @@ -334,6 +336,7 @@ virt_index_validate_CPPFLAGS = \ -I. \ -I$(top_builddir) \ -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ + -I$(top_srcdir)/common/utils \ -I$(top_srcdir)/src virt_index_validate_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ diff --git a/cat/Makefile.am b/cat/Makefile.am index 8a549b6..66d9356 100644 --- a/cat/Makefile.am +++ b/cat/Makefile.am @@ -43,6 +43,7 @@ virt_cat_SOURCES = \ virt_cat_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ -DLOCALEBASEDIR=\""$(datadir)/locale"\" \...

...diff --git a/common/mlaugeas/Makefile.am b/common/mlaugeas/Makefile.am index d71d0074d..0f3cea820 100644 --- a/common/mlaugeas/Makefile.am +++ b/common/mlaugeas/Makefile.am @@ -53,7 +53,7 @@ libmlaugeas_a_CPPFLAGS = \ -I$(top_builddir) \ -I$(shell $(OCAMLC) -where) libmlaugeas_a_CFLAGS = \ - $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(WARN_CFLAGS) $(NO_SNV_CFLAGS) $(WERROR_CFLAGS) \ $(LIBVIRT_CFLAGS) $(LIBXML2_CFLAGS) \ -fPIC diff --git a/m4/guestfs-c.m4 b/m4/guestfs-c.m4 index 6621a2747..13310d5db 100644 --- a/m4/guestfs-c.m4 +++ b/m4/guestfs-c.m4 @@ -105,6 +105,12 @@ gl_WARN_ADD([-Wformat-truncat...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.

...it work even if gnulib or libxml2 are +# not linked to the main program. +libcleanups_la_SOURCES = \ + cleanups.h \ + stdlib-cleanups.c \ + gnulib-cleanups.c \ + libxml2-cleanups.c +libcleanups_la_CPPFLAGS = \ + -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib +libcleanups_la_CFLAGS = \ + $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(GCC_VISIBILITY_HIDDEN) \ + $(LIBXML2_CFLAGS) diff --git a/common/cleanups/cleanups.h b/common/cleanups/cleanups.h new file mode 100644 index 000000000..211bce98a --- /dev/null +++ b/common/cleanups/cleanups.h @@ -0,0 +1,78 @@ +/* libguestfs + * Copyright (C) 2013-2017 Red H...

...n index c4551fa6c..6b806101e 100644 --- a/ruby/ext/guestfs/extconf.rb.in +++ b/ruby/ext/guestfs/extconf.rb.in @@ -33,8 +33,9 @@ have_func("rb_define_alloc_func") have_type("rb_alloc_func_t") $CFLAGS = - "#{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE=1 " << - "@WARN_CFLAGS@ @WERROR_CFLAGS@" + "#{$CFLAGS} " << + "@WARN_CFLAGS@ @WERROR_CFLAGS@ " << + "@CFLAGS@ -DGUESTFS_PRIVATE=1" create_header create_makefile(extension_name, "@abs_srcdir@") -- 2.13.4

...e.am +++ b/tests/regressions/Makefile.am @@ -130,8 +130,7 @@ rhbz914931_LDADD = \ rhbz1055452_SOURCES = rhbz1055452.c rhbz1055452_CPPFLAGS = \ - -I$(top_srcdir)/src -I$(top_builddir)/src \ - -DGUESTFS_PRIVATE=1 + -I$(top_srcdir)/src -I$(top_builddir)/src rhbz1055452_CFLAGS = \ -pthread \ $(WARN_CFLAGS) $(WERROR_CFLAGS) @@ -140,8 +139,7 @@ rhbz1055452_LDADD = \ test_big_heap_SOURCES = test-big-heap.c test_big_heap_CPPFLAGS = \ - -I$(top_srcdir)/src -I$(top_builddir)/src \ - -DGUESTFS_PRIVATE=1 + -I$(top_srcdir)/src -I$(top_builddir)/src test_big_heap_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFL...

I needed to add a few patches to be able to build libguestfs 1.20.2 out of tree. Mostly srcdir/builddir issues -- I think that I had posted something for building the daemon before. As mentioned on IRC, I found that compiling (Ruby bindings) caused config.h file shipped with the Ruby headers to be included rather than ${builddir}/config.h. This can be fixed because the relevant checks can be

...ndex cb9188e..d32b7fc 100644 --- a/capitests/Makefile.am +++ b/capitests/Makefile.am @@ -129,6 +129,7 @@ test_debug_to_file_SOURCES = test-debug-to-file.c test_debug_to_file_CFLAGS = \ -I$(top_srcdir)/src -I$(top_builddir)/src \ -I$(top_srcdir)/gnulib/lib \ + -I$(top_builddir)/gnulib/lib \ $(WARN_CFLAGS) $(WERROR_CFLAGS) test_debug_to_file_LDADD = \ $(top_builddir)/src/libguestfs.la \ diff --git a/daemon/Makefile.am b/daemon/Makefile.am index c4a30bc..71d6a63 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -176,7 +176,7 @@ guestfsd_LDADD = \ $(LIBINTL) \ $(SERVENT_LIB) -guest...

...bility=hidden]) AC_COMPILE_IFELSE([AC_LANG_SOURCE([[char foo;]])], [ AC_MSG_RESULT([yes]) ], [ AC_MSG_RESULT([no]) CFLAGS="$saved_CFLAGS" ]) +AS_IF([test x"$MINGW32" = x"yes"], [CFLAGS="$saved_CFLAGS"]) CFLAGS="$CFLAGS -W" warn_CFLAGS="-Wall -Wextra -Wcast-align -Wnested-externs -Wshadow -Wstrict-prototypes" saved_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS $warn_CFLAGS" AC_MSG_CHECKING([if ${CC} supports ${warn_CFLAGS}]) -- O.S.

...uestfs build directory. --- v2v/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v2v/Makefile.am b/v2v/Makefile.am index 2a196d45d..104420d13 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -197,6 +197,7 @@ virt_v2v_CPPFLAGS = \ -I$(top_srcdir)/lib virt_v2v_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(LIBGUESTFS_CFLAGS) \ $(LIBVIRT_CFLAGS) \ $(LIBOSINFO_CFLAGS) @@ -230,6 +231,7 @@ endif OCAMLCLIBS = \ -lqemuopts \ + $(LIBGUESTFS_LIBS) \ $(LIBVIRT_LIBS) \ $(LIBXML2_LIBS) \ $(JANSSON_LIBS) \ -- 2.24.1

...ED_SOURCE_FILES = \ ../df/estimate-max-threads.h \ ../df/parallel.c \ ../df/parallel.h \ - ../fish/config.c \ ../fish/decrypt.c \ ../fish/display-options.h \ ../fish/display-options.c \ @@ -59,12 +58,10 @@ virt_alignment_scan_CPPFLAGS = \ virt_alignment_scan_CFLAGS = \ -pthread \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ - $(LIBCONFIG_CFLAGS) \ $(LIBXML2_CFLAGS) \ $(LIBVIRT_CFLAGS) virt_alignment_scan_LDADD = \ - $(LIBCONFIG_LIBS) \ $(top_builddir)/src/libutils.la \ $(top_builddir)/src/libguestfs.la \ $(LIBXML2_LIBS) \ diff --git a/df/Makefile.am b/df/Makefile.am index 6efc1dc..f4a...

.../Makefile.am index 8c1e887..c593630 100644 --- a/erlang/Makefile.am +++ b/erlang/Makefile.am @@ -45,6 +45,7 @@ erl_guestfs_CFLAGS = \ -I$(top_srcdir)/src -I$(top_builddir)/src \ -I$(srcdir)/../gnulib/lib -I../gnulib/lib \ -I$(ERLANG_LIB_DIR_erl_interface)/include \ + -DGUESTFS_PRIVATE=1 \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ $(GPROF_CFLAGS) $(GCOV_CFLAGS) diff --git a/generator/actions.ml b/generator/actions.ml index 94f728f..a97b867 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -28,7 +28,7 @@ let defaults = { name = ""; style = RErr, [], []; proc_nr = None;...

...xml/hivexml.c | 2 ++ 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index cfd2e05..a339a00 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -39,7 +39,10 @@ libhivex_la_LDFLAGS = \ $(LTLIBINTL) \ $(LTLIBTHREAD) libhivex_la_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS) -libhivex_la_CPPFLAGS = -I$(top_srcdir)/gnulib/lib -I$(srcdir) +libhivex_la_CPPFLAGS = \ + -I$(top_srcdir)/gnulib/lib \ + -I$(top_builddir)/gnulib/lib \ + -I$(srcdir) include_HEADERS = hivex.h diff --git a/sh/Makefile.am b/sh/Makefile.am index 0898370..a6f5ae6 100644 ---...

...1.6.4.1.359.g4fc77 >From e933691fd1c1a5543c05fcd209ce57daf6cac4f7 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 24 Aug 2009 11:39:42 +0200 Subject: [PATCH libguestfs 4/4] build: enable gcc warnings in capitests/ and ocaml/ * capitests/Makefile.am: Use $(WARN_CFLAGS) and $(WERROR_CFLAGS). * ocaml/Makefile.am:: Likewise. --- capitests/Makefile.am | 3 ++- ocaml/Makefile.am | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/capitests/Makefile.am b/capitests/Makefile.am index 361c6a3..3b80c0e 100644 --- a/capitests/Makefile.am +++...

...to be a bug in gcc 4.5.1. gl_WARN_ADD([-Wno-strict-overflow]) + # Missing field initializers is not a bug in C. Adding this to $nw above + # did not work, so force it here instead. + gl_WARN_ADD([-Wno-missing-field-initializers]) + gl_WARN_ADD([-fdiagnostics-show-option]) AC_SUBST([WARN_CFLAGS]) -- 1.7.6

Simplifies the build a bit. This is on top of the previous SELinux relabelling patch set, although not related to it. Rich.

...ile.am @@ -186,7 +186,8 @@ guestfsd_LDADD = \ $(LIBINTL) \ $(SERVENT_LIB) \ $(PCRE_LIBS) \ - $(TSK_LIBS) + $(TSK_LIBS) \ + $(RPC_LIBS) guestfsd_CPPFLAGS = \ -I$(top_srcdir)/gnulib/lib \ @@ -199,6 +200,7 @@ guestfsd_CPPFLAGS = \ -I$(top_builddir)/common/protocol guestfsd_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(RPC_CFLAGS) \ $(AUGEAS_CFLAGS) \ $(HIVEX_CFLAGS) \ $(SD_JOURNAL_CFLAGS) \ diff --git a/docs/guestfs-building.pod b/docs/guestfs-building.pod index 53a4d94..11ffe5f 100644 --- a/docs/guestfs-building.pod +++ b/docs/guestfs-building.pod @@ -87,8 +87,17 @@ below. =ite...

Since there are deprecated APIs, make sure that users notice they are deprecated in more prominent ways than done so far: - using deprecated C functions now warns by default - it is possible to use the C library making sure no deprecated function is ever used - Python/Ruby/Perl scripts now get warning messages (configured according to their own systems) when deprecated functions are used The