Displaying 10 results from an estimated 10 matches for "wake_up_interruptiable".
2013 Jul 22
3
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...t;
>> I mean the following cases:
>
> (formatting to fit properly:)
>
>>
>> CPU0: CPU1: unplug_port()
>>
>> if (!port->guest_connected) {
>> return POLLHUP;
>> }
>> wake_up_interruptiable()
>>
>> poll_wait(filp, &port->waitqueue, wait);
>
> Agreed, this can happen. I can't think of a way to resolve this. One
> way would be to remove the waitqueue (port->waitqueue = NULL in
> unplug_port()), but I'm not sure of the effect on the other part...
2013 Jul 22
3
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...t;
>> I mean the following cases:
>
> (formatting to fit properly:)
>
>>
>> CPU0: CPU1: unplug_port()
>>
>> if (!port->guest_connected) {
>> return POLLHUP;
>> }
>> wake_up_interruptiable()
>>
>> poll_wait(filp, &port->waitqueue, wait);
>
> Agreed, this can happen. I can't think of a way to resolve this. One
> way would be to remove the waitqueue (port->waitqueue = NULL in
> unplug_port()), but I'm not sure of the effect on the other part...
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...l be blocked forever.
> unplug_port() calls wake_up_interruptible on the waitqueue.
I mean the following cases:
CPU0: CPU1: unplug_port()
if (!port->guest_connected) {
return POLLHUP;
}
wake_up_interruptiable()
poll_wait(filp, &port->waitqueue, wait);
But since it was existed even w/o this series. I agree to keep it as is
and fix on top.
Other looks good.
Thanks
>
> (But the wake_up should be done after guest_connected is set to
> false -- regression introduced in patch 7.)
>
>...
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...l be blocked forever.
> unplug_port() calls wake_up_interruptible on the waitqueue.
I mean the following cases:
CPU0: CPU1: unplug_port()
if (!port->guest_connected) {
return POLLHUP;
}
wake_up_interruptiable()
poll_wait(filp, &port->waitqueue, wait);
But since it was existed even w/o this series. I agree to keep it as is
and fix on top.
Other looks good.
Thanks
>
> (But the wake_up should be done after guest_connected is set to
> false -- regression introduced in patch 7.)
>
>...
2013 Jul 23
1
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...;> (formatting to fit properly:)
>>>
>>>> CPU0: CPU1: unplug_port()
>>>>
>>>> if (!port->guest_connected) {
>>>> return POLLHUP;
>>>> }
>>>> wake_up_interruptiable()
>>>>
>>>> poll_wait(filp, &port->waitqueue, wait);
>>> Agreed, this can happen. I can't think of a way to resolve this. One
>>> way would be to remove the waitqueue (port->waitqueue = NULL in
>>> unplug_port()), but I'm not su...
2013 Jul 23
1
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...;> (formatting to fit properly:)
>>>
>>>> CPU0: CPU1: unplug_port()
>>>>
>>>> if (!port->guest_connected) {
>>>> return POLLHUP;
>>>> }
>>>> wake_up_interruptiable()
>>>>
>>>> poll_wait(filp, &port->waitqueue, wait);
>>> Agreed, this can happen. I can't think of a way to resolve this. One
>>> way would be to remove the waitqueue (port->waitqueue = NULL in
>>> unplug_port()), but I'm not su...
2013 Jul 19
0
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...ls wake_up_interruptible on the waitqueue.
>
> I mean the following cases:
(formatting to fit properly:)
>
> CPU0: CPU1: unplug_port()
>
> if (!port->guest_connected) {
> return POLLHUP;
> }
> wake_up_interruptiable()
>
> poll_wait(filp, &port->waitqueue, wait);
Agreed, this can happen. I can't think of a way to resolve this. One
way would be to remove the waitqueue (port->waitqueue = NULL in
unplug_port()), but I'm not sure of the effect on the other parts
yet. I'll leave this...
2013 Jul 23
0
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
...ean the following cases:
>> (formatting to fit properly:)
>>
>>> CPU0: CPU1: unplug_port()
>>>
>>> if (!port->guest_connected) {
>>> return POLLHUP;
>>> }
>>> wake_up_interruptiable()
>>>
>>> poll_wait(filp, &port->waitqueue, wait);
>> Agreed, this can happen. I can't think of a way to resolve this. One
>> way would be to remove the waitqueue (port->waitqueue = NULL in
>> unplug_port()), but I'm not sure of the effect on...
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
On 07/19/2013 04:16 AM, Amit Shah wrote:
> Between poll() being called and processed, the port can be unplugged.
> Check if this happened, and bail out.
>
> Signed-off-by: Amit Shah <amit.shah at redhat.com>
> ---
> drivers/char/virtio_console.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/char/virtio_console.c
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
On 07/19/2013 04:16 AM, Amit Shah wrote:
> Between poll() being called and processed, the port can be unplugged.
> Check if this happened, and bail out.
>
> Signed-off-by: Amit Shah <amit.shah at redhat.com>
> ---
> drivers/char/virtio_console.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/char/virtio_console.c