search for: wait_

"Richard W.M. Jones" <rjones@redhat.com> writes: > Hi John, > > Looks good. I've attached a slightly modified patch: > > - Don't need to define the WAIT_* timeout in the header file. > > - Call set_conversion_error in the subroutine, so that the > real error can be propagated back to the user. > > - Use memcmp instead of strncmp. > > - Whitespace changes. > > What do you think? > > Rich. Looks good to me. Tha...

...s.h> #include <sys/wait.h> +#include <arpa/inet.h> +#include <netinet/in.h> #include <glib.h> @@ -49,6 +51,7 @@ struct data_conn { static int send_quoted (mexp_h *, const char *s); static pid_t start_qemu_nbd (int nbd_local_port, const char *device); +static int wait_qemu_nbd (int nbd_local_port, int timeout_seconds); static void cleanup_data_conns (struct data_conn *data_conns, size_t nr); static char *generate_libvirt_xml (struct config *, struct data_conn *); static const char *map_interface_to_network (struct config *, const char *interface); @@ -156,6 +1...

Hi John, Looks good. I've attached a slightly modified patch: - Don't need to define the WAIT_* timeout in the header file. - Call set_conversion_error in the subroutine, so that the real error can be propagated back to the user. - Use memcmp instead of strncmp. - Whitespace changes. What do you think? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.co...