search for: vsock_stream_sendmsg

...+------------+ >> | >> | >> +------------------------------------------------------------------+ >> |VSOCK Core Module | >> |ops->sendmsg; (vsock_stream_sendmsg) | >> | -> alloc_skb; /* it will packet a skb buffer, and include vsock | >> | * hdr and payload */ | >> | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| >> |vsock hdr and pay...

...+------------+ >> | >> | >> +------------------------------------------------------------------+ >> |VSOCK Core Module | >> |ops->sendmsg; (vsock_stream_sendmsg) | >> | -> alloc_skb; /* it will packet a skb buffer, and include vsock | >> | * hdr and payload */ | >> | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| >> |vsock hdr and pay...

...| Client | +------------+ | | +------------------------------------------------------------------+ |VSOCK Core Module | |ops->sendmsg; (vsock_stream_sendmsg) | | -> alloc_skb; /* it will packet a skb buffer, and include vsock | | * hdr and payload */ | | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| |vsock hdr and payload, and then call...

...| Client | +------------+ | | +------------------------------------------------------------------+ |VSOCK Core Module | |ops->sendmsg; (vsock_stream_sendmsg) | | -> alloc_skb; /* it will packet a skb buffer, and include vsock | | * hdr and payload */ | | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| |vsock hdr and payload, and then call...

...| >>>> | >>>> +------------------------------------------------------------------+ >>>> |VSOCK Core Module | >>>> |ops->sendmsg; (vsock_stream_sendmsg) | >>>> | -> alloc_skb; /* it will packet a skb buffer, and include vsock | >>>> | * hdr and payload */ | >>>> | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| &gt...

...| >>>> | >>>> +------------------------------------------------------------------+ >>>> |VSOCK Core Module | >>>> |ops->sendmsg; (vsock_stream_sendmsg) | >>>> | -> alloc_skb; /* it will packet a skb buffer, and include vsock | >>>> | * hdr and payload */ | >>>> | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| &gt...

...we can limit the packets sent from the guest. 2. When the host send packets, it help us to increase the parallelism (especially if the guest has 64 KB RX buffers) because the user thread will split packets, calling multiple times transport->stream_enqueue() in net/vmw_vsock/af_vsock.c:vsock_stream_sendmsg() while the vhost_transport_send_pkt_work() send them to the guest. Do you think make sense? Thanks, Stefano

...we can limit the packets sent from the guest. 2. When the host send packets, it help us to increase the parallelism (especially if the guest has 64 KB RX buffers) because the user thread will split packets, calling multiple times transport->stream_enqueue() in net/vmw_vsock/af_vsock.c:vsock_stream_sendmsg() while the vhost_transport_send_pkt_work() send them to the guest. Do you think make sense? Thanks, Stefano

...+ >>> | >>> | >>> +------------------------------------------------------------------+ >>> |VSOCK Core Module | >>> |ops->sendmsg; (vsock_stream_sendmsg) | >>> | -> alloc_skb; /* it will packet a skb buffer, and include vsock | >>> | * hdr and payload */ | >>> | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| >>> |v...

...| >>>>> | >>>>> +------------------------------------------------------------------+ >>>>> |VSOCK Core Module | >>>>> |ops->sendmsg; (vsock_stream_sendmsg) | >>>>> | -> alloc_skb; /* it will packet a skb buffer, and include vsock | >>>>> | * hdr and payload */ | >>>>> | -> dev_queue_xmit(); /* it will call start_xmit(virtio-ne...

...nsport; u64 val; if (level != AF_VSOCK) @@ -1457,6 +1472,7 @@ static int vsock_stream_getsockopt(struct socket *sock, err = 0; sk = sock->sk; vsk = vsock_sk(sk); + transport = vsk->transport; switch (optname) { case SO_VM_SOCKETS_BUFFER_SIZE: @@ -1501,6 +1517,7 @@ static int vsock_stream_sendmsg(struct socket *sock, struct msghdr *msg, { struct sock *sk; struct vsock_sock *vsk; + const struct vsock_transport *transport; ssize_t total_written; long timeout; int err; @@ -1509,6 +1526,7 @@ static int vsock_stream_sendmsg(struct socket *sock, struct msghdr *msg, sk = sock->sk...

...nsport; u64 val; if (level != AF_VSOCK) @@ -1465,6 +1480,7 @@ static int vsock_stream_getsockopt(struct socket *sock, err = 0; sk = sock->sk; vsk = vsock_sk(sk); + transport = vsk->transport; switch (optname) { case SO_VM_SOCKETS_BUFFER_SIZE: @@ -1509,6 +1525,7 @@ static int vsock_stream_sendmsg(struct socket *sock, struct msghdr *msg, { struct sock *sk; struct vsock_sock *vsk; + const struct vsock_transport *transport; ssize_t total_written; long timeout; int err; @@ -1517,6 +1534,7 @@ static int vsock_stream_sendmsg(struct socket *sock, struct msghdr *msg, sk = sock->sk...

...| >>>>>> | >>>>>> +------------------------------------------------------------------+ >>>>>> |VSOCK Core Module | >>>>>> |ops->sendmsg; (vsock_stream_sendmsg) | >>>>>> | -> alloc_skb; /* it will packet a skb buffer, and include vsock | >>>>>> | * hdr and payload */ | >>>>>> | -> dev_queue_xmit(); /* it will call start_xm...

Since now we are able to split packets, we can avoid limiting their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max packet size. Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- net/vmw_vsock/virtio_transport_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

...> +------------+ > | > | > +------------------------------------------------------------------+ > |VSOCK Core Module | > |ops->sendmsg; (vsock_stream_sendmsg) | > | -> alloc_skb; /* it will packet a skb buffer, and include vsock | > | * hdr and payload */ | > | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| > |vsock hdr and payload, and then c...

...t leave the limit for now. > 2. When the host send packets, it help us to increase the parallelism > (especially if the guest has 64 KB RX buffers) because the user thread > will split packets, calling multiple times transport->stream_enqueue() > in net/vmw_vsock/af_vsock.c:vsock_stream_sendmsg() while the > vhost_transport_send_pkt_work() send them to the guest. Sorry, I don't understand the reasoning. Overall this creates more work. Are you saying the benefit is that vhost_transport_send_pkt_work() can run "early" and notify the guest of partial rx data before all...

...+------------+ > | > | > +------------------------------------------------------------------+ > |VSOCK Core Module | > |ops->sendmsg; (vsock_stream_sendmsg) | > | -> alloc_skb; /* it will packet a skb buffer, and include vsock | > | * hdr and payload */ | > | -> dev_queue_xmit(); /* it will call start_xmit(virtio-net.c) */| > |vsock hdr and payload, and then c...

...> > > 2. When the host send packets, it help us to increase the parallelism > > (especially if the guest has 64 KB RX buffers) because the user thread > > will split packets, calling multiple times transport->stream_enqueue() > > in net/vmw_vsock/af_vsock.c:vsock_stream_sendmsg() while the > > vhost_transport_send_pkt_work() send them to the guest. > > Sorry, I don't understand the reasoning. Overall this creates more > work. Are you saying the benefit is that > vhost_transport_send_pkt_work() can run "early" and notify the guest of &...

...> > > 2. When the host send packets, it help us to increase the parallelism > > (especially if the guest has 64 KB RX buffers) because the user thread > > will split packets, calling multiple times transport->stream_enqueue() > > in net/vmw_vsock/af_vsock.c:vsock_stream_sendmsg() while the > > vhost_transport_send_pkt_work() send them to the guest. > > Sorry, I don't understand the reasoning. Overall this creates more > work. Are you saying the benefit is that > vhost_transport_send_pkt_work() can run "early" and notify the guest of &...

...t;svm_port)) { err = -ENETUNREACH; goto out; } - /* Set the remote address that we are connecting to. */ - memcpy(&vsk->remote_addr, remote_addr, - sizeof(vsk->remote_addr)); - err = vsock_auto_bind(vsk); if (err) goto out; @@ -1586,7 +1651,7 @@ static int vsock_stream_sendmsg(struct socket *sock, struct msghdr *msg, goto out; } - if (sk->sk_state != TCP_ESTABLISHED || + if (!transport || sk->sk_state != TCP_ESTABLISHED || !vsock_addr_bound(&vsk->local_addr)) { err = -ENOTCONN; goto out; @@ -1712,7 +1777,7 @@ vsock_stream_recvmsg(struct so...