search for: vsock_find_unbound_socket

...et/af_vsock.h +++ b/include/net/af_vsock.h @@ -172,8 +172,10 @@ void vsock_insert_connected(struct vsock_sock *vsk); void vsock_remove_bound(struct vsock_sock *vsk); void vsock_remove_connected(struct vsock_sock *vsk); struct sock *vsock_find_bound_socket(struct sockaddr_vm *addr); +struct sock *vsock_find_unbound_socket(struct sockaddr_vm *addr); struct sock *vsock_find_connected_socket(struct sockaddr_vm *src, struct sockaddr_vm *dst); void vsock_for_each_connected_socket(void (*fn)(struct sock *sk)); +int vsock_bind_dgram_generic(struct vsock_sock *vsk, struct sockaddr_vm *addr); #endif /* __AF_VSOCK...

...tream and userspace/guests start relying on it, we'll be stuck supporting this version in addition to whatever we really want, with no easy way to even test it. Might it not be better to defer enabling this upstream until the interface is finalized? > Asias He (5): > VSOCK: Introduce vsock_find_unbound_socket and > vsock_bind_dgram_generic > VSOCK: Introduce virtio-vsock-common.ko > VSOCK: Introduce virtio-vsock.ko > VSOCK: Introduce vhost-vsock.ko > VSOCK: Add Makefile and Kconfig > > drivers/vhost/Kconfig | 4 + > drivers/vhost/Kconfig.vsock...

...will be able to establish connections (i.e. to connect to a guest agent). This is for security reasons since there is currently no ability to provide host services only to certain guests. This also matches how AF_VSOCK works on modern VMware hypervisors. Asias He (5): VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic VSOCK: Introduce virtio-vsock-common.ko VSOCK: Introduce virtio-vsock.ko VSOCK: Introduce vhost-vsock.ko VSOCK: Add Makefile and Kconfig drivers/vhost/Kconfig | 4 + drivers/vhost/Kconfig.vsock | 7 + drivers/vhost/Makef...

...will be able to establish connections (i.e. to connect to a guest agent). This is for security reasons since there is currently no ability to provide host services only to certain guests. This also matches how AF_VSOCK works on modern VMware hypervisors. Asias He (5): VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic VSOCK: Introduce virtio-vsock-common.ko VSOCK: Introduce virtio-vsock.ko VSOCK: Introduce vhost-vsock.ko VSOCK: Add Makefile and Kconfig drivers/vhost/Kconfig | 4 + drivers/vhost/Kconfig.vsock | 7 + drivers/vhost/Makef...

...k_hdr. > > The guest driver should make the receive virtqueue as fully populated as > possible: if it runs out, the performance will suffer. > > The controlq is used to control device. Currently, no control operation is > defined. > > Asias He (5): > VSOCK: Introduce vsock_find_unbound_socket and > vsock_bind_dgram_generic > VSOCK: Introduce virtio-vsock-common.ko > VSOCK: Introduce virtio-vsock.ko > VSOCK: Introduce vhost-vsock.ko > VSOCK: Add Makefile and Kconfig > > drivers/vhost/Kconfig | 4 + > drivers/vhost/Kconfig.vsock...

...quot;VSOCK: fix returnvar.cocci warnings" Revert "VSOCK: Add Makefile and Kconfig" Revert "VSOCK: Introduce vhost-vsock.ko" Revert "VSOCK: Introduce virtio-vsock.ko" Revert "VSOCK: Introduce virtio-vsock-common.ko" Revert "VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic" drivers/vhost/Kconfig | 4 - drivers/vhost/Kconfig.vsock | 7 - drivers/vhost/Makefile | 4 - drivers/vhost/vsock.c | 630 --------------- drivers/vhost/vsock.h |...

...quot;VSOCK: fix returnvar.cocci warnings" Revert "VSOCK: Add Makefile and Kconfig" Revert "VSOCK: Introduce vhost-vsock.ko" Revert "VSOCK: Introduce virtio-vsock.ko" Revert "VSOCK: Introduce virtio-vsock-common.ko" Revert "VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic" drivers/vhost/Kconfig | 4 - drivers/vhost/Kconfig.vsock | 7 - drivers/vhost/Makefile | 4 - drivers/vhost/vsock.c | 630 --------------- drivers/vhost/vsock.h |...

...ce specification. TODO: * Flexible virtqueue descriptor layout * Avoid Linux-specific constants in packet headers (SOCK_STREAM/SOCK_DGRAM) * Send RST if there is no listening SOCK_STREAM socket * Add missing input validation for packet headers and vhost ioctls Asias He (6): VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic Add dgram_skb to vsock_sock VSOCK: Introduce virtio-vsock-common.ko VSOCK: Introduce virtio-vsock.ko VSOCK: Introduce vhost-vsock.ko VSOCK: Add Makefile and Kconfig drivers/vhost/Kconfig | 4 + drivers/vhost/Kconfig.vsock...

...ce specification. TODO: * Flexible virtqueue descriptor layout * Avoid Linux-specific constants in packet headers (SOCK_STREAM/SOCK_DGRAM) * Send RST if there is no listening SOCK_STREAM socket * Add missing input validation for packet headers and vhost ioctls Asias He (6): VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic Add dgram_skb to vsock_sock VSOCK: Introduce virtio-vsock-common.ko VSOCK: Introduce virtio-vsock.ko VSOCK: Introduce vhost-vsock.ko VSOCK: Add Makefile and Kconfig drivers/vhost/Kconfig | 4 + drivers/vhost/Kconfig.vsock...

...datagram is fragmented into multiple small 4KB pkt. The guest driver should make the receive virtqueue as fully populated as possible: if it runs out, the performance will suffer. The controlq is used to control device. Currently, no control operation is defined. Asias He (7): VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic VSOCK: Add dgram_skb to vsock_sock VSOCK: Introduce virtio-vsock-common.ko VSOCK: Introduce virtio-vsock.ko VSOCK: Introduce vhost-vsock.ko VSOCK: Add Makefile and Kconfig Disable debug drivers/vhost/Kconfig | 4 + drive...

...datagram is fragmented into multiple small 4KB pkt. The guest driver should make the receive virtqueue as fully populated as possible: if it runs out, the performance will suffer. The controlq is used to control device. Currently, no control operation is defined. Asias He (7): VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic VSOCK: Add dgram_skb to vsock_sock VSOCK: Introduce virtio-vsock-common.ko VSOCK: Introduce virtio-vsock.ko VSOCK: Introduce vhost-vsock.ko VSOCK: Add Makefile and Kconfig Disable debug drivers/vhost/Kconfig | 4 + drive...

...ays included in the packet header virtio_vsock_hdr. The guest driver should make the receive virtqueue as fully populated as possible: if it runs out, the performance will suffer. The controlq is used to control device. Currently, no control operation is defined. Asias He (5): VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic VSOCK: Introduce virtio-vsock-common.ko VSOCK: Introduce virtio-vsock.ko VSOCK: Introduce vhost-vsock.ko VSOCK: Add Makefile and Kconfig drivers/vhost/Kconfig | 4 + drivers/vhost/Kconfig.vsock | 7 + drivers/vhost/Makefil...

...ays included in the packet header virtio_vsock_hdr. The guest driver should make the receive virtqueue as fully populated as possible: if it runs out, the performance will suffer. The controlq is used to control device. Currently, no control operation is defined. Asias He (5): VSOCK: Introduce vsock_find_unbound_socket and vsock_bind_dgram_generic VSOCK: Introduce virtio-vsock-common.ko VSOCK: Introduce virtio-vsock.ko VSOCK: Introduce vhost-vsock.ko VSOCK: Add Makefile and Kconfig drivers/vhost/Kconfig | 4 + drivers/vhost/Kconfig.vsock | 7 + drivers/vhost/Makefil...

...et/af_vsock.h +++ b/include/net/af_vsock.h @@ -175,10 +175,8 @@ void vsock_insert_connected(struct vsock_sock *vsk); void vsock_remove_bound(struct vsock_sock *vsk); void vsock_remove_connected(struct vsock_sock *vsk); struct sock *vsock_find_bound_socket(struct sockaddr_vm *addr); -struct sock *vsock_find_unbound_socket(struct sockaddr_vm *addr); struct sock *vsock_find_connected_socket(struct sockaddr_vm *src, struct sockaddr_vm *dst); void vsock_for_each_connected_socket(void (*fn)(struct sock *sk)); -int vsock_bind_dgram_generic(struct vsock_sock *vsk, struct sockaddr_vm *addr); #endif /* __AF_VSOCK...

...et/af_vsock.h +++ b/include/net/af_vsock.h @@ -175,10 +175,8 @@ void vsock_insert_connected(struct vsock_sock *vsk); void vsock_remove_bound(struct vsock_sock *vsk); void vsock_remove_connected(struct vsock_sock *vsk); struct sock *vsock_find_bound_socket(struct sockaddr_vm *addr); -struct sock *vsock_find_unbound_socket(struct sockaddr_vm *addr); struct sock *vsock_find_connected_socket(struct sockaddr_vm *src, struct sockaddr_vm *dst); void vsock_for_each_connected_socket(void (*fn)(struct sock *sk)); -int vsock_bind_dgram_generic(struct vsock_sock *vsk, struct sockaddr_vm *addr); #endif /* __AF_VSOCK...

...gt; + struct sock *sk; > + > + vsock_addr_init(&src, pkt->hdr.src_cid, pkt->hdr.src_port); > + vsock_addr_init(&dst, pkt->hdr.dst_cid, pkt->hdr.dst_port); > + > + virtio_vsock_dumppkt(__func__, pkt); > + > + if (pkt->hdr.type == SOCK_DGRAM) { > + sk = vsock_find_unbound_socket(&dst); > + if (!sk) > + goto free_pkt; > + return virtio_transport_recv_dgram(sk, pkt); > + } > + > + /* The socket must be in connected or bound table > + * otherwise send reset back > + */ > + sk = vsock_find_connected_socket(&src, &dst); > + if (!s...

...gt; + struct sock *sk; > + > + vsock_addr_init(&src, pkt->hdr.src_cid, pkt->hdr.src_port); > + vsock_addr_init(&dst, pkt->hdr.dst_cid, pkt->hdr.dst_port); > + > + virtio_vsock_dumppkt(__func__, pkt); > + > + if (pkt->hdr.type == SOCK_DGRAM) { > + sk = vsock_find_unbound_socket(&dst); > + if (!sk) > + goto free_pkt; > + return virtio_transport_recv_dgram(sk, pkt); > + } > + > + /* The socket must be in connected or bound table > + * otherwise send reset back > + */ > + sk = vsock_find_connected_socket(&src, &dst); > + if (!s...

...addr_vm src, dst; + struct vsock_sock *vsk; + struct sock *sk; + + vsock_addr_init(&src, pkt->hdr.src_cid, pkt->hdr.src_port); + vsock_addr_init(&dst, pkt->hdr.dst_cid, pkt->hdr.dst_port); + + virtio_vsock_dumppkt(__func__, pkt); + + if (pkt->hdr.type == SOCK_DGRAM) { + sk = vsock_find_unbound_socket(&dst); + if (!sk) + goto free_pkt; + return virtio_transport_recv_dgram(sk, pkt); + } + + /* The socket must be in connected or bound table + * otherwise send reset back + */ + sk = vsock_find_connected_socket(&src, &dst); + if (!sk) { + sk = vsock_find_bound_socket(&dst); +...

...+ vsock_addr_init(&src, le32_to_cpu(pkt->hdr.src_cid), le32_to_cpu(pkt->hdr.src_port)); + vsock_addr_init(&dst, le32_to_cpu(pkt->hdr.dst_cid), le32_to_cpu(pkt->hdr.dst_port)); + + virtio_vsock_dumppkt(__func__, pkt); + + if (le16_to_cpu(pkt->hdr.type) == SOCK_DGRAM) { + sk = vsock_find_unbound_socket(&dst); + if (!sk) + goto free_pkt; + + vsk = vsock_sk(sk); + trans = vsk->trans; + BUG_ON(!trans); + + /* TODO: need a helper for this */ + /* buf_alloc and fwd_cnt is always included in the hdr */ + mutex_lock(&trans->tx_lock); + trans->peer_buf_alloc = le32_to_cpu(pkt-&...