search for: vring_used_delay

...wanting exactly the same thing, which means we'd deprecate this in the next virtio standard. I think the right answer is to extend like we did with vring_used_event(), eg: 1) Add a new feature VIRTIO_F_RING_COALESCE. 2) Add another a 32-bit field after vring_used_event(), eg: #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) This loses the ability to coalesce by number of frames, but we can still do number of sg entries, as we do now with used_event, and we could change virtqueue_enable_cb_delayed() to take a precise number if we wanted. My feeling is that thi...

...wanting exactly the same thing, which means we'd deprecate this in the next virtio standard. I think the right answer is to extend like we did with vring_used_event(), eg: 1) Add a new feature VIRTIO_F_RING_COALESCE. 2) Add another a 32-bit field after vring_used_event(), eg: #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) This loses the ability to coalesce by number of frames, but we can still do number of sg entries, as we do now with used_event, and we could change virtqueue_enable_cb_delayed() to take a precise number if we wanted. My feeling is that thi...

...this in the next virtio standard. >> >> I think the right answer is to extend like we did with >> vring_used_event(), eg: >> >> 1) Add a new feature VIRTIO_F_RING_COALESCE. >> 2) Add another a 32-bit field after vring_used_event(), eg: >> #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) >> >> This loses the ability to coalesce by number of frames, but we can still >> do number of sg entries, as we do now with used_event, and we could >> change virtqueue_enable_cb_delayed() to take a precise number i...

...this in the next virtio standard. >> >> I think the right answer is to extend like we did with >> vring_used_event(), eg: >> >> 1) Add a new feature VIRTIO_F_RING_COALESCE. >> 2) Add another a 32-bit field after vring_used_event(), eg: >> #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) >> >> This loses the ability to coalesce by number of frames, but we can still >> do number of sg entries, as we do now with used_event, and we could >> change virtqueue_enable_cb_delayed() to take a precise number i...

...ich means we'd deprecate this in the next virtio standard. > > I think the right answer is to extend like we did with > vring_used_event(), eg: > > 1) Add a new feature VIRTIO_F_RING_COALESCE. > 2) Add another a 32-bit field after vring_used_event(), eg: > #define vring_used_delay(vr) (*(u32 > *)((vr)->avail->ring[(vr)->num + 2])) Yes. This looks better and we don't even need device specific configuration method. > > This loses the ability to coalesce by number of frames, but we can > still > do number of sg entries, as we do now with used_e...

...ich means we'd deprecate this in the next virtio standard. > > I think the right answer is to extend like we did with > vring_used_event(), eg: > > 1) Add a new feature VIRTIO_F_RING_COALESCE. > 2) Add another a 32-bit field after vring_used_event(), eg: > #define vring_used_delay(vr) (*(u32 > *)((vr)->avail->ring[(vr)->num + 2])) Yes. This looks better and we don't even need device specific configuration method. > > This loses the ability to coalesce by number of frames, but we can > still > do number of sg entries, as we do now with used_e...

...> >> > >> I think the right answer is to extend like we did with > >> vring_used_event(), eg: > >> > >> 1) Add a new feature VIRTIO_F_RING_COALESCE. > >> 2) Add another a 32-bit field after vring_used_event(), eg: > >> #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) > >> > >> This loses the ability to coalesce by number of frames, but we can still > >> do number of sg entries, as we do now with used_event, and we could > >> change virtqueue_enable_cb_delayed() to tak...

...> >> > >> I think the right answer is to extend like we did with > >> vring_used_event(), eg: > >> > >> 1) Add a new feature VIRTIO_F_RING_COALESCE. > >> 2) Add another a 32-bit field after vring_used_event(), eg: > >> #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) > >> > >> This loses the ability to coalesce by number of frames, but we can still > >> do number of sg entries, as we do now with used_event, and we could > >> change virtqueue_enable_cb_delayed() to tak...

...> >> > >> I think the right answer is to extend like we did with > >> vring_used_event(), eg: > >> > >> 1) Add a new feature VIRTIO_F_RING_COALESCE. > >> 2) Add another a 32-bit field after vring_used_event(), eg: > >> #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) > >> > >> This loses the ability to coalesce by number of frames, but we can still > >> do number of sg entries, as we do now with used_event, and we could > >> change virtqueue_enable_cb_delayed() to tak...

...> >> > >> I think the right answer is to extend like we did with > >> vring_used_event(), eg: > >> > >> 1) Add a new feature VIRTIO_F_RING_COALESCE. > >> 2) Add another a 32-bit field after vring_used_event(), eg: > >> #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) > >> > >> This loses the ability to coalesce by number of frames, but we can still > >> do number of sg entries, as we do now with used_event, and we could > >> change virtqueue_enable_cb_delayed() to tak...

...ich means we'd deprecate this in the next virtio standard. > > I think the right answer is to extend like we did with > vring_used_event(), eg: > > 1) Add a new feature VIRTIO_F_RING_COALESCE. > 2) Add another a 32-bit field after vring_used_event(), eg: > #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) > > This loses the ability to coalesce by number of frames, but we can still > do number of sg entries, as we do now with used_event, and we could > change virtqueue_enable_cb_delayed() to take a precise number if we > wanted...

...ich means we'd deprecate this in the next virtio standard. > > I think the right answer is to extend like we did with > vring_used_event(), eg: > > 1) Add a new feature VIRTIO_F_RING_COALESCE. > 2) Add another a 32-bit field after vring_used_event(), eg: > #define vring_used_delay(vr) (*(u32 *)((vr)->avail->ring[(vr)->num + 2])) > > This loses the ability to coalesce by number of frames, but we can still > do number of sg entries, as we do now with used_event, and we could > change virtqueue_enable_cb_delayed() to take a precise number if we > wanted...

Hi: This is a new version of trying to enable tx interrupts for virtio-net. We used to try to avoid tx interrupts and orphan packets before transmission for virtio-net. This breaks socket accounting and can lead serveral other side effects e.g: - Several other functions which depends on socket accounting can not work correctly (e.g TCP Small Queue) - No tx completion which make BQL or

Hi: This is a new version of trying to enable tx interrupts for virtio-net. We used to try to avoid tx interrupts and orphan packets before transmission for virtio-net. This breaks socket accounting and can lead serveral other side effects e.g: - Several other functions which depends on socket accounting can not work correctly (e.g TCP Small Queue) - No tx completion which make BQL or