search for: vring_unmap_one_packed

...; >>> + >>> + /* Clear data ptr. */ >>> + vq->desc_state[id].data = NULL; >>> + >>> + i = head; >>> + >>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>> + desc = &vq->vring_packed.desc[i]; >>> + vring_unmap_one_packed(vq, desc); >> As mentioned in previous discussion, this probably won't work for the case >> of out of order completion since it depends on the information in the >> descriptor ring. We probably need to extend ctx to record such information. > Above code doesn't depend o...

...; >>> + >>> + /* Clear data ptr. */ >>> + vq->desc_state[id].data = NULL; >>> + >>> + i = head; >>> + >>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>> + desc = &vq->vring_packed.desc[i]; >>> + vring_unmap_one_packed(vq, desc); >> As mentioned in previous discussion, this probably won't work for the case >> of out of order completion since it depends on the information in the >> descriptor ring. We probably need to extend ctx to record such information. > Above code doesn't depend o...

...t;>>>> + vq->desc_state[id].data = NULL; >>>>> + >>>>> + i = head; >>>>> + >>>>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>>>> + desc = &vq->vring_packed.desc[i]; >>>>> + vring_unmap_one_packed(vq, desc); >>>> As mentioned in previous discussion, this probably won't work for the case >>>> of out of order completion since it depends on the information in the >>>> descriptor ring. We probably need to extend ctx to record such information. >>>...

...t;>>>> + vq->desc_state[id].data = NULL; >>>>> + >>>>> + i = head; >>>>> + >>>>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>>>> + desc = &vq->vring_packed.desc[i]; >>>>> + vring_unmap_one_packed(vq, desc); >>>> As mentioned in previous discussion, this probably won't work for the case >>>> of out of order completion since it depends on the information in the >>>> descriptor ring. We probably need to extend ctx to record such information. >>>...

...= NULL; >>>>>>> + >>>>>>> + i = head; >>>>>>> + >>>>>>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>>>>>> + desc = &vq->vring_packed.desc[i]; >>>>>>> + vring_unmap_one_packed(vq, desc); >>>>>> As mentioned in previous discussion, this probably won't work for the case >>>>>> of out of order completion since it depends on the information in the >>>>>> descriptor ring. We probably need to extend ctx to record such i...

...= NULL; >>>>>>> + >>>>>>> + i = head; >>>>>>> + >>>>>>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>>>>>> + desc = &vq->vring_packed.desc[i]; >>>>>>> + vring_unmap_one_packed(vq, desc); >>>>>> As mentioned in previous discussion, this probably won't work for the case >>>>>> of out of order completion since it depends on the information in the >>>>>> descriptor ring. We probably need to extend ctx to record such i...

...sc = alloc_indirect_split(_vq, total_sg, gfp); > else { > desc = NULL; > @@ -741,6 +753,63 @@ static inline unsigned vring_size_packed(unsigned int num, unsigned long align) > & ~(align - 1)) + sizeof(struct vring_packed_desc_event) * 2; > } > > +static void vring_unmap_one_packed(const struct vring_virtqueue *vq, > + struct vring_packed_desc *desc) > +{ > + u16 flags; > + > + if (!vring_use_dma_api(vq->vq.vdev)) > + return; > + > + flags = virtio16_to_cpu(vq->vq.vdev, desc->flags); > + > + if (flags & VRING_DESC_F_INDIRECT)...

...sc = alloc_indirect_split(_vq, total_sg, gfp); > else { > desc = NULL; > @@ -741,6 +753,63 @@ static inline unsigned vring_size_packed(unsigned int num, unsigned long align) > & ~(align - 1)) + sizeof(struct vring_packed_desc_event) * 2; > } > > +static void vring_unmap_one_packed(const struct vring_virtqueue *vq, > + struct vring_packed_desc *desc) > +{ > + u16 flags; > + > + if (!vring_use_dma_api(vq->vq.vdev)) > + return; > + > + flags = virtio16_to_cpu(vq->vq.vdev, desc->flags); > + > + if (flags & VRING_DESC_F_INDIRECT)...

...> > > > + vq->desc_state[head].data = NULL; > > > > + > > > > + i = head; > > > > + > > > > + for (j = 0; j < vq->desc_state[head].num; j++) { > > > > + desc = &vq->vring_packed.desc[i]; > > > > + vring_unmap_one_packed(vq, desc); > > > > + desc->flags = 0x0; > > > Looks like this is unnecessary. > > It's safer to zero it. If we don't zero it, after we > > call virtqueue_detach_unused_buf_packed() which calls > > this function, the desc is still available to the &...

...> > > > + vq->desc_state[head].data = NULL; > > > > + > > > > + i = head; > > > > + > > > > + for (j = 0; j < vq->desc_state[head].num; j++) { > > > > + desc = &vq->vring_packed.desc[i]; > > > > + vring_unmap_one_packed(vq, desc); > > > > + desc->flags = 0x0; > > > Looks like this is unnecessary. > > It's safer to zero it. If we don't zero it, after we > > call virtqueue_detach_unused_buf_packed() which calls > > this function, the desc is still available to the &...

...gt;>>>>>>>> + i = head; >>>>>>>>> + >>>>>>>>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>>>>>>>> + desc = &vq->vring_packed.desc[i]; >>>>>>>>> + vring_unmap_one_packed(vq, desc); >>>>>>>> As mentioned in previous discussion, this probably won't work for the case >>>>>>>> of out of order completion since it depends on the information in the >>>>>>>> descriptor ring. We probably need to ext...

...gt;>>>>>>>> + i = head; >>>>>>>>> + >>>>>>>>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>>>>>>>> + desc = &vq->vring_packed.desc[i]; >>>>>>>>> + vring_unmap_one_packed(vq, desc); >>>>>>>> As mentioned in previous discussion, this probably won't work for the case >>>>>>>> of out of order completion since it depends on the information in the >>>>>>>> descriptor ring. We probably need to ext...

...> > > > > > + > > > > > > + i = head; > > > > > > + > > > > > > + for (j = 0; j < vq->desc_state[head].num; j++) { > > > > > > + desc = &vq->vring_packed.desc[i]; > > > > > > + vring_unmap_one_packed(vq, desc); > > > > > > + desc->flags = 0x0; > > > > > Looks like this is unnecessary. > > > > It's safer to zero it. If we don't zero it, after we > > > > call virtqueue_detach_unused_buf_packed() which calls > > > > t...

...> > > > > > + > > > > > > + i = head; > > > > > > + > > > > > > + for (j = 0; j < vq->desc_state[head].num; j++) { > > > > > > + desc = &vq->vring_packed.desc[i]; > > > > > > + vring_unmap_one_packed(vq, desc); > > > > > > + desc->flags = 0x0; > > > > > Looks like this is unnecessary. > > > > It's safer to zero it. If we don't zero it, after we > > > > call virtqueue_detach_unused_buf_packed() which calls > > > > t...

...queue_use_indirect(_vq, total_sg)) desc = alloc_indirect_split(_vq, total_sg, gfp); else { desc = NULL; @@ -741,6 +750,49 @@ static inline unsigned vring_size_packed(unsigned int num, unsigned long align) & ~(align - 1)) + sizeof(struct vring_packed_desc_event) * 2; } +static void vring_unmap_one_packed(const struct vring_virtqueue *vq, + struct vring_packed_desc *desc) +{ + u16 flags; + + if (!vring_use_dma_api(vq->vq.vdev)) + return; + + flags = virtio16_to_cpu(vq->vq.vdev, desc->flags); + + if (flags & VRING_DESC_F_INDIRECT) { + dma_unmap_single(vring_dma_dev(vq), + vir...

.... */ > > > > + vq->desc_state[id].data = NULL; > > > > + > > > > + i = head; > > > > + > > > > + for (j = 0; j < vq->desc_state[id].num; j++) { > > > > + desc = &vq->vring_packed.desc[i]; > > > > + vring_unmap_one_packed(vq, desc); > > > As mentioned in previous discussion, this probably won't work for the case > > > of out of order completion since it depends on the information in the > > > descriptor ring. We probably need to extend ctx to record such information. > > Above co...

...; > > > > > > + > > > > > > + i = head; > > > > > > + > > > > > > + for (j = 0; j < vq->desc_state[id].num; j++) { > > > > > > + desc = &vq->vring_packed.desc[i]; > > > > > > + vring_unmap_one_packed(vq, desc); > > > > > As mentioned in previous discussion, this probably won't work for the case > > > > > of out of order completion since it depends on the information in the > > > > > descriptor ring. We probably need to extend ctx to record such i...

...queue_use_indirect(_vq, total_sg)) desc = alloc_indirect_split(_vq, total_sg, gfp); else { desc = NULL; @@ -741,6 +753,63 @@ static inline unsigned vring_size_packed(unsigned int num, unsigned long align) & ~(align - 1)) + sizeof(struct vring_packed_desc_event) * 2; } +static void vring_unmap_one_packed(const struct vring_virtqueue *vq, + struct vring_packed_desc *desc) +{ + u16 flags; + + if (!vring_use_dma_api(vq->vq.vdev)) + return; + + flags = virtio16_to_cpu(vq->vq.vdev, desc->flags); + + if (flags & VRING_DESC_F_INDIRECT) { + dma_unmap_single(vring_dma_dev(vq), + vir...

...gt; > > > > + i = head; > > > > > > > > + > > > > > > > > + for (j = 0; j < vq->desc_state[id].num; j++) { > > > > > > > > + desc = &vq->vring_packed.desc[i]; > > > > > > > > + vring_unmap_one_packed(vq, desc); > > > > > > > As mentioned in previous discussion, this probably won't work for the case > > > > > > > of out of order completion since it depends on the information in the > > > > > > > descriptor ring. We probably need...

...gt; + i = head; >>>>>>>>>>> + >>>>>>>>>>> + for (j = 0; j < vq->desc_state[id].num; j++) { >>>>>>>>>>> + desc = &vq->vring_packed.desc[i]; >>>>>>>>>>> + vring_unmap_one_packed(vq, desc); >>>>>>>>>> As mentioned in previous discussion, this probably won't work for the case >>>>>>>>>> of out of order completion since it depends on the information in the >>>>>>>>>> descriptor ring....