search for: vring_init_split

...+ if (packed) >>>>>>> + vring_packed_init(&vring.vring_packed, num, queue, vring_align); >>>>>>> + else >>>>>>> + vring_init(&vring.vring_split, num, queue, vring_align); >>>>>> Let's rename vring_init to vring_init_split() like other helpers? >>>>> The vring_init() is a public API in include/uapi/linux/virtio_ring.h. >>>>> I don't think we can rename it. >>>> I see, then this need more thoughts to unify the API. >>> My thought is to keep the old API as is, and...

...+ if (packed) >>>>>>> + vring_packed_init(&vring.vring_packed, num, queue, vring_align); >>>>>>> + else >>>>>>> + vring_init(&vring.vring_split, num, queue, vring_align); >>>>>> Let's rename vring_init to vring_init_split() like other helpers? >>>>> The vring_init() is a public API in include/uapi/linux/virtio_ring.h. >>>>> I don't think we can rename it. >>>> I see, then this need more thoughts to unify the API. >>> My thought is to keep the old API as is, and...

...> > + vring_packed_init(&vring.vring_packed, num, queue, vring_align); > > > > > > > > + else > > > > > > > > + vring_init(&vring.vring_split, num, queue, vring_align); > > > > > > > Let's rename vring_init to vring_init_split() like other helpers? > > > > > > The vring_init() is a public API in include/uapi/linux/virtio_ring.h. > > > > > > I don't think we can rename it. > > > > > I see, then this need more thoughts to unify the API. > > > > My thought i...

..., packed); >>>>> + if (packed) >>>>> + vring_packed_init(&vring.vring_packed, num, queue, vring_align); >>>>> + else >>>>> + vring_init(&vring.vring_split, num, queue, vring_align); >>>> Let's rename vring_init to vring_init_split() like other helpers? >>> The vring_init() is a public API in include/uapi/linux/virtio_ring.h. >>> I don't think we can rename it. >> I see, then this need more thoughts to unify the API. > My thought is to keep the old API as is, and introduce > new types and hel...

..., packed); >>>>> + if (packed) >>>>> + vring_packed_init(&vring.vring_packed, num, queue, vring_align); >>>>> + else >>>>> + vring_init(&vring.vring_split, num, queue, vring_align); >>>> Let's rename vring_init to vring_init_split() like other helpers? >>> The vring_init() is a public API in include/uapi/linux/virtio_ring.h. >>> I don't think we can rename it. >> I see, then this need more thoughts to unify the API. > My thought is to keep the old API as is, and introduce > new types and hel...

...in_bytes = __vring_size(num, vring_align, packed); >>> + if (packed) >>> + vring_packed_init(&vring.vring_packed, num, queue, vring_align); >>> + else >>> + vring_init(&vring.vring_split, num, queue, vring_align); >> Let's rename vring_init to vring_init_split() like other helpers? > The vring_init() is a public API in include/uapi/linux/virtio_ring.h. > I don't think we can rename it. I see, then this need more thoughts to unify the API. > >>> - vq = __vring_new_virtqueue(index, vring, vdev, weak_barriers, context, >>> -...

...in_bytes = __vring_size(num, vring_align, packed); >>> + if (packed) >>> + vring_packed_init(&vring.vring_packed, num, queue, vring_align); >>> + else >>> + vring_init(&vring.vring_split, num, queue, vring_align); >> Let's rename vring_init to vring_init_split() like other helpers? > The vring_init() is a public API in include/uapi/linux/virtio_ring.h. > I don't think we can rename it. I see, then this need more thoughts to unify the API. > >>> - vq = __vring_new_virtqueue(index, vring, vdev, weak_barriers, context, >>> -...

..._align, packed); > > > > + if (packed) > > > > + vring_packed_init(&vring.vring_packed, num, queue, vring_align); > > > > + else > > > > + vring_init(&vring.vring_split, num, queue, vring_align); > > > Let's rename vring_init to vring_init_split() like other helpers? > > The vring_init() is a public API in include/uapi/linux/virtio_ring.h. > > I don't think we can rename it. > > I see, then this need more thoughts to unify the API. My thought is to keep the old API as is, and introduce new types and helpers for pack...

...f (packed) > > > > > > + vring_packed_init(&vring.vring_packed, num, queue, vring_align); > > > > > > + else > > > > > > + vring_init(&vring.vring_split, num, queue, vring_align); > > > > > Let's rename vring_init to vring_init_split() like other helpers? > > > > The vring_init() is a public API in include/uapi/linux/virtio_ring.h. > > > > I don't think we can rename it. > > > I see, then this need more thoughts to unify the API. > > My thought is to keep the old API as is, and introdu...

...queue, vring_align); > + queue_size_in_bytes = __vring_size(num, vring_align, packed); > + if (packed) > + vring_packed_init(&vring.vring_packed, num, queue, vring_align); > + else > + vring_init(&vring.vring_split, num, queue, vring_align); Let's rename vring_init to vring_init_split() like other helpers? > > - vq = __vring_new_virtqueue(index, vring, vdev, weak_barriers, context, > - notify, callback, name); > + vq = __vring_new_virtqueue(index, vring, packed, vdev, weak_barriers, > + context, notify, callback, name); > if (!vq) { >...

...queue, vring_align); > + queue_size_in_bytes = __vring_size(num, vring_align, packed); > + if (packed) > + vring_packed_init(&vring.vring_packed, num, queue, vring_align); > + else > + vring_init(&vring.vring_split, num, queue, vring_align); Let's rename vring_init to vring_init_split() like other helpers? > > - vq = __vring_new_virtqueue(index, vring, vdev, weak_barriers, context, > - notify, callback, name); > + vq = __vring_new_virtqueue(index, vring, packed, vdev, weak_barriers, > + context, notify, callback, name); > if (!vq) { >...

...ueue_size_in_bytes = __vring_size(num, vring_align, packed); > > + if (packed) > > + vring_packed_init(&vring.vring_packed, num, queue, vring_align); > > + else > > + vring_init(&vring.vring_split, num, queue, vring_align); > > Let's rename vring_init to vring_init_split() like other helpers? The vring_init() is a public API in include/uapi/linux/virtio_ring.h. I don't think we can rename it. > > > - vq = __vring_new_virtqueue(index, vring, vdev, weak_barriers, context, > > - notify, callback, name); > > + vq = __vring_new_virtqueu...

Hello everyone, This RFC implements a subset of packed ring which is described at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd08.pdf The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html Minor changes are needed for the vhost code, e.g. to kick the guest. It's not a complete