search for: vring_init_pack

...g.tex#L64-L78 If my understanding is correct, this is just for legacy interfaces, and we won't define layout in packed ring and don't need to support vring_new_virtqueue() in packed ring. Is it correct? Thanks! > > Will do that. > > > > > > +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, > > > + void *p, unsigned long align) > > > +{ > > > + vr->num = num; > > > + vr->desc = p; > > > + vr->driver = (void *)ALIGN(((uintptr_t)p + > > > + sizeof(struct vring_packed_desc...

...; + * struct vring_packed_desc_event driver; > + * > + * // Device Event Suppression > + * struct vring_packed_desc_event device; > + * }; > + */ Why not just allocate event structures separately? Is it a win to have them share a cache line for some reason? > +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, > + void *p, unsigned long align) > +{ > + vr->num = num; > + vr->desc = p; > + vr->driver = (void *)ALIGN(((uintptr_t)p + > + sizeof(struct vring_packed_desc) * num), align); > + vr->device = vr->driver + 1;...

...; + * struct vring_packed_desc_event driver; > + * > + * // Device Event Suppression > + * struct vring_packed_desc_event device; > + * }; > + */ Why not just allocate event structures separately? Is it a win to have them share a cache line for some reason? > +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, > + void *p, unsigned long align) > +{ > + vr->num = num; > + vr->desc = p; > + vr->driver = (void *)ALIGN(((uintptr_t)p + > + sizeof(struct vring_packed_desc) * num), align); > + vr->device = vr->driver + 1;...

...t; + * // Device Event Suppression > > + * struct vring_packed_desc_event device; > > + * }; > > + */ > > Why not just allocate event structures separately? > Is it a win to have them share a cache line for some reason? Will do that. > > > +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, > > + void *p, unsigned long align) > > +{ > > + vr->num = num; > > + vr->desc = p; > > + vr->driver = (void *)ALIGN(((uintptr_t)p + > > + sizeof(struct vring_packed_desc) * num), align); > > +...

...; > > - Refine the packed ring definitions in uapi; > > - Rebase on the net-next tree; > > > > RFC v5 -> RFC v6: > > - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); > > - Define wrap counter as bool (Jason); > > - Use ALIGN() in vring_init_packed() (Jason); > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > - Add comments for barriers (Jason); > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > - Refine the memory barrier in virtqueue_poll(); > > - Add a missin...

...+ * // Padding to the next align boundary. > + * char pad[]; > + * > + * // Driver Event Suppression > + * struct vring_packed_desc_event driver; > + * > + * // Device Event Suppression > + * struct vring_packed_desc_event device; > + * }; > + */ > +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, > + void *p, unsigned long align) > +{ > + vr->num = num; > + vr->desc = p; > + vr->driver = (void *)(((uintptr_t)p + sizeof(struct vring_packed_desc) > + * num + align - 1) & ~(align - 1)); If we choose not to go...

...+ * // Padding to the next align boundary. > + * char pad[]; > + * > + * // Driver Event Suppression > + * struct vring_packed_desc_event driver; > + * > + * // Device Event Suppression > + * struct vring_packed_desc_event device; > + * }; > + */ > +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, > + void *p, unsigned long align) > +{ > + vr->num = num; > + vr->desc = p; > + vr->driver = (void *)(((uintptr_t)p + sizeof(struct vring_packed_desc) > + * num + align - 1) & ~(align - 1)); If we choose not to go...

...t; > > > - Rebase on the net-next tree; > > > > > > > > RFC v5 -> RFC v6: > > > > - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); > > > > - Define wrap counter as bool (Jason); > > > > - Use ALIGN() in vring_init_packed() (Jason); > > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > > - Add comments for barriers (Jason); > > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > > > - Refine the memory barrier in vi...

...gt; + * char pad[]; > > + * > > + * // Driver Event Suppression > > + * struct vring_packed_desc_event driver; > > + * > > + * // Device Event Suppression > > + * struct vring_packed_desc_event device; > > + * }; > > + */ > > +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, > > + void *p, unsigned long align) > > +{ > > + vr->num = num; > > + vr->desc = p; > > + vr->driver = (void *)(((uintptr_t)p + sizeof(struct vring_packed_desc) > > + * num + align - 1) & ~(align...

...each) + * struct vring_packed_desc desc[num]; + * + * // Padding to the next align boundary. + * char pad[]; + * + * // Driver Event Suppression + * struct vring_packed_desc_event driver; + * + * // Device Event Suppression + * struct vring_packed_desc_event device; + * }; + */ +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, + void *p, unsigned long align) +{ + vr->num = num; + vr->desc = p; + vr->driver = (void *)(((uintptr_t)p + sizeof(struct vring_packed_desc) + * num + align - 1) & ~(align - 1)); + vr->device = vr->driver + 1; +} + +static inl...

...each) + * struct vring_packed_desc desc[num]; + * + * // Padding to the next align boundary. + * char pad[]; + * + * // Driver Event Suppression + * struct vring_packed_desc_event driver; + * + * // Device Event Suppression + * struct vring_packed_desc_event device; + * }; + */ +static inline void vring_init_packed(struct vring_packed *vr, unsigned int num, + void *p, unsigned long align) +{ + vr->num = num; + vr->desc = p; + vr->driver = (void *)ALIGN(((uintptr_t)p + + sizeof(struct vring_packed_desc) * num), align); + vr->device = vr->driver + 1; +} + +static inline unsigned vring_...

...irtqueue_enable_cb_prepare_packed(); > - Refine the packed ring definitions in uapi; > - Rebase on the net-next tree; > > RFC v5 -> RFC v6: > - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); > - Define wrap counter as bool (Jason); > - Use ALIGN() in vring_init_packed() (Jason); > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > - Add comments for barriers (Jason); > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > - Refine the memory barrier in virtqueue_poll(); > - Add a missing memory barrier in virtq...

...gt; > > > > > > > > > > > RFC v5 -> RFC v6: > > > > > > - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); > > > > > > - Define wrap counter as bool (Jason); > > > > > > - Use ALIGN() in vring_init_packed() (Jason); > > > > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > > > > - Add comments for barriers (Jason); > > > > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > > > &gt...

...irtqueue_enable_cb_prepare_packed(); > - Refine the packed ring definitions in uapi; > - Rebase on the net-next tree; > > RFC v5 -> RFC v6: > - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); > - Define wrap counter as bool (Jason); > - Use ALIGN() in vring_init_packed() (Jason); > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > - Add comments for barriers (Jason); > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > - Refine the memory barrier in virtqueue_poll(); > - Add a missing memory barrier in virtq...

...d ring definitions in uapi; > > > - Rebase on the net-next tree; > > > > > > RFC v5 -> RFC v6: > > > - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); > > > - Define wrap counter as bool (Jason); > > > - Use ALIGN() in vring_init_packed() (Jason); > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > - Add comments for barriers (Jason); > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > > - Refine the memory barrier in virtqueue_poll(); >...

...ping and netperf worked as expected. TODO: - Refinements (for code and commit log); - More tests and bug fixes if any; - Send the formal patch set; RFC v5 -> RFC v6: - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); - Define wrap counter as bool (Jason); - Use ALIGN() in vring_init_packed() (Jason); - Avoid using pointer to track `next` in detach_buf_packed() (Jason); - Add comments for barriers (Jason); - Don't enable RING_PACKED on ccw for now (noticed by Jason); - Refine the memory barrier in virtqueue_poll(); - Add a missing memory barrier in virtqueue_enable_cb_delayed_pa...

...e state) in the return value of virtqueue_enable_cb_prepare_packed(); - Refine the packed ring definitions in uapi; - Rebase on the net-next tree; RFC v5 -> RFC v6: - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); - Define wrap counter as bool (Jason); - Use ALIGN() in vring_init_packed() (Jason); - Avoid using pointer to track `next` in detach_buf_packed() (Jason); - Add comments for barriers (Jason); - Don't enable RING_PACKED on ccw for now (noticed by Jason); - Refine the memory barrier in virtqueue_poll(); - Add a missing memory barrier in virtqueue_enable_cb_delayed_pa...

...;>>> - Rebase on the net-next tree; >>>>> >>>>> RFC v5 -> RFC v6: >>>>> - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); >>>>> - Define wrap counter as bool (Jason); >>>>> - Use ALIGN() in vring_init_packed() (Jason); >>>>> - Avoid using pointer to track `next` in detach_buf_packed() (Jason); >>>>> - Add comments for barriers (Jason); >>>>> - Don't enable RING_PACKED on ccw for now (noticed by Jason); >>>>> - Refine the memory barrier i...

...; > > - Refine the packed ring definitions in uapi; > > - Rebase on the net-next tree; > > > > RFC v5 -> RFC v6: > > - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); > > - Define wrap counter as bool (Jason); > > - Use ALIGN() in vring_init_packed() (Jason); > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > - Add comments for barriers (Jason); > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > - Refine the memory barrier in virtqueue_poll(); > > - Add a missin...

...gt; > > > > > > > > RFC v5 -> RFC v6: > > > > > > > - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); > > > > > > > - Define wrap counter as bool (Jason); > > > > > > > - Use ALIGN() in vring_init_packed() (Jason); > > > > > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > > > > > - Add comments for barriers (Jason); > > > > > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > &gt...