Displaying 9 results from an estimated 9 matches for "vring_desc_f_avail_shift".
2018 Nov 30
2
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
...ariant that uses shifts consistently.
> >
> > Maybe we could avoid adding SPLIT and PACKED, but define as follow:
> >
> > #define VRING_DESC_F_INDIRECT_SHIFT 2
> > #define VRING_DESC_F_INDIRECT (1ull << VRING_DESC_F_INDIRECT_SHIFT)
> >
> > #define VRING_DESC_F_AVAIL_SHIFT 7
> > #define VRING_DESC_F_AVAIL (1ull << VRING_DESC_F_AVAIL_SHIFT)
> >
> > I think it would be better for consistency.
>
> I don't think that will help. the problem is that
> most of the existing virtio code consistently uses _F_ as shifts.
> So we just ne...
2018 Nov 30
2
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
...ariant that uses shifts consistently.
> >
> > Maybe we could avoid adding SPLIT and PACKED, but define as follow:
> >
> > #define VRING_DESC_F_INDIRECT_SHIFT 2
> > #define VRING_DESC_F_INDIRECT (1ull << VRING_DESC_F_INDIRECT_SHIFT)
> >
> > #define VRING_DESC_F_AVAIL_SHIFT 7
> > #define VRING_DESC_F_AVAIL (1ull << VRING_DESC_F_AVAIL_SHIFT)
> >
> > I think it would be better for consistency.
>
> I don't think that will help. the problem is that
> most of the existing virtio code consistently uses _F_ as shifts.
> So we just ne...
2018 Nov 30
2
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
...gt; > Maybe we could avoid adding SPLIT and PACKED, but define as follow:
> > > >
> > > > #define VRING_DESC_F_INDIRECT_SHIFT 2
> > > > #define VRING_DESC_F_INDIRECT (1ull << VRING_DESC_F_INDIRECT_SHIFT)
> > > >
> > > > #define VRING_DESC_F_AVAIL_SHIFT 7
> > > > #define VRING_DESC_F_AVAIL (1ull << VRING_DESC_F_AVAIL_SHIFT)
> > > >
> > > > I think it would be better for consistency.
> > >
> > > I don't think that will help. the problem is that
> > > most of the existing vir...
2018 Nov 30
2
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
...gt; > Maybe we could avoid adding SPLIT and PACKED, but define as follow:
> > > >
> > > > #define VRING_DESC_F_INDIRECT_SHIFT 2
> > > > #define VRING_DESC_F_INDIRECT (1ull << VRING_DESC_F_INDIRECT_SHIFT)
> > > >
> > > > #define VRING_DESC_F_AVAIL_SHIFT 7
> > > > #define VRING_DESC_F_AVAIL (1ull << VRING_DESC_F_AVAIL_SHIFT)
> > > >
> > > > I think it would be better for consistency.
> > >
> > > I don't think that will help. the problem is that
> > > most of the existing vir...
2018 Nov 30
0
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
...> But let's add a _SPLIT_ variant that uses shifts consistently.
>
> Maybe we could avoid adding SPLIT and PACKED, but define as follow:
>
> #define VRING_DESC_F_INDIRECT_SHIFT 2
> #define VRING_DESC_F_INDIRECT (1ull << VRING_DESC_F_INDIRECT_SHIFT)
>
> #define VRING_DESC_F_AVAIL_SHIFT 7
> #define VRING_DESC_F_AVAIL (1ull << VRING_DESC_F_AVAIL_SHIFT)
>
> I think it would be better for consistency.
I don't think that will help. the problem is that
most of the existing virtio code consistently uses _F_ as shifts.
So we just need to do something about these 5 be...
2018 Nov 30
0
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
...y.
> > >
> > > Maybe we could avoid adding SPLIT and PACKED, but define as follow:
> > >
> > > #define VRING_DESC_F_INDIRECT_SHIFT 2
> > > #define VRING_DESC_F_INDIRECT (1ull << VRING_DESC_F_INDIRECT_SHIFT)
> > >
> > > #define VRING_DESC_F_AVAIL_SHIFT 7
> > > #define VRING_DESC_F_AVAIL (1ull << VRING_DESC_F_AVAIL_SHIFT)
> > >
> > > I think it would be better for consistency.
> >
> > I don't think that will help. the problem is that
> > most of the existing virtio code consistently uses _F_...
2018 Nov 30
4
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
On 2018/11/21 ??6:03, Tiwei Bie wrote:
> Add types and macros for packed ring.
>
> Signed-off-by: Tiwei Bie <tiwei.bie at intel.com>
> ---
> include/uapi/linux/virtio_config.h | 3 +++
> include/uapi/linux/virtio_ring.h | 52 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 55 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_config.h
2018 Nov 30
4
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
On 2018/11/21 ??6:03, Tiwei Bie wrote:
> Add types and macros for packed ring.
>
> Signed-off-by: Tiwei Bie <tiwei.bie at intel.com>
> ---
> include/uapi/linux/virtio_config.h | 3 +++
> include/uapi/linux/virtio_ring.h | 52 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 55 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_config.h
2018 Nov 30
0
[PATCH net-next v3 01/13] virtio: add packed ring types and macros
...void adding SPLIT and PACKED, but define as follow:
> > > > >
> > > > > #define VRING_DESC_F_INDIRECT_SHIFT 2
> > > > > #define VRING_DESC_F_INDIRECT (1ull << VRING_DESC_F_INDIRECT_SHIFT)
> > > > >
> > > > > #define VRING_DESC_F_AVAIL_SHIFT 7
> > > > > #define VRING_DESC_F_AVAIL (1ull << VRING_DESC_F_AVAIL_SHIFT)
> > > > >
> > > > > I think it would be better for consistency.
> > > >
> > > > I don't think that will help. the problem is that
> > >...