search for: vring_

...s are kept around to avoid breaking old userspace builds. It's not actually part of the UAPI - it was kept in the UAPI header by mistake, and using it in kernel isn't necessary and prevents us from making changes safely. In particular, the APIs actually assume the legacy layout. Add struct vring_s (identical ATM) and supporting legacy APIs and switch everyone to use that. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/misc/mic/vop/vop_main.c | 2 +- drivers/platform/mellanox/mlxbf-tmfifo.c | 10 ++++----- drivers/virtio/virtio_ring.c | 10 +++...

...s are kept around to avoid breaking old userspace builds. It's not actually part of the UAPI - it was kept in the UAPI header by mistake, and using it in kernel isn't necessary and prevents us from making changes safely. In particular, the APIs actually assume the legacy layout. Add struct vring_s (identical ATM) and supporting legacy APIs and switch everyone to use that. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/misc/mic/vop/vop_main.c | 2 +- drivers/platform/mellanox/mlxbf-tmfifo.c | 10 ++++----- drivers/virtio/virtio_ring.c | 10 +++...

...aking old userspace builds. > It's not actually part of the UAPI - it was kept in the UAPI > header by mistake, and using it in kernel isn't necessary > and prevents us from making changes safely. > In particular, the APIs actually assume the legacy layout. > > Add struct vring_s (identical ATM) and supporting > legacy APIs and switch everyone to use that. How are we going to know that "struct vring_s" is what we need/want to use? What does "_s" mean? "struct vring_kernel"? naming is hard... greg k-h

...deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index cc82918158d2..a67bda9792ec 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -74,9 +74,9 @@ struct vhost_virtqueue { /* The actual ring of buffers. */ struct mutex mutex; unsigned int num; - struct vring_desc __user *desc; - struct vring_avail __user *avail; - struct vring_used __user *used; + vring_desc_t __user *desc; + vring_avail_t __user *avail; + vring_used_t __user *used; const struct vhost_iotlb_map *meta_iotlb[VHOST_NUM_ADDRS]; struct vhost_desc *descs; diff --git a/include/linux/virt...

...st.c | 20 +++++++++--------- 4 files changed, 57 insertions(+), 23 deletions(-) diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h index 3dc70adfe5f5..b6a31b3cf87c 100644 --- a/include/linux/virtio_ring.h +++ b/include/linux/virtio_ring.h @@ -112,4 +112,32 @@ void vring_del_virtqueue(struct virtqueue *vq); void vring_transport_features(struct virtio_device *vdev); irqreturn_t vring_interrupt(int irq, void *_vq); + +struct vring { + unsigned int num; + + struct vring_desc *desc; + + struct vring_avail *avail; + + struct vring_used *used; +}; + +static inline voi...