search for: vq_used_wrap_count

Displaying 5 results from an estimated 5 matches for "vq_used_wrap_count".

Did you mean: vq_used_wrap_counter
2018 May 29
0
[RFC v5 3/5] virtio_ring: add packed ring support
...= !!(flags & VRING_DESC_F_USED(1)); > > + > > + return avail == used && used == vq->used_wrap_counter; > > Spec does not check avail == used? So there's probably a bug in either of > the two places. > > In what condition that avail != used but used == vq_used_wrap_counter? A > buggy device or device set the two bits in two writes? Currently, spec doesn't forbid devices to set the status bits as: avail != used but used == vq_used_wrap_counter. So I think driver cannot assume this won't happen. > > > } [...] > > static unsigned virtq...
2018 May 29
2
[RFC v5 3/5] virtio_ring: add packed ring support
...ING_DESC_F_AVAIL(1)); > + used = !!(flags & VRING_DESC_F_USED(1)); > + > + return avail == used && used == vq->used_wrap_counter; Spec does not check avail == used? So there's probably a bug in either of the two places. In what condition that avail != used but used == vq_used_wrap_counter? A buggy device or device set the two bits in two writes? > } > > static void *virtqueue_get_buf_ctx_packed(struct virtqueue *_vq, > unsigned int *len, > void **ctx) > { > - return NULL; > + struct vring_virtqueue *vq = to_vvq(_vq); > + u16...
2018 May 29
2
[RFC v5 3/5] virtio_ring: add packed ring support
...ING_DESC_F_AVAIL(1)); > + used = !!(flags & VRING_DESC_F_USED(1)); > + > + return avail == used && used == vq->used_wrap_counter; Spec does not check avail == used? So there's probably a bug in either of the two places. In what condition that avail != used but used == vq_used_wrap_counter? A buggy device or device set the two bits in two writes? > } > > static void *virtqueue_get_buf_ctx_packed(struct virtqueue *_vq, > unsigned int *len, > void **ctx) > { > - return NULL; > + struct vring_virtqueue *vq = to_vvq(_vq); > + u16...
2018 May 22
9
[RFC v5 0/5] virtio: support packed ring
Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring implementation in vhost (RFC v4): https://lkml.org/lkml/2018/5/16/501 Both of ping and netperf worked as expected w/ EVENT_IDX disabled. Ping worked as expected w/ EVENT_IDX enabled, but netperf didn't (A hack has been added in the driver to
2018 May 22
9
[RFC v5 0/5] virtio: support packed ring
Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring implementation in vhost (RFC v4): https://lkml.org/lkml/2018/5/16/501 Both of ping and netperf worked as expected w/ EVENT_IDX disabled. Ping worked as expected w/ EVENT_IDX enabled, but netperf didn't (A hack has been added in the driver to