search for: vq_index

We used to use a percpu structure vq_index to record the cpu to queue mapping, this is suboptimal since it duplicates the work of XPS and loses all other XPS functionality such as allowing use to configure their own transmission steering strategy. So this patch switches to use XPS and suggest a default mapping when the number of cpus is eq...

We used to use a percpu structure vq_index to record the cpu to queue mapping, this is suboptimal since it duplicates the work of XPS and loses all other XPS functionality such as allowing use to configure their own transmission steering strategy. So this patch switches to use XPS and suggest a default mapping when the number of cpus is eq...

We used to use a percpu structure vq_index to record the cpu to queue mapping, this is suboptimal since it duplicates the work of XPS and loses all other XPS functionality such as allowing use to configure their own transmission steering strategy. So this patch switches to use XPS and suggest a default mapping when the number of cpus is eq...

We used to use a percpu structure vq_index to record the cpu to queue mapping, this is suboptimal since it duplicates the work of XPS and loses all other XPS functionality such as allowing use to configure their own transmission steering strategy. So this patch switches to use XPS and suggest a default mapping when the number of cpus is eq...

...Eric Dumazet <erdnetdev at gmail.com> Cc: virtualization at lists.linux-foundation.org Cc: netdev at vger.kernel.org Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- V4->V5: Add get/put_online_cpus to avoid CPUs go up and down during operations (Rusty) V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) drivers/net/virtio_net.c | 60 +++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 49 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio...

...Eric Dumazet <erdnetdev at gmail.com> Cc: virtualization at lists.linux-foundation.org Cc: netdev at vger.kernel.org Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- V4->V5: Add get/put_online_cpus to avoid CPUs go up and down during operations (Rusty) V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) drivers/net/virtio_net.c | 60 +++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 49 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio...

...Tsirkin <mst at redhat.com> --- V6->V7: serialize virtnet_set_queues to avoid a race with cpu hotplug (Jason) V5->V6: remove {get|put}_online_cpus from virtnet_del_vqs (Jason) V4->V5: Add get/put_online_cpus to avoid CPUs go up and down during operations (Rusty) V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) drivers/net/virtio_net.c | 58 +++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 47 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio...

...Tsirkin <mst at redhat.com> --- V6->V7: serialize virtnet_set_queues to avoid a race with cpu hotplug (Jason) V5->V6: remove {get|put}_online_cpus from virtnet_del_vqs (Jason) V4->V5: Add get/put_online_cpus to avoid CPUs go up and down during operations (Rusty) V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) drivers/net/virtio_net.c | 58 +++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 47 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio...

...s.linux-foundation.org Cc: netdev at vger.kernel.org Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- V5->V6: remove {get|put}_online_cpus from virtnet_del_vqs (Jason) V4->V5: Add get/put_online_cpus to avoid CPUs go up and down during operations (Rusty) V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) drivers/net/virtio_net.c | 58 +++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 47 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio...

...s.linux-foundation.org Cc: netdev at vger.kernel.org Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- V5->V6: remove {get|put}_online_cpus from virtnet_del_vqs (Jason) V4->V5: Add get/put_online_cpus to avoid CPUs go up and down during operations (Rusty) V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) drivers/net/virtio_net.c | 58 +++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 47 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio...

We used to use a percpu structure vq_index to record the cpu to queue mapping, this is suboptimal since it duplicates the work of XPS and loses all other XPS functionality such as allowing user to configure their own transmission steering strategy. So this patch switches to use XPS and suggest a default mapping when the number of cpus is e...

We used to use a percpu structure vq_index to record the cpu to queue mapping, this is suboptimal since it duplicates the work of XPS and loses all other XPS functionality such as allowing user to configure their own transmission steering strategy. So this patch switches to use XPS and suggest a default mapping when the number of cpus is e...

.... Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: Eric Dumazet <erdnetdev at gmail.com> Cc: virtualization at lists.linux-foundation.org Cc: netdev at vger.kernel.org Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) Not Addressed yet: race between select_queue and set_channels need discuss more but not the same problem with this (Rusty) drivers/net/virtio_net.c | 53 +++++++...

.... Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: Eric Dumazet <erdnetdev at gmail.com> Cc: virtualization at lists.linux-foundation.org Cc: netdev at vger.kernel.org Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) Not Addressed yet: race between select_queue and set_channels need discuss more but not the same problem with this (Rusty) drivers/net/virtio_net.c | 53 +++++++...

On Mon, Sep 30, 2013 at 03:37:17PM +0800, Jason Wang wrote: > We used to use a percpu structure vq_index to record the cpu to queue > mapping, this is suboptimal since it duplicates the work of XPS and > loses all other XPS functionality such as allowing use to configure > their own transmission steering strategy. > > So this patch switches to use XPS and suggest a default mapping when...

On Fri, Sep 27, 2013 at 01:57:24PM +0800, Jason Wang wrote: > We used to use a percpu structure vq_index to record the cpu to queue > mapping, this is suboptimal since it duplicates the work of XPS and > loses all other XPS functionality such as allowing use to configure > their own transmission steering strategy. > > So this patch switches to use XPS and suggest a default mapping when...

...0 > Tested: verified by customer > > commit 9bb8ca86075f37d3c169b9c46f8e7c6d3165e18f > Author: Jason Wang <jasowang at redhat.com> > Date: Tue Nov 5 18:19:45 2013 +0800 > > virtio-net: switch to use XPS to choose txq > > We used to use a percpu structure vq_index to record the cpu to queue > mapping, this is suboptimal since it duplicates the work of XPS and > loses all other XPS functionality such as allowing user to configure > their own transmission steering strategy. > > So this patch switches to use XPS and suggest a...

...sure don't introduce bug. (Jason) V6->V7: serialize virtnet_set_queues to avoid a race with cpu hotplug (Jason) V5->V6: remove {get|put}_online_cpus from virtnet_del_vqs (Jason) V4->V5: Add get/put_online_cpus to avoid CPUs go up and down during operations (Rusty) V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) drivers/net/virtio_net.c | 67 ++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 54 insertions(+), 13 deletions(-) diff --git a/drivers/net/virtio...

...sure don't introduce bug. (Jason) V6->V7: serialize virtnet_set_queues to avoid a race with cpu hotplug (Jason) V5->V6: remove {get|put}_online_cpus from virtnet_del_vqs (Jason) V4->V5: Add get/put_online_cpus to avoid CPUs go up and down during operations (Rusty) V3->V4: move vq_index into virtnet_info (Jason) change the mapping value when not setting affinity (Jason) address the comments about select_queue (Rusty) drivers/net/virtio_net.c | 67 ++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 54 insertions(+), 13 deletions(-) diff --git a/drivers/net/virtio...

...net/virtio_net.c b/drivers/net/virtio_net.c index a6fcf15..a77f86c 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -41,6 +41,8 @@ module_param(gso, bool, 0444); #define VIRTNET_SEND_COMMAND_SG_MAX 2 #define VIRTNET_DRIVER_VERSION "1.0.0" +DEFINE_PER_CPU(int, vq_index) = -1; + struct virtnet_stats { struct u64_stats_sync tx_syncp; struct u64_stats_sync rx_syncp; @@ -1016,6 +1018,7 @@ static int virtnet_vlan_rx_kill_vid(struct net_device *dev, u16 vid) static void virtnet_set_affinity(struct virtnet_info *vi, bool set) { int i; + int cpu; /* In multi...