search for: vport0p0

Displaying 6 results from an estimated 6 matches for "vport0p0".

Did you mean: vport0p1
2015 May 08
0
[patch v2] virtio_console: silence a static checker warning
...ort->portdev->vdev->index, id); > > > would it help to use %03u (or so) to make it more obvious ? > > Note: i prefer a leading 0 in my programms to make it more easy > to work with grep and friends. you may thing otherwise. Well we've been exposing names like /dev/vport0p0, /dev/vport2p15, etc., and there might be scripts relying on such names, so that's one argument against it. However we do have pretty names that map to these ports via udev rules, but not sure if we should change the name just to prepend 0s. Amit
2015 May 08
1
[patch v2] virtio_console: silence a static checker warning
...dex, id); >> >> >> would it help to use %03u (or so) to make it more obvious ? >> >> Note: i prefer a leading 0 in my programms to make it more easy >> to work with grep and friends. you may thing otherwise. > > Well we've been exposing names like /dev/vport0p0, /dev/vport2p15, > etc., and there might be scripts relying on such names, so that's one > argument against it. > > However we do have pretty names that map to these ports via udev > rules, but not sure if we should change the name just to prepend 0s. > > Amit > The...
2015 May 08
1
[patch v2] virtio_console: silence a static checker warning
...dex, id); >> >> >> would it help to use %03u (or so) to make it more obvious ? >> >> Note: i prefer a leading 0 in my programms to make it more easy >> to work with grep and friends. you may thing otherwise. > > Well we've been exposing names like /dev/vport0p0, /dev/vport2p15, > etc., and there might be scripts relying on such names, so that's one > argument against it. > > However we do have pretty names that map to these ports via udev > rules, but not sure if we should change the name just to prepend 0s. > > Amit > The...
2015 May 08
1
[patch v2] virtio_console: silence a static checker warning
Am 08.05.2015 11:16, schrieb Dan Carpenter: > My static checker complains that this sprintf() can overflow but really > it can't. Just silence the warning by using snprintf(). > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > v2: the overflow is not possible so just leave the buffer size alone and > silence the warning with snprintf(). >
2015 May 08
4
[patch v2] virtio_console: silence a static checker warning
My static checker complains that this sprintf() can overflow but really it can't. Just silence the warning by using snprintf(). Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: the overflow is not possible so just leave the buffer size alone and silence the warning with snprintf(). diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index
2015 May 08
4
[patch v2] virtio_console: silence a static checker warning
My static checker complains that this sprintf() can overflow but really it can't. Just silence the warning by using snprintf(). Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: the overflow is not possible so just leave the buffer size alone and silence the warning with snprintf(). diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index