Displaying 3 results from an estimated 3 matches for "vpblockbase".
2020 Mar 10
2
RFC: Making a common successor/predecessor interface
...tty separate from this API change (even if the
> iterator types remain non-members - the succ_begin non-member -> member
> functions with a member type could be achieved by using a member typedef
> rather than a member /type/ )
>
I meant adding the global APIs for
MachineBasicBlock, VPBlockBase, clang::CFGBlock (3), vs adding member APIs
in BasicBlock and VPBlockBase (2).
This is only because the use case I am looking at involves the
DominatorTree and there are no instantiations around other types (like you
mentioned: Interval).
Looking closer at the comments for Interval, I see that the...
2020 Mar 10
4
RFC: Making a common successor/predecessor interface
...re they can't share
> a typedef).
>
> Would that suffice? are there other aspects of your use case that don't
> line up well with the existing non-member/overload API?
>
> - Dave
>
>
>> In particular, the need arose for BasicBlocks, MachineBasicBlocks,
>> VPBlockBase and clang::CFGBlock.
>>
>> The least invasive change seemed to be to use the interface already being
>> used in MachineBasicBlock and clang::CFGBlock, and:
>> (1) update BasicBlock to use this instead of the "global" `succ_iterator`
>> in IR/CFG.h
>> (2...
2020 Mar 09
3
RFC: Making a common successor/predecessor interface
...aphDiff (this models a CFG
view), I came across the need to have a common interface for accessing
successors/predecessors in various IR units, such that a type such as
`typename NodeT::succ_iterator` could be used in templated code.
In particular, the need arose for BasicBlocks, MachineBasicBlocks,
VPBlockBase and clang::CFGBlock.
The least invasive change seemed to be to use the interface already being
used in MachineBasicBlock and clang::CFGBlock, and:
(1) update BasicBlock to use this instead of the "global" `succ_iterator`
in IR/CFG.h
(2) add the same interfaces in VPBlockBase as simple wr...