search for: vp_vdpa_id_t

...able); > +} > + Looks like this needs to check and just skip the write if ready == 0, right? Of course vdpa core then insists on calling vp_vdpa_get_vq_ready which will warn. Maybe just drop the check from core, move it to drivers which need it? ... > +static const struct pci_device_id vp_vdpa_id_table[] = { > + { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, > + { 0 } > +}; This looks like it'll create a mess with either virtio pci or vdpa being loaded at random. Maybe just don't specify any IDs for now. Down the road we could get a distinct vendor ID or a range...

...able); > +} > + Looks like this needs to check and just skip the write if ready == 0, right? Of course vdpa core then insists on calling vp_vdpa_get_vq_ready which will warn. Maybe just drop the check from core, move it to drivers which need it? ... > +static const struct pci_device_id vp_vdpa_id_table[] = { > + { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, > + { 0 } > +}; This looks like it'll create a mess with either virtio pci or vdpa being loaded at random. Maybe just don't specify any IDs for now. Down the road we could get a distinct vendor ID or a range...

On 2020/6/7 ??9:51, Michael S. Tsirkin wrote: > On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: >> On 2020/6/2 ??3:08, Jason Wang wrote: >>>>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>>>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>>>> +??? { 0 } >>>>> +}; >>>> This looks like it'll create a mess with either virtio pci >>>> or vdpa being loaded at random. Maybe just don'...

On 2020/6/7 ??9:51, Michael S. Tsirkin wrote: > On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: >> On 2020/6/2 ??3:08, Jason Wang wrote: >>>>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>>>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>>>> +??? { 0 } >>>>> +}; >>>> This looks like it'll create a mess with either virtio pci >>>> or vdpa being loaded at random. Maybe just don'...

...Jun 08, 2020 at 11:32:31AM +0800, Jason Wang wrote: >> On 2020/6/7 ??9:51, Michael S. Tsirkin wrote: >>> On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: >>>> On 2020/6/2 ??3:08, Jason Wang wrote: >>>>>>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>>>>>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>>>>>> +??? { 0 } >>>>>>> +}; >>>>>> This looks like it'll create a mess with either virtio pci >>>>>> or vdpa be...

...Jun 08, 2020 at 11:32:31AM +0800, Jason Wang wrote: >> On 2020/6/7 ??9:51, Michael S. Tsirkin wrote: >>> On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: >>>> On 2020/6/2 ??3:08, Jason Wang wrote: >>>>>>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>>>>>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>>>>>> +??? { 0 } >>>>>>> +}; >>>>>> This looks like it'll create a mess with either virtio pci >>>>>> or vdpa be...

On 2020/6/2 ??3:08, Jason Wang wrote: >> >>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>> +??? { 0 } >>> +}; >> This looks like it'll create a mess with either virtio pci >> or vdpa being loaded at random. Maybe just don't specify >> any IDs for now. Dow...

On 2020/6/2 ??3:08, Jason Wang wrote: >> >>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>> +??? { 0 } >>> +}; >> This looks like it'll create a mess with either virtio pci >> or vdpa being loaded at random. Maybe just don't specify >> any IDs for now. Dow...

...alling > vp_vdpa_get_vq_ready which will warn. Maybe just drop the > check from core, move it to drivers which need it? > > ... That may work, but it may cause inconsistent semantic for set_vq_ready if we leave it to the driver. > > >> +static const struct pci_device_id vp_vdpa_id_table[] = { >> + { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >> + { 0 } >> +}; > This looks like it'll create a mess with either virtio pci > or vdpa being loaded at random. Maybe just don't specify > any IDs for now. Down the road we could get a >...

...n, Jun 08, 2020 at 11:32:31AM +0800, Jason Wang wrote: > > On 2020/6/7 ??9:51, Michael S. Tsirkin wrote: > > On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: > > > On 2020/6/2 ??3:08, Jason Wang wrote: > > > > > > +static const struct pci_device_id vp_vdpa_id_table[] = { > > > > > > +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, > > > > > > +??? { 0 } > > > > > > +}; > > > > > This looks like it'll create a mess with either virtio pci > > > > > or vdpa...

...0, Jason Wang wrote: > > > On 2020/6/7 ??9:51, Michael S. Tsirkin wrote: > > > > On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: > > > > > On 2020/6/2 ??3:08, Jason Wang wrote: > > > > > > > > +static const struct pci_device_id vp_vdpa_id_table[] = { > > > > > > > > +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, > > > > > > > > +??? { 0 } > > > > > > > > +}; > > > > > > > This looks like it'll create a mess with either vir...

...0, Jason Wang wrote: >>>> On 2020/6/7 ??9:51, Michael S. Tsirkin wrote: >>>>> On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: >>>>>> On 2020/6/2 ??3:08, Jason Wang wrote: >>>>>>>>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>>>>>>>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>>>>>>>> +??? { 0 } >>>>>>>>> +}; >>>>>>>> This looks like it'll create a mess with either virtio pci &gt...

...0, Jason Wang wrote: >>>> On 2020/6/7 ??9:51, Michael S. Tsirkin wrote: >>>>> On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: >>>>>> On 2020/6/2 ??3:08, Jason Wang wrote: >>>>>>>>> +static const struct pci_device_id vp_vdpa_id_table[] = { >>>>>>>>> +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, >>>>>>>>> +??? { 0 } >>>>>>>>> +}; >>>>>>>> This looks like it'll create a mess with either virtio pci &gt...

...fy_off_multiplier; + } + + return 0; + +err: + put_device(&vp_vdpa->vdpa.dev); + return ret; +} + +static void vp_vdpa_remove(struct pci_dev *pdev) +{ + struct vp_vdpa *vp_vdpa = pci_get_drvdata(pdev); + + vdpa_unregister_device(&vp_vdpa->vdpa); +} + +static const struct pci_device_id vp_vdpa_id_table[] = { + { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, + { 0 } +}; + +MODULE_DEVICE_TABLE(pci, vp_vdpa_id_table); + +static struct pci_driver vp_vdpa_driver = { + .name = "vp-vdpa", + .id_table = vp_vdpa_id_table, + .probe = vp_vdpa_probe, + .remove = vp_vdpa_remove, +}...

Hi all: This series introduce basic functionality of doorbell mapping support for vhost-vDPA. Userspace program may use mmap() to map a the doorbell of a specific virtqueue into its address space. This is help to reudce the syscall or vmexit overhead. A new vdpa_config_ops was introduced to report the location of the doorbell, vhost_vdpa may then choose to map the doorbell when: - The doorbell

Hi all: This series introduce basic functionality of doorbell mapping support for vhost-vDPA. Userspace program may use mmap() to map a the doorbell of a specific virtqueue into its address space. This is help to reudce the syscall or vmexit overhead. A new vdpa_config_ops was introduced to report the location of the doorbell, vhost_vdpa may then choose to map the doorbell when: - The doorbell

On Fri, Jun 05, 2020 at 04:54:17PM +0800, Jason Wang wrote: > > On 2020/6/2 ??3:08, Jason Wang wrote: > > > > > > > +static const struct pci_device_id vp_vdpa_id_table[] = { > > > > +??? { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) }, > > > > +??? { 0 } > > > > +}; > > > This looks like it'll create a mess with either virtio pci > > > or vdpa being loaded at random. Maybe just don't spec...