search for: vorbis_comment_add_tag

...lly found what crashes my code: Because I'm working with Codewarrior 8 on OS X I had to compile the ogg / vorbis libs with CW. To do so I used the CW projects for OS 9 and modified them. Howerver, they don't work as expected. Everything seems to be fine, encoding & decoding works, only vorbis_comment_add_tag() crashes my App on any subsequent call. I.e. I can call vorbis_comment_add_tag() several times for one stream/file and it works. When I deinit the encoder and init it again all calls to vorbis_comment_add_tag() will crash. I've tested the very same code on Win2000 and IRIX 6.5 and on both plat...

Dear Vorbis devs, I'm Robert Kausch, author of fre:ac - free audio converter. Please consider using _ogg_malloc/_ogg_free in place of alloca in vorbis_comment_add_tag. alloca will cause undefined behaviour/crashing when it causes a stack overflow which can easily happen when adding cover art in a METADATA_BLOCK_PICTURE comment. I had a user trying to convert a FLAC file with a 2 MB embedded cover art that caused a crash in vorbis_comment_add_tag. Thanks and...

Hi all, I tend to compile my code with all GCC warnings turned on. However, when I do this : vorbis_comment_add_tag(&vdata->vc,"ENCODER","libsndfile"); I get the following warning messages: warning: passing argument 2 of 'vorbis_comment_add_tag' discards qualifiers from pointer target type warning: passing argument 3 of 'vorbis_comment_add_tag' discar...

...ovComment=ov_comment(ovFile,-1); if(ovComment->user_comments) { printf("has comments - %i\n",ovComment->comments); for(int i=0;i<ovComment->comments;i++) { cout << ovComment->user_comments[i] << endl; } // vorbis_comment_add_tag(ovComment, "title", "Cheese Bar"); // ovComment->user_comments[0]="title=Cheese Bar"; } else { printf("doesn't have comments\n"); } // ov_clear(ovFile); fclose(fp); return(0); } === So, this reads things just...

..., before > verifying the CRC, which could be useful. Does it actually check the CRC, or is there some way for me to do so? I see the output from hogg dumpraw, but am not sure how to interpret it. In other news, the MediaMonkey developers believe this is a bug in a (possibly) older version of vorbis_comment_add_tag(): http://www.ventismedia.com/mantis/view.php?id=5809 Does this seem right and/or shed any light on how to undo the damage? Adam

...has an additional member - int *comment_lengths. Unless you're editing the struct directly (i.e. not using vorbis_comment_add(), etc.), no changes will be needed to applications (but this WILL break binary compatibility with shared libraries, I think.) Additionally, two extra calls were added: vorbis_comment_add_tag() and vorbis_comment_query(). These give a nicer interface to the 'tag' system. vorbis_comment_add_tag() is basically the same as vorbis_comment_add(), except it takes a tag and the contents. vorbis_comment_query() searches for the given tag, and returns the nth instance (one of the argume...

...nce number : 13 Checksum : 0xab096acc Total segments : 6 Total packets : 1 completed (1 cont) (255, 255, 255, 255, 255, 113) In short, this file's Ogg encapsulation is corrupt. There's no chance of this being a vorbis_comment_add_tag() bug as that would be corrupt data inside valid Ogg. The Ogg structure itself is invalid here. Monty

...VBR mode rather than the managed modes here. But when streaming, IMHO it is _very_ essential to be able to specify a maximum bitrate. I guess I can't use VBR mode then, can I? Another offtopic question: what vorbis comments are 'supported' or 'valid'? I see in the examples: vorbis_comment_add_tag(&vc,"ENCODER","encoder_example.c"); but what other meta-info? Like artist, etc? <p>Akos <p><p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to...

I've been working towards a mp3info like tool, OggInfo, which will surplant vorbiscomment in functionality, and also incorportate mp3info like featuers. Looking at existing vorbis api calls, i find: vorbis_comment_add() /* unsupervised string insertion */ vorbis_comment_add_tag() /* formated TAG=text insertion */ vorbis_comment_query() /* scans for matching tag (up to count duplicates) and returns the last one */ vorbis_comment_query_count() /* returns the number of matching TAG instances */ vorbis_comment_clear() /* obvious */ It seems to be allowing duplicate TAG ident...

...e CRC, which could be useful. > > Does it actually check the CRC, or is there some way for me to do so? I > see the output from hogg dumpraw, but am not sure how to interpret it. > > In other news, the MediaMonkey developers believe this is a bug in a > (possibly) older version of vorbis_comment_add_tag(): > > http://www.ventismedia.com/mantis/view.php?id=5809 > > Does this seem right and/or shed any light on how to undo the damage? One other potentially interesting observation -- Ogg::Vorbis::Header::PurePerl has no trouble reading the headers on these corrupted files (and outputti...

...cksum : 0xab096acc > Total segments : 6 > Total packets : 1 completed (1 cont) > (255, 255, 255, 255, 255, 113) > > In short, this file's Ogg encapsulation is corrupt. There's no chance > of this being a vorbis_comment_add_tag() bug as that would be corrupt > data inside valid Ogg. The Ogg structure itself is invalid here. Is there any way to understand exactly how it is invalid? I can replicate this corruption simply by adding large album art to any ogg file with the latest release of MediaMonkey. Adam

...ve these for later use. This is easy using ov_open(), ov_comment(), etc. 2) I encode the file using the external oggenc.exe. Also easy. 3) I then want to add the saved tag values to the fresh file. I thought that I could just open the Ogg file, get a handle to the comments structure, and then use vorbis_comment_add_tag() for each saved tag. But the I cannot figure out how to flush/save the new & improved file *without* getting my hands dirty with handling Ogg streams, etc. (yes, I'm lazy) Not that I want to advertise MP3 or ID3 , but with the free id3lib I can just do something like: m_pMP3Tag->Li...

...ines defined in vorbis/codec.h and info.c and I noticed that each "char *" could/should really be defined as "const char*". Is it expected that this will change or was it defined like this for reason? void vorbis_comment_add(vorbis_comment *vc, char *comment); void vorbis_comment_add_tag(vorbis_comment *vc, char *tag, char *contents); char *vorbis_comment_query(vorbis_comment *vc, char *tag, int count); int vorbis_comment_query_count(vorbis_comment *vc, char *tag); <p>Thanks. <p> -- Kristian G. Kvilekval email:kris@cs.u...

Adam Rosi-Kessel wrote, on 6/19/2009 3:56 PM: > Conrad Parker wrote, on 6/18/2009 3:15 PM: >> Hopefully at some point the vorbis data in the file becomes valid. >> Perhaps we just need to know the original encoding settings to create >> a new file with valid codebooks and splice them together: oggz-dump -r >> should be ok for that, just take the first 3 packets of the

Hi, It's a bit offtopic for this list, but you might be able to help. For libvorbis rc3, what is the correct bitrate parametrization for the call vorbis_encode_init()? For rc2, it worked calling it the following way: vorbis_encode_init( &vorbisInfo, 2, // two channels 44100, // 44.1kHz

...o.vi,info.channels,info.sample_rate,-1,info.vorbis_bitrate,-1); + ret=vorbis_encode_init(&info->vi,info->channels,info->sample_rate,-1,info->vorbis_bitrate,-1); if (ret){ fprintf (stderr, @@ -74,11 +72,11 @@ exit (1); } - vorbis_comment_init (&info.vc); - vorbis_comment_add_tag (&info.vc, "ENCODER",PACKAGE_STRING); + vorbis_comment_init (&info->vc); + vorbis_comment_add_tag (&info->vc, "ENCODER",PACKAGE_STRING); /* set up the analysis state and auxiliary encoding storage */ - vorbis_analysis_init (&info.vd, &info.vi); -...

Hi Developers, I have a 16-bit PCM data buffer, I want to write that to ogg file. Could you help me to understand how to write pcm data to the ogg? Thanks in advance. Arun balaji -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/vorbis-dev/attachments/20150518/6c8c9a63/attachment.htm

...e encoder save Ogg packets as an Audio object in an .mp4 file. As a side effect, it can also save Ogg pages in an .ogg file playable by xmms, but that's no big deal. So what I'm doing is this. First the init part. a) vorbis_info_init b) vorbis_encode_init c) vorbis_comment_init d) vorbis_comment_add_tag e) ogg_stream_init f) vorbis_analysis_headerout g) ogg_stream_packetin for the header, the header_comment and the header_code Then the encode part a) sample pcm and hand it to encode code b) get buffer space with vorbis_analysis_buffer c) convert 16 bit signed pcm to float and place...

...233,7 @@ value++; /* convert the value from the native charset to UTF-8 */ - if (utf8_encode(value, &utf8_value, encoding) == 0) { + if (convert_to_utf8(value, &utf8_value) >= 0) { /* append the comment and return */ vorbis_comment_add_tag(vc, line, utf8_value); @@ -307,9 +306,6 @@ param->comments=NULL; param->tempoutfile=0; - /* character encoding */ - param->encoding = "ISO-8859-1"; - return param; } @@ -327,7 +323,9 @@ int ret; int option_index = 1; - while ((r...