search for: vorbis_comment_add

Hi all, I tend to compile my code with all GCC warnings turned on. However, when I do this : vorbis_comment_add_tag(&vdata->vc,"ENCODER","libsndfile"); I get the following warning messages: warning: passing argument 2 of 'vorbis_comment_add_tag' discards qualifiers from pointer target type warning: passing argument 3 of 'vorbis_comment_add_tag' di...

...h of work on the comment interfaces in libvorbis. Importantly, there is now a way to deal with non-0-terminated strings being returned in the comment structure. THe vorbis_comment struct has an additional member - int *comment_lengths. Unless you're editing the struct directly (i.e. not using vorbis_comment_add(), etc.), no changes will be needed to applications (but this WILL break binary compatibility with shared libraries, I think.) Additionally, two extra calls were added: vorbis_comment_add_tag() and vorbis_comment_query(). These give a nicer interface to the 'tag' system. vorbis_comment_ad...

I've been working towards a mp3info like tool, OggInfo, which will surplant vorbiscomment in functionality, and also incorportate mp3info like featuers. Looking at existing vorbis api calls, i find: vorbis_comment_add() /* unsupervised string insertion */ vorbis_comment_add_tag() /* formated TAG=text insertion */ vorbis_comment_query() /* scans for matching tag (up to count duplicates) and returns the last one */ vorbis_comment_query_count() /* returns the number of matching TAG instances */ vorbis_comment_clear...

I was looking over the comment manipulations routines defined in vorbis/codec.h and info.c and I noticed that each "char *" could/should really be defined as "const char*". Is it expected that this will change or was it defined like this for reason? void vorbis_comment_add(vorbis_comment *vc, char *comment); void vorbis_comment_add_tag(vorbis_comment *vc, char *tag, char *contents); char *vorbis_comment_query(vorbis_comment *vc, char *tag, int count); int vorbis_comment_query_count(vorbis_comment *vc, char *tag);...

...init vorbis_info -- vorbis_info_init() 4 start encoding with info and params -- vorbis_encode_init() 5 init vorbis_dsp_state from info -- vorbis_analysis_init() 6 init vorbis_block from dsp -- vorbis_block_init() 7 init ogg_stream_state with serial -- ogg_stream_init() 8 fill vorbis_comment -- vorbis_comment_add() 9 create header packets from dsp -- vorbis_analysis_headerout() 10 dump header packets to stream -- ogg_stream_packetin() 11 while pages need to be flushed from stream: -- ogg_stream_flush() 12 flush stream to page -- above 13 write page to file -- fwrite() 14 if nothing written: 15 fa...

...lly found what crashes my code: Because I'm working with Codewarrior 8 on OS X I had to compile the ogg / vorbis libs with CW. To do so I used the CW projects for OS 9 and modified them. Howerver, they don't work as expected. Everything seems to be fine, encoding & decoding works, only vorbis_comment_add_tag() crashes my App on any subsequent call. I.e. I can call vorbis_comment_add_tag() several times for one stream/file and it works. When I deinit the encoder and init it again all calls to vorbis_comment_add_tag() will crash. I've tested the very same code on Win2000 and IRIX 6.5 and on both...

...return -1; @@ -58,6 +89,24 @@ return 0; } +static void metadata_update(void *self, vorbis_comment *vc) +{ + stdinpcm_state *s = self; + char **md; + + thread_mutex_lock(&s->metadatalock); + + md = s->metadata; + + if(md) + { + while(*md) + vorbis_comment_add(vc, *md++); + } + + thread_mutex_unlock(&s->metadatalock); +} + /* Core streaming function for this module * This is what actually produces the data which gets streamed. * @@ -101,17 +150,21 @@ input_module_t *mod = calloc(1, sizeof(input_module_t)); stdinpcm_state *s;...

...ilers-which-doesn-t-ha.patch Type: text/x-patch Size: 7081 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/vorbis-dev/attachments/20180320/998341f5/attachment-0022.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0010-remove-non-existing-vorbis_comment_add-and-vorbis_co.patch Type: text/x-patch Size: 1479 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/vorbis-dev/attachments/20180320/998341f5/attachment-0023.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0011-os.h-remove-irrelevant-compa...

...-646,7 +643,7 @@ static void add_tag(vorbis_comment *vc, oe_options *opt,char *name, char *value) { char *utf8; - if(utf8_encode(value, &utf8, opt->encoding) == 0) + if(convert_to_utf8(value, &utf8) >= 0) { if(name == NULL) vorbis_comment_add(vc, utf8); @@ -655,7 +652,7 @@ free(utf8); } else - fprintf(stderr, "Couldn't convert comment to UTF8, cannot add\n"); + fprintf(stderr, "Couldn't convert comment to UTF-8, cannot add\n"); } static void build_comments(vorbis_comme...