search for: vnsprintf

I think I stumbled upon a bug in the i_snprintf() function. In the case of vnsprintf() being available, it depends on vnsprintf() returning -1 when the string was longer than the passed-in limit (or it won't terminate the string.). But this isn't the C99-standardized behaviour, and newer glibc's don't do that anymore either, so you can end up with a non-terminated s...

Janne Hyv?rinen wrote: > Some comments for patch #1, I chose the non-secure versions because they > are faster and produce smaller binary. The functions where these > printings are performed can't in my opinion ever exceed the safety > margin of 32 KB. They print short help and error texts and occasionally > filename, which with APIs is restricted to 260 characters. And you

...available on MinGW platform: > MinGW declares this function only if MINGW_HAS_SECURE_API macro is defined. > That's because WinXP version of msvcrt.dll doesn't contain secure functions > like vsnprintf_s. > > Maybe it's better to revert vsnprintf_s to vsprintf or to use vnsprintf? Ok, we need to drop vsnprintf_s to support WinXP. I'd prefer vsnprintf over vsprintf but have no way of testing any of these options. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

...printf_s isn't always available on MinGW platform: MinGW declares this function only if MINGW_HAS_SECURE_API macro is defined. That's because WinXP version of msvcrt.dll doesn't contain secure functions like vsnprintf_s. Maybe it's better to revert vsnprintf_s to vsprintf or to use vnsprintf? (Of course it's also possible to write something like #if defined _MSC_VER || defined MINGW_HAS_SECURE_API ret = vsnprintf_s(buf, bufsize, _TRUNCATE, format, arglist); #else ret = vsnprintf(buf, bufsize, format, arglist); if (ret < 0) buf[bufsize-1] = '\0'; #endif but...

...platform: >> MinGW declares this function only if MINGW_HAS_SECURE_API macro is defined. >> That's because WinXP version of msvcrt.dll doesn't contain secure functions >> like vsnprintf_s. >> >> Maybe it's better to revert vsnprintf_s to vsprintf or to use vnsprintf? > > Ok, we need to drop vsnprintf_s to support WinXP. I'd prefer vsnprintf > over vsprintf but have no way of testing any of these options. I wrote a small program that fills a buffer[] with "abcdefghijklmnopqrstuvwxyz\0" pattern and then tries to write "0123456789&qu...

...tection of /dev/ptmx on Linux systems that lack openpty. Report from John Seifarth <john at waw.be> - Look for intXX_t and u_intXX_t in sys/bitypes.h if they are not in sys/types.h. Fixes problems on SCO, report from Gary E. Miller <gem at rellim.com> - Use __snprintf and __vnsprintf if they are found where snprintf and vnsprintf are lacking. Suggested by Ben Taylor <bent at shell.clark.net> and others. 20000114 - Merged OpenBSD IPv6 patch: - [sshd.c sshd.8 sshconnect.c ssh.h ssh.c servconf.h servconf.c scp.1] [scp.c packet.h packet.c login.c log.c canohos...

...tection of /dev/ptmx on Linux systems that lack openpty. Report from John Seifarth <john at waw.be> - Look for intXX_t and u_intXX_t in sys/bitypes.h if they are not in sys/types.h. Fixes problems on SCO, report from Gary E. Miller <gem at rellim.com> - Use __snprintf and __vnsprintf if they are found where snprintf and vnsprintf are lacking. Suggested by Ben Taylor <bent at shell.clark.net> and others. 20000114 - Merged OpenBSD IPv6 patch: - [sshd.c sshd.8 sshconnect.c ssh.h ssh.c servconf.h servconf.c scp.1] [scp.c packet.h packet.c login.c log.c canohos...