search for: vmtask

I've rebased the patch series to the current next branch and am sending them again.

This resend includes the rebase, but fixes a problem I just noticed with nil/empty checks.

This is a resend of the 2-patch series from a week or so ago, needed to be rebased due to some commits on next

The following two patches should be applied in the order: * [PATCH server] Add svc_vm_actions method to VmService. * [PATCH server] Cloud UI layer to initiate actions on vms. The service layer patch should work fine on its own (and not break anything), but cloud patch relies on service being there.

...models/vm.rb @@ -280,6 +280,13 @@ class Vm < ActiveRecord::Base actions end + # Provide method to check if requested action exists, so caller can decide + # if they want to throw an error of some sort before continuing + # (ie in service api) + def valid_action?(action) + return VmTask::ACTIONS.include?(action) ? true : false + end + # these resource checks are made at VM start/restore time # use pending here by default since this is used for queueing VM # creation/start operations diff --git a/src/app/models/vm_task.rb b/src/app/models/vm_task.rb index 762438f..649001d...

...popup' + end + def migrate svc_get_for_migrate(params[:id]) render :layout => 'popup' diff --git a/src/app/models/vm_task.rb b/src/app/models/vm_task.rb index 649001d..b8da529 100644 --- a/src/app/models/vm_task.rb +++ b/src/app/models/vm_task.rb @@ -56,7 +56,9 @@ class VmTask < Task :success => Vm::STATE_RUNNING, :failure => Vm::STATE_STOPPED, :privilege => [Privilege::VM_CONTROL, - PRIV_OBJE...

....paged_with_perms(@user, + Privilege::VIEW, + # NOTE: maybe this ^^ part could be taken care of behind the scenes? + # Also, needs to be changed to a cloud priv + page, order) + @actions = VmTask.get_vm_actions + show + end + + def show + ids = params[:ids] + task_page = find_in_params_or_default(:task_page, 1) + task_order = find_in_params_or_default(:task_order, "tasks.id") + @vm_details = Vm.find(ids) if ids + if @vm_details + @tasks = VmTask.paginate(:...

...e.rb b/src/app/services/vm_resource_pool_service.rb index 00cf982..8930a4b 100644 --- a/src/app/services/vm_resource_pool_service.rb +++ b/src/app/services/vm_resource_pool_service.rb @@ -73,7 +73,6 @@ module VmResourcePoolService # permission is action-specific as determined by # <tt>VmTask.action_privilege(@action)</tt> def svc_vm_actions(pool_id, vm_action, vm_ids) - # from before_filter @pool = VmResourcePool.find(pool_id) @parent = @pool.parent @action = vm_action diff --git a/src/app/services/vm_service.rb b/src/app/services/vm_service.rb index fb58b51....

redux patchset permitting a vm to be associated with multiple networks and vice-versa. updated patchset so as to be applicable against current oVirt server HEAD these patches may be applied in any order, they all need to be pushed together

This patchset contains changes to the ovirt server frontend, backend, and tests components, permitting vms to be associated with multiple networks and vice versa. Also included are two patches which are required for the frontend bits; a patch adding collapsable sections to the vm form, which in itself depends on the second patch that provides default values for the cpu and memory vm table fields

...!(Privilege::MODIFY, at vm.vm_resource_pool) @@ -103,6 +103,10 @@ module VmService alert = "VM was successfully created." Vm.transaction do @vm.save! + nics.each{ |nic| + nic[:vm_id] = @vm.id + Nic.create(nic) + } vm_provision @task = VmTask.new({ :user => @user, :task_target => @vm, @@ -129,7 +133,7 @@ module VmService # [<tt>@vm</tt>] stores the Vm with +id+ # === Required permissions # [<tt>Privilege::MODIFY</tt>] for the Vm's VmResourcePool - def svc_upd...