search for: vm_hugepag

...*inode = file_inode(filp); if (vma->vm_flags & VM_SYNC) { if (!IS_DAX(inode)) return -EOPNOTSUPP; if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) return -EOPNOTSUPP; } file_accessed(filp); vma->vm_ops = &xfs_file_vm_ops; if (IS_DAX(inode)) vma->vm_flags |= VM_HUGEPAGE; return 0; } Even better, factor out all the "MAP_SYNC supported" checks into a helper so that the filesystem code just doesn't have to care about the details of checking for DAX+MAP_SYNC support.... Cheers, Dave. -- Dave Chinner david at fromorbit.com

...*inode = file_inode(filp); if (vma->vm_flags & VM_SYNC) { if (!IS_DAX(inode)) return -EOPNOTSUPP; if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) return -EOPNOTSUPP; } file_accessed(filp); vma->vm_ops = &xfs_file_vm_ops; if (IS_DAX(inode)) vma->vm_flags |= VM_HUGEPAGE; return 0; } Even better, factor out all the "MAP_SYNC supported" checks into a helper so that the filesystem code just doesn't have to care about the details of checking for DAX+MAP_SYNC support.... Cheers, Dave. -- Dave Chinner david at fromorbit.com

...gt; > return -EOPNOTSUPP; > > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > return -EOPNOTSUPP; > > } > > > > file_accessed(filp); > > vma->vm_ops = &xfs_file_vm_ops; > > if (IS_DAX(inode)) > > vma->vm_flags |= VM_HUGEPAGE; > > return 0; > > } > > Sure, this is better. > > Even better, factor out all the "MAP_SYNC supported" checks into a > > helper so that the filesystem code just doesn't have to care about > > the details of checking for DAX+MAP_SYNC support.......

...gt; > return -EOPNOTSUPP; > > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > return -EOPNOTSUPP; > > } > > > > file_accessed(filp); > > vma->vm_ops = &xfs_file_vm_ops; > > if (IS_DAX(inode)) > > vma->vm_flags |= VM_HUGEPAGE; > > return 0; > > } > > Sure, this is better. > > Even better, factor out all the "MAP_SYNC supported" checks into a > > helper so that the filesystem code just doesn't have to care about > > the details of checking for DAX+MAP_SYNC support.......

...& VM_SYNC) { > if (!IS_DAX(inode)) > return -EOPNOTSUPP; > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > return -EOPNOTSUPP; > } > > file_accessed(filp); > vma->vm_ops = &xfs_file_vm_ops; > if (IS_DAX(inode)) > vma->vm_flags |= VM_HUGEPAGE; > return 0; > } > > > Even better, factor out all the "MAP_SYNC supported" checks into a > helper so that the filesystem code just doesn't have to care about > the details of checking for DAX+MAP_SYNC support.... Seconded, since ext4 has nearly the same flag...

...; > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > > return -EOPNOTSUPP; > > > } > > > > > > file_accessed(filp); > > > vma->vm_ops = &xfs_file_vm_ops; > > > if (IS_DAX(inode)) > > > vma->vm_flags |= VM_HUGEPAGE; > > > return 0; > > > } > > > > > > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > helper so that the filesystem code just doesn't have to care about > > > the details of checking for D...

...; > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > > return -EOPNOTSUPP; > > > } > > > > > > file_accessed(filp); > > > vma->vm_ops = &xfs_file_vm_ops; > > > if (IS_DAX(inode)) > > > vma->vm_flags |= VM_HUGEPAGE; > > > return 0; > > > } > > > > > > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > helper so that the filesystem code just doesn't have to care about > > > the details of checking for D...

...gt; > > > return -EOPNOTSUPP; > > > > > } > > > > > > > > > > file_accessed(filp); > > > > > vma->vm_ops = &xfs_file_vm_ops; > > > > > if (IS_DAX(inode)) > > > > > vma->vm_flags |= VM_HUGEPAGE; > > > > > return 0; > > > > > } > > > > > > > > > > > > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > > > helper so that the filesystem code just doesn't hav...

...gt; > > > return -EOPNOTSUPP; > > > > > } > > > > > > > > > > file_accessed(filp); > > > > > vma->vm_ops = &xfs_file_vm_ops; > > > > > if (IS_DAX(inode)) > > > > > vma->vm_flags |= VM_HUGEPAGE; > > > > > return 0; > > > > > } > > > > > > > > > > > > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > > > helper so that the filesystem code just doesn't hav...

On Fri, Nov 06, 2020 at 01:26:50PM -0800, Ralph Campbell wrote: > > On 11/6/20 12:03 AM, Christoph Hellwig wrote: >> I hate the extra pin count magic here. IMHO we really need to finish >> off the series to get rid of the extra references on the ZONE_DEVICE >> pages first. > > First, thanks for the review comments. > > I don't like the extra refcount

...gt; > return -EOPNOTSUPP; > > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > return -EOPNOTSUPP; > > } > > > > file_accessed(filp); > > vma->vm_ops = &xfs_file_vm_ops; > > if (IS_DAX(inode)) > > vma->vm_flags |= VM_HUGEPAGE; > > return 0; > > } > > > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > helper so that the filesystem code just doesn't have to care about > > the details of checking for DAX+MAP_SYNC support.... > >...

...; > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > > return -EOPNOTSUPP; > > > } > > > > > > file_accessed(filp); > > > vma->vm_ops = &xfs_file_vm_ops; > > > if (IS_DAX(inode)) > > > vma->vm_flags |= VM_HUGEPAGE; > > > return 0; > > > } > > > > Sure, this is better. > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > helper so that the filesystem code just doesn't have to care about > > > the details...

...& VM_SYNC) { > if (!IS_DAX(inode)) > return -EOPNOTSUPP; > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > return -EOPNOTSUPP; > } > > file_accessed(filp); > vma->vm_ops = &xfs_file_vm_ops; > if (IS_DAX(inode)) > vma->vm_flags |= VM_HUGEPAGE; > return 0; > } Sure, this is better. > > > Even better, factor out all the "MAP_SYNC supported" checks into a > helper so that the filesystem code just doesn't have to care about > the details of checking for DAX+MAP_SYNC support.... o.k. Will add one com...

...ind_daxdev_for_inode(inode)) > > > > return -EOPNOTSUPP; > > > > } > > > > > > > > file_accessed(filp); > > > > vma->vm_ops = &xfs_file_vm_ops; > > > > if (IS_DAX(inode)) > > > > vma->vm_flags |= VM_HUGEPAGE; > > > > return 0; > > > > } > > > > > > > > > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > > helper so that the filesystem code just doesn't have to care about > > >...

...EOPNOTSUPP; > > > > > > } > > > > > > > > > > > > file_accessed(filp); > > > > > > vma->vm_ops = &xfs_file_vm_ops; > > > > > > if (IS_DAX(inode)) > > > > > > vma->vm_flags |= VM_HUGEPAGE; > > > > > > return 0; > > > > > > } > > > > > > > > > > > > > > > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > > > > helper so that the filesy...

...crement the MEMORY_DEVICE_PCI_P2PDMA struct page reference count. Or maybe just leave it at one like it is now. MEMORY_DEVICE_GENERIC: Struct pages are created in dev_dax_probe() and represent non-volatile memory. The device can be mmap()'ed which calls dax_mmap() which sets vma->vm_flags | VM_HUGEPAGE. A CPU page fault will result in a PTE, PMD, or PUD sized page (but not compound) to be inserted by vmf_insert_mixed() which will call either insert_pfn() or insert_page(). Neither insert_pfn() nor insert_page() increments the page reference count. Invalidations don't callback into the device...

This patch series has implementation for "virtio pmem". "virtio pmem" is fake persistent memory(nvdimm) in guest which allows to bypass the guest page cache. This also implements a VIRTIO based asynchronous flush mechanism. Sharing guest kernel driver in this patchset with the changes suggested in v3. Tested with Qemu side device emulation [6] for virtio-pmem.