Displaying 20 results from an estimated 51 matches for "vm_find_vq".
Did you mean:
vm_find_vqs
2020 Apr 09
0
[PATCH] virtio-mmio: Delete an error message in vm_find_vqs()
...> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 97d5725fd9a2..9d16aaffca9d 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -466,10 +466,8 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> int irq = platform_get_irq(vm_dev->pdev, 0);
> int i, err, queue_idx = 0;
>
> - if (irq < 0) {
> - dev_err(&vdev->dev, "Cannot get IRQ resource\n");
> + if (irq < 0)
> return irq;
> - }
>
&...
2019 Jul 02
2
[PATCH] virtio-mmio: add error check for platform_get_irq
in vm_find_vqs() irq has a wrong type
so, in case of no IRQ resource defined,
wrong parameter will be passed to request_irq()
Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net>
---
drivers/virtio/virtio_mmio.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/v...
2019 Jul 02
2
[PATCH] virtio-mmio: add error check for platform_get_irq
in vm_find_vqs() irq has a wrong type
so, in case of no IRQ resource defined,
wrong parameter will be passed to request_irq()
Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net>
---
drivers/virtio/virtio_mmio.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/v...
2019 Jul 02
2
[PATCH v2] virtio-mmio: add error check for platform_get_irq
in vm_find_vqs() irq has a wrong type
so, in case of no IRQ resource defined,
wrong parameter will be passed to request_irq()
Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net>
---
Changes in v2:
Don't overwrite error code value.
drivers/virtio/virtio_mmio.c | 7 ++++++-
1 file changed,...
2019 Jul 02
2
[PATCH v2] virtio-mmio: add error check for platform_get_irq
in vm_find_vqs() irq has a wrong type
so, in case of no IRQ resource defined,
wrong parameter will be passed to request_irq()
Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net>
---
Changes in v2:
Don't overwrite error code value.
drivers/virtio/virtio_mmio.c | 7 ++++++-
1 file changed,...
2020 Apr 09
0
virtio-mmio: Delete an error message in vm_find_vqs()
On 2020/4/9 ??2:02, Markus Elfring wrote:
>>> The function ?platform_get_irq? can log an error already.
>>> Thus omit a redundant message for the exception handling in the
>>> calling function.
>> It looks to me that not all error path of platform_get_irq() were loggd.
> How do you think about to clarify the handling of the error code ?-EPROBE_DEFER? any more?
2014 Oct 25
1
[RFC PATCH 2/2] Assign a new irq handler while irqfd enabled
...e)
+ ret |= vring_interrupt(irq, info->vq);
+ spin_unlock_irqrestore(&vm_dev->lock, flags);
+
+ return ret;
+}
static void vm_del_vq(struct virtqueue *vq)
{
@@ -391,6 +415,7 @@ error_available:
return ERR_PTR(err);
}
+#define VIRTIO_MMIO_F_IRQFD (1 << 7)
static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
struct virtqueue *vqs[],
vq_callback_t *callbacks[],
@@ -400,8 +425,13 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
unsigned int irq = platform_get_irq(vm_dev->pdev, 0);
int i, err;
- err = request_irq(...
2014 Oct 25
1
[RFC PATCH 2/2] Assign a new irq handler while irqfd enabled
...e)
+ ret |= vring_interrupt(irq, info->vq);
+ spin_unlock_irqrestore(&vm_dev->lock, flags);
+
+ return ret;
+}
static void vm_del_vq(struct virtqueue *vq)
{
@@ -391,6 +415,7 @@ error_available:
return ERR_PTR(err);
}
+#define VIRTIO_MMIO_F_IRQFD (1 << 7)
static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
struct virtqueue *vqs[],
vq_callback_t *callbacks[],
@@ -400,8 +425,13 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
unsigned int irq = platform_get_irq(vm_dev->pdev, 0);
int i, err;
- err = request_irq(...
2014 Oct 27
1
[RFC PATCH 2/2] Assign a new irq handler while irqfd enabled
...> So you invoke callbacks for all VQs.
> This won't scale well as the number of VQs grows, will it?
>
>> @@ -391,6 +415,7 @@ error_available:
>> return ERR_PTR(err);
>> }
>>
>> +#define VIRTIO_MMIO_F_IRQFD (1 << 7)
>> static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>> struct virtqueue *vqs[],
>> vq_callback_t *callbacks[],
>> @@ -400,8 +425,13 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>> unsigned int irq = platform_get_irq(vm_dev->pdev, 0);...
2014 Oct 27
1
[RFC PATCH 2/2] Assign a new irq handler while irqfd enabled
...> So you invoke callbacks for all VQs.
> This won't scale well as the number of VQs grows, will it?
>
>> @@ -391,6 +415,7 @@ error_available:
>> return ERR_PTR(err);
>> }
>>
>> +#define VIRTIO_MMIO_F_IRQFD (1 << 7)
>> static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>> struct virtqueue *vqs[],
>> vq_callback_t *callbacks[],
>> @@ -400,8 +425,13 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>> unsigned int irq = platform_get_irq(vm_dev->pdev, 0);...
2023 Oct 10
1
[PATCH 2/2] virtio-mmio: Support multiple interrupts per device
...IO_ID_NET:
> + /* interrupt shared by rx/tx virtqueue pair */
> + return vq->index / 2;
> + default:
> + return 0;
> + }
Transport drivers should have no knowledge of a specific type of device.
> +}
> +
> static int vm_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> struct virtqueue *vqs[],
> vq_callback_t *callbacks[],
> @@ -496,19 +531,9 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> struct irq_affinit...
2023 Oct 10
1
[PATCH 2/2] virtio-mmio: Support multiple interrupts per device
...IO_ID_NET:
> + /* interrupt shared by rx/tx virtqueue pair */
> + return vq->index / 2;
> + default:
> + return 0;
> + }
Transport drivers should have no knowledge of a specific type of device.
> +}
> +
> static int vm_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> struct virtqueue *vqs[],
> vq_callback_t *callbacks[],
> @@ -496,19 +531,9 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> struct irq_affinit...
2019 Jul 02
0
[PATCH v2] virtio-mmio: add error check for platform_get_irq
On Tue, Jul 02, 2019 at 05:48:18PM +0300, Ihor Matushchak wrote:
> in vm_find_vqs() irq has a wrong type
> so, in case of no IRQ resource defined,
> wrong parameter will be passed to request_irq()
>
> Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net>
Thanks!
pls don't make v2 a response to v1 in the future though.
> ---
> Changes in v...
2019 Jul 02
0
[PATCH] virtio-mmio: add error check for platform_get_irq
Hi,
Quoting Ihor Matushchak (2019-07-02 12:59:18)
> in vm_find_vqs() irq has a wrong type
> so, in case of no IRQ resource defined,
> wrong parameter will be passed to request_irq()
>
> Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net>
> ---
> drivers/virtio/virtio_mmio.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1...
2019 Jul 26
0
[PATCH AUTOSEL 5.2 36/85] virtio-mmio: add error check for platform_get_irq
From: Ihor Matushchak <ihor.matushchak at foobox.net>
[ Upstream commit 5e663f0410fa2f355042209154029842ba1abd43 ]
in vm_find_vqs() irq has a wrong type
so, in case of no IRQ resource defined,
wrong parameter will be passed to request_irq()
Signed-off-by: Ihor Matushchak <ihor.matushchak at foobox.net>
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
Reviewed-by: Ivan T. Ivanov <iivanov.xz at gmail.com&g...
2014 Oct 26
0
[RFC PATCH 2/2] Assign a new irq handler while irqfd enabled
...vm_del_vq(struct virtqueue *vq)
> {
So you invoke callbacks for all VQs.
This won't scale well as the number of VQs grows, will it?
> @@ -391,6 +415,7 @@ error_available:
> return ERR_PTR(err);
> }
>
> +#define VIRTIO_MMIO_F_IRQFD (1 << 7)
> static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> struct virtqueue *vqs[],
> vq_callback_t *callbacks[],
> @@ -400,8 +425,13 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> unsigned int irq = platform_get_irq(vm_dev->pdev, 0);
> int i, er...
2014 Oct 27
0
[RFC PATCH 2/2] Assign a new irq handler while irqfd enabled
...Qs.
> > This won't scale well as the number of VQs grows, will it?
> >
> >> @@ -391,6 +415,7 @@ error_available:
> >> return ERR_PTR(err);
> >> }
> >>
> >> +#define VIRTIO_MMIO_F_IRQFD (1 << 7)
> >> static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> >> struct virtqueue *vqs[],
> >> vq_callback_t *callbacks[],
> >> @@ -400,8 +425,13 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> >> unsigned int irq = platform_get_irq(v...
2018 Dec 28
0
[PATCH v1 2/2] virtio: don't allocate vqs when names[i] = NULL
...false,
+ ccw);
if (IS_ERR(vqs[i])) {
ret = PTR_ERR(vqs[i]);
vqs[i] = NULL;
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 4cd9ea5..d9dd0f78 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -468,7 +468,7 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
{
struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
unsigned int irq = platform_get_irq(vm_dev->pdev, 0);
- int i, err;
+ int i, err, queue_idx = 0;
err = request_irq(irq, vm_interrupt, IRQF_SHARED,
dev_name(&vdev->de...
2014 Nov 06
2
[RFC PATCH] virtio-mmio: support for multiple irqs
...err;
>> +}
>>
>> static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned index,
>> void (*callback)(struct virtqueue *vq),
>> @@ -392,29 +501,92 @@ error_available:
>> return ERR_PTR(err);
>> }
>>
>> -static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>> - struct virtqueue *vqs[],
>> - vq_callback_t *callbacks[],
>> - const char *names[])
>> +static int vm_try_to_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>> + struct virtqueue *vqs[...
2014 Nov 06
2
[RFC PATCH] virtio-mmio: support for multiple irqs
...err;
>> +}
>>
>> static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned index,
>> void (*callback)(struct virtqueue *vq),
>> @@ -392,29 +501,92 @@ error_available:
>> return ERR_PTR(err);
>> }
>>
>> -static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>> - struct virtqueue *vqs[],
>> - vq_callback_t *callbacks[],
>> - const char *names[])
>> +static int vm_try_to_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>> + struct virtqueue *vqs[...