search for: vixdisklib_exit

...err = pthread_key_create (&error_suppression, NULL); + if (err != 0) { + nbdkit_error ("vddk: pthread_key_create: %s\n", strerror (err)); + exit (EXIT_FAILURE); + } +} + +/* Unload the plugin. */ +static void +vddk_unload (void) +{ + if (init_called) { + DEBUG_CALL ("VixDiskLib_Exit", ""); + VixDiskLib_Exit (); + } + if (dl) + dlclose (dl); + free (config); + free (libdir); + free (password); + pthread_key_delete (error_suppression); +} + static void trim (char *str) { @@ -133,12 +164,37 @@ debug_function (const char *fs, va_list args) nbdkit_d...

We had a query yesterday about the VDDK plugin and making it actually obey the weird "Multithreading Considerations" rules in the VDDK documentation (https://vdc-download.vmware.com/vmwb-repository/dcr-public/8f96698a-0e7b-4d67-bb6c-d18a1d101540/ef536a47-27cd-481a-90ef-76b38e75353c/vsphere-vddk-671-programming-guide.pdf) This patch is my attempt to implement this. The idea is that the

...ifndef NO_INITEX_STUB STUB (VixDiskLib_InitEx, VixError, (uint32_t major, uint32_t minor, @@ -56,13 +52,9 @@ STUB (VixDiskLib_InitEx, VixDiskLibGenericLogFunc *panic_function, const char *lib_dir, const char *config_file)); -#endif -#ifndef NO_EXIT_STUB STUB (VixDiskLib_Exit, void, (void)); -#endif - STUB (VixDiskLib_GetErrorText, char *, (VixError err, const char *unused)); diff --git a/tests/dummy-vddk.c b/tests/dummy-vddk.c index ed5d3712..13be492d 100644 --- a/tests/dummy-vddk.c +++ b/tests/dummy-vddk.c @@ -30,18 +30,24 @@ * SUCH DAMA...

This is my second attempt at this. The first version (also not working) was here: https://www.redhat.com/archives/libguestfs/2019-October/msg00062.html In part 1/2 I introduce a new .ready_to_serve plugin method which is called after forking and just before accepting any client connection. The idea would be that plugins could start background threads here. However this doesn't work well in

Probably needs a bit of cleanup, but seems like it is generally the right direction. One thing I've noticed is that the expect test randomly (but rarely) hangs :-( I guess something is racey but I don't know what at the moment. Rich.