search for: vitruque_add_datum

...the "no allocation, no dma mapping" case, so that it's *obvious* that that never happens. So instead of having virtio_balloon_send_free_pages() call a really generic complex chain of functions that in _some_ cases can do memory allocation, why isn't there a short-circuited "vitruque_add_datum()" that is guaranteed to never do anything like that? Honestly, I look at "add_one_sg()" and it really doesn't make me happy. It looks hacky as hell. If I read the code right, you're really trying to just queue up a simple tuple of <pfn,len>, except you encode it as a...

...the "no allocation, no dma mapping" case, so that it's *obvious* that that never happens. So instead of having virtio_balloon_send_free_pages() call a really generic complex chain of functions that in _some_ cases can do memory allocation, why isn't there a short-circuited "vitruque_add_datum()" that is guaranteed to never do anything like that? Honestly, I look at "add_one_sg()" and it really doesn't make me happy. It looks hacky as hell. If I read the code right, you're really trying to just queue up a simple tuple of <pfn,len>, except you encode it as a...

...#39;s *obvious* that that >>> never happens. >>> >>> So instead of having virtio_balloon_send_free_pages() call a really >>> generic complex chain of functions that in _some_ cases can do memory >>> allocation, why isn't there a short-circuited "vitruque_add_datum()" >>> that is guaranteed to never do anything like that? >>> >>> Honestly, I look at "add_one_sg()" and it really doesn't make me >>> happy. It looks hacky as hell. If I read the code right, you're really >>> trying to just queue...

On Mon, Jun 11, 2018 at 11:32 AM Linus Torvalds <torvalds at linux-foundation.org> wrote: > > So now we apparently do a GFP_KERNEL allocation insider the mm zone > lock, which is broken on just _so_ many levels. Oh, I see the comment about how it doesn't actually do an allocation at all because it's a single-entry. Still too damn ugly to live, and much too fragile. No way

On Mon, Jun 11, 2018 at 11:32 AM Linus Torvalds <torvalds at linux-foundation.org> wrote: > > So now we apparently do a GFP_KERNEL allocation insider the mm zone > lock, which is broken on just _so_ many levels. Oh, I see the comment about how it doesn't actually do an allocation at all because it's a single-entry. Still too damn ugly to live, and much too fragile. No way