search for: visitshift

Oh, no. I should have been more clear. The patch was not rejected, just lost in the daily shuffle. I already have my employer's approval to send this upstream, so I will prepare a patch against trunk this morning. > I proposed a similar patch to LLVM (left circular shift) around 10/2011. > > Parts of my patch did make it into trunk about a year after, but others > > did not.

On Monday, July 30, 2012 12:16 AM, Cameron McInally wrote: > Hey Andy, > > I proposed a similar patch to LLVM (left circular shift) around 10/2011. > Parts of my patch did make it into trunk about a year after, but others > did not. > > At that time, my solution was to add a binary operator to the IRBuilder, > since LCS fits in nicely with the other shift operators. But,

...====================================== --- lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h (revision 161045) +++ lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h (working copy) @@ -483,6 +483,7 @@ void visitXor (const User &I) { visitBinary(I, ISD::XOR); } void visitShl (const User &I) { visitShift(I, ISD::SHL); } void visitLShr(const User &I) { visitShift(I, ISD::SRL); } + void visitCShl(const User &I) { visitShift(I, ISD::ROTL); } void visitAShr(const User &I) { visitShift(I, ISD::SRA); } void visitICmp(const User &I); void visitFCmp(const User &I);