search for: visitbinaryoperator

.../APInt.cpp:233: llvm::APInt llvm::APInt::operator*(const llvm::APInt &) const: Assertion `BitWidth == RHS.BitWidth && "Bit widths must be the same"' failed. I have recompiled llvm and printer the 2 widths. BitWidth is 1 and RHS.BitWidth is 32. I would clarify that in the visitBinaryOperator() I just call Interpreter::visitBinaryOperator(I) and I do not perform any other operation. Can you imagine any reason why this error happens? I have attached the file I used for having the error. Thanks -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://li...

...Type.cpp:46 #1 0x0837cac5 in llvm::PATypeHolder::operator llvm::Type* (this=0x8) at /work/aditya/llvm-2.2/include/llvm/AbstractTypeUser.h:149 #2 0x0837cadc in llvm::Value::getType (this=0x0) at /work/aditya/llvm-2.2/include/llvm/Value.h:87 #3 0x08637b52 in (anonymous namespace)::Verifier::visitBinaryOperator (this=0x8794f18, B=@0x87994a8) at Verifier.cpp:905 #4 0x0863d81e in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visitAdd (this=0x8794f18, I=@0x87994a8) at /work/aditya/llvm-2.2/include/llvm/Instruction.def:107 #5 0x0863de16 in llvm::InstVisitor<(anonymous namespace):...

...ParseParameterDeclarationClause clang::Parser::ParseFunctionDeclarator clang::Parser::ParseDirectDeclarator Crash Type: Stack-overflow Crash Address: 0x7ffc78d69f48 Crash State: clang::StmtVisitorBase<clang::make_const_ptr, IntExprEvaluator, bool>::Visit Evaluate IntExprEvaluator::VisitBinaryOperator Crash Type: ASSERT Crash Address: Crash State: !Prev.isAmbiguous() && "Cannot have an ambiguity in previous-declaration lookup" DiagnoseInvalidRedeclaration clang::Sema::ActOnFunctionDeclarator cxa_demangler: https://bugs.chromium.org/p/oss-fuzz/issues/list?can=1&q=l...

...;, which is wrong. Why is changing that not the fix? That is, some variant of diff --git a/lib/Transforms/Scalar/SCCP.cpp b/lib/Transforms/Scalar/SCCP.cpp index 8a6be97..45f1241 100644 --- a/lib/Transforms/Scalar/SCCP.cpp +++ b/lib/Transforms/Scalar/SCCP.cpp @@ -908,8 +908,18 @@ void SCCPSolver::visitBinaryOperator(Instruction &I) { } // If something is undef, wait for it to resolve. - if (!V1State.isOverdefined() && !V2State.isOverdefined()) - return; + if (!V1State.isOverdefined() && !V2State.isOverdefined()) { + Constant *L = UndefValue::get(I.getOperand(0)->getType())...

...ed, there are bugs open with the same cause. > > diff --git a/lib/Transforms/Scalar/SCCP.cpp > b/lib/Transforms/Scalar/SCCP.cpp > index 8a6be97..45f1241 100644 > --- a/lib/Transforms/Scalar/SCCP.cpp > +++ b/lib/Transforms/Scalar/SCCP.cpp > @@ -908,8 +908,18 @@ void SCCPSolver::visitBinaryOperator(Instruction &I) { > } > > // If something is undef, wait for it to resolve. > - if (!V1State.isOverdefined() && !V2State.isOverdefined()) > - return; > + if (!V1State.isOverdefined() && !V2State.isOverdefined()) { > + Constant *L = UndefValue::...

...an you point me to those? >> diff --git a/lib/Transforms/Scalar/SCCP.cpp >> b/lib/Transforms/Scalar/SCCP.cpp >> index 8a6be97..45f1241 100644 >> --- a/lib/Transforms/Scalar/SCCP.cpp >> +++ b/lib/Transforms/Scalar/SCCP.cpp >> @@ -908,8 +908,18 @@ void SCCPSolver::visitBinaryOperator(Instruction &I) >> { >> } >> >> // If something is undef, wait for it to resolve. >> - if (!V1State.isOverdefined() && !V2State.isOverdefined()) >> - return; >> + if (!V1State.isOverdefined() && !V2State.isOverdefined()) { &gt...

...::ParseDirectDeclarator > > > > > > Crash Type: Stack-overflow > > Crash Address: 0x7ffc78d69f48 > > Crash State: > > clang::StmtVisitorBase<clang::make_const_ptr, IntExprEvaluator, > > bool>::Visit > > Evaluate > > IntExprEvaluator::VisitBinaryOperator > > > > Crash Type: ASSERT > > Crash Address: > > Crash State: > > !Prev.isAmbiguous() && "Cannot have an ambiguity in > previous-declaration > > lookup" > > DiagnoseInvalidRedeclaration > > clang::Sema::ActOnFunctionDeclara...

Hi. I'm sending this email to -dev as this may be of interest of many/people may have opinions/want to try the change before it goes in to report problems. I've been recently working on a patch to integrate `undef` in the SCCP solver, in the hope of fixing a tail of latent bugs in SCCP which remained uncovered for many years. I think this is a decent time to propose, so that it can