search for: visitalloca

...long double is best: use 80 bits for the underlying size, and where extra bytes are required for padding, do that by looking at the alignment. There is no need to allocate more than 10 bytes for scalars of this type, and we currently don't for stack objects. (The code you point to in visitAlloca does look like it might be a problem, but I can't make it fail. Known-size arrays appear here as a single object [3 x x86_f80], and the size is computed correctly; unknown-size arrays have the size of the elements passed from the FE, and this includes padding. How does that size*count...

Now that I'm working on codegen support for arbitrary precision integers (think i36 or i129), I've hit the problem of what getTypeSize and friends should return for such integers (the current implementations seem to me to be wrong). However it's not clear to me how getTypeSize and friends are defined. There seem to be several possible meanings for the size of a type (only talking

...space)::Verifier::CheckFailed (this=0x8794f18, Message=@0xbfa1a878, V1=0x877b488, V2=0x0, V3=0x0, V4=0x0) at Verifier.cpp:292 #7 0x08636ba2 in (anonymous namespace)::Verifier::visitInstruction (this=0x8794f18, I=@0x877b488) at Verifier.cpp:1077 #8 0x08637807 in (anonymous namespace)::Verifier::visitAllocationInst (this=0x8794f18, AI=@0x877b488) at Verifier.cpp:1037 #9 0x0863d75e in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visitAllocaInst (this=0x8794f18, I=@0x877b488) at /work/aditya/llvm-2.2/include/llvm/Support/InstVisitor.h:173 #10 0x0863d778 in llvm::InstVisitor<(an...

...amespace)::Verifier::CheckFailed (this=0x8794f18, Message=@0xbfa1a878, V1=0x877b488, V2=0x0, V3=0x0, V4=0x0) at Verifier.cpp:292 #7 0x08636ba2 in (anonymous namespace)::Verifier::visitInstruction (this=0x8794f18, I=@0x877b488) at Verifier.cpp:1077 #8 0x08637807 in (anonymous namespace)::Verifier::visitAllocationInst (this=0x8794f18, AI=@0x877b488) at Verifier.cpp:1037 #9 0x0863d75e in llvm::InstVisitor<(anonymous namespace)::Verifier, void>::visitAllocaInst (this=0x8794f18, I=@0x877b488) at /work/aditya/llvm-2.2/include/llvm/Support/InstVisitor.h:173 #10 0x0863d778 in llvm::InstVisitor<(anony...

...en I'm not sure it can always be done on all targets (see below). This doesn't seem worth the trouble. > Should (4) be the same as (5) since alloca / malloc are allocating an > array of the specific type? Yes, I think so. Currently alloca allocates a multiple of getTypeSize (see visitAlloca in SelectionDAGISel). This seems to be a bug - it needs to use getABITypeSize. This also means that all the (many) places that use getTypeSize as the amount of memory allocated by an alloca need to be changed... > > In general (1) and (2) will be the same. (4) needs to be at least > &g...

...ilder::visitInlineAsm(llvm::ImmutableCallSite) in libLLVMSelectionDAG.a(SelectionDAGBuilder.cpp.o) llvm::SelectionDAGBuilder::LowerCallTo(llvm::ImmutableCallSite, llvm::SDValue, bool, llvm::MachineBasicBlock*)in libLLVMSelectionDAG.a(SelectionDAGBuilder.cpp.o) llvm::SelectionDAGBuilder::visitAlloca(llvm::AllocaInst const&)in libLLVMSelectionDAG.a(SelectionDAGBuilder.cpp.o) (anonymous namespace)::DAGCombiner::SimplifySelectCC(llvm::DebugLoc, llvm::SDValue, llvm::SDValue, llvm::SDValue, llvm::SDValue, llvm::ISD::CondCode, bool) in libLLVMSelectionDAG.a(DAGCombiner.cpp.o)...

.... Seems ok for the initial implementation. We can worry about size reduction later. > >> Should (4) be the same as (5) since alloca / malloc are allocating an >> array of the specific type? > > Yes, I think so. Currently alloca allocates a multiple of getTypeSize > (see visitAlloca in SelectionDAGISel). This seems to be a bug - it > needs to use getABITypeSize. This also means that all the (many) > places > that use getTypeSize as the amount of memory allocated by an alloca > need > to be changed... Hrm. It does seem like it could be a bug. I am not too...

On Oct 7, 2007, at 11:23 AM, Duncan Sands wrote: > Now that I'm working on codegen support for arbitrary precision > integers (think i36 or i129), I've hit the problem of what > getTypeSize and friends should return for such integers (the > current implementations seem to me to be wrong). However it's > not clear to me how getTypeSize and friends are defined. > >

...ilder::visitInlineAsm(llvm::ImmutableCallSite) in libLLVMSelectionDAG.a(SelectionDAGBuilder.cpp.o) llvm::SelectionDAGBuilder::LowerCallTo(llvm::ImmutableCallSite, llvm::SDValue, bool, llvm::MachineBasicBlock*)in libLLVMSelectionDAG.a(SelectionDAGBuilder.cpp.o) llvm::SelectionDAGBuilder::visitAlloca(llvm::AllocaInst const&)in libLLVMSelectionDAG.a(SelectionDAGBuilder.cpp.o) (anonymous namespace)::DAGCombiner::SimplifySelectCC(llvm::DebugLoc, llvm::SDValue, llvm::SDValue, llvm::SDValue, llvm::SDValue, llvm::ISD::CondCode, bool) in libLLVMSelectionDAG.a(DAGCombiner.cpp.o)...