Displaying 6 results from an estimated 6 matches for "visit_guest".
2017 Nov 03
2
[PATCH] diff: avoid potential null pointer dereference on error
If visit_guest() fails, then it returns a null pointer; later on,
free_tree() is called unconditionally on the variables, thus
dereferencing null pointers.
Thus guard the free_tree() invocations.
---
diff/diff.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/diff/diff.c b/diff/diff.c...
2017 Nov 03
1
Re: [PATCH] diff: avoid potential null pointer dereference on error
On Fri, Nov 03, 2017 at 12:48:37PM -0500, Eric Blake wrote:
> On 11/03/2017 11:19 AM, Pino Toscano wrote:
> > If visit_guest() fails, then it returns a null pointer; later on,
> > free_tree() is called unconditionally on the variables, thus
> > dereferencing null pointers.
> >
> > Thus guard the free_tree() invocations.
>
> Would it be any better to teach free_tree() to be more free()-like...
2017 Nov 03
0
Re: [PATCH] diff: avoid potential null pointer dereference on error
On 11/03/2017 11:19 AM, Pino Toscano wrote:
> If visit_guest() fails, then it returns a null pointer; later on,
> free_tree() is called unconditionally on the variables, thus
> dereferencing null pointers.
>
> Thus guard the free_tree() invocations.
Would it be any better to teach free_tree() to be more free()-like by
being a no-op on NULL?
--...
2014 Sep 22
2
[PATCH] New APIs: Implement stat calls that return nanosecond timestamps (RHBZ#1144891).
..._entry (const char *dir, const char *name, const struct guestfs_stat *stat, const struct guestfs_xattr_list *xattrs, void *vt);
+static int visit_entry (const char *dir, const char *name, const struct guestfs_statns *stat, const struct guestfs_xattr_list *xattrs, void *vt);
static struct tree *
visit_guest (guestfs_h *g)
@@ -454,13 +454,13 @@ visit_guest (guestfs_h *g)
*/
static int
visit_entry (const char *dir, const char *name,
- const struct guestfs_stat *stat_orig,
+ const struct guestfs_statns *stat_orig,
const struct guestfs_xattr_list *xattrs_orig,...
2018 Sep 19
0
[PATCH 2/2] Introduce a --key option in tools that accept keys
...} else
error (EXIT_FAILURE, 0,
_("unknown long option: %s (%d)"),
@@ -381,7 +386,7 @@ main (int argc, char *argv[])
if (guestfs_launch (g2) == -1)
exit (EXIT_FAILURE);
- inspect_mount_handle (g2);
+ inspect_mount_handle (g2, ks);
if ((tree2 = visit_guest (g2)) == NULL)
errors++;
@@ -397,6 +402,8 @@ main (int argc, char *argv[])
free_drives (drvs);
free_drives (drvs2);
+ free_key_store (ks);
+
guestfs_close (g);
guestfs_close (g2);
diff --git a/diff/virt-diff.pod b/diff/virt-diff.pod
index 192237697..f8c0bceb4 100644
--- a/diff...
2018 Sep 19
5
[PATCH 0/2] RFC: --key option for tools
Hi,
the following series adds a --key option in the majority of tools: this
makes it possible to pass LUKS credentials programmatically, avoid the
need to manually input them, or unsafely pass them via stdin.
Thanks,
Pino Toscano (2):
mltools: create a cmdline_options struct
Introduce a --key option in tools that accept keys
builder/cmdline.ml | 2 +-