search for: visibility_cflag

On Wed, Jul 30, 2014 at 9:48 AM, Thierry Reding <thierry.reding at gmail.com> wrote: > From: Thierry Reding <treding at nvidia.com> > > Checks whether or not the compiler supports the -fvisibility option. If > so it sets the VISIBILITY_CFLAGS variable which can be added to the per > directory AM_CFLAGS where appropriate. > > By default all symbols will be hidden via the VISIBILITY_CFLAGS. The > drm_public macro can be used to mark symbols that should be exported. hmm, maybe dumb question, I might possibly have missed some...

On 30/07/14 11:16, Christian K?nig wrote: > [CCing Emil as well] > > Am 30.07.2014 um 11:38 schrieb Maarten Lankhorst: >> Using -export-symbols-regex all private symbols are hidden, resulting in the >> following changes: > > Wasn't "-export-symbols-regex" exactly that stuff we are trying to avoid in mesa? > IMHO we should try to pick up Thierry

...rt it". BTW, what is the compiler option called for clang to suppress visibility(-hiden) feature - ... -fvisibility=no ? I would like to test w/o your patches. - Sedat - > - save_CFLAGS="$CFLAGS" > - AC_MSG_CHECKING([whether $CC supports -fvisibility=hidden]) > - VISIBILITY_CFLAGS="-fvisibility=hidden" > - CFLAGS="$CFLAGS $VISIBILITY_CFLAGS" > - AC_LINK_IFELSE([AC_LANG_PROGRAM()], AC_MSG_RESULT([yes]), > - [VISIBILITY_CFLAGS=""; AC_MSG_RESULT([no])]); > - > - # Restore CFLAGS; VISIBILITY_CFLAGS are added...

...15:31, Rob Clark wrote: > On Wed, Jul 30, 2014 at 9:48 AM, Thierry Reding > <thierry.reding at gmail.com> wrote: >> From: Thierry Reding <treding at nvidia.com> >> >> Checks whether or not the compiler supports the -fvisibility option. If >> so it sets the VISIBILITY_CFLAGS variable which can be added to the per >> directory AM_CFLAGS where appropriate. >> >> By default all symbols will be hidden via the VISIBILITY_CFLAGS. The >> drm_public macro can be used to mark symbols that should be exported. > > hmm, maybe dumb question, I might...

From: Thierry Reding <treding at nvidia.com> Checks whether or not the compiler supports the -fvisibility option. If so it sets the VISIBILITY_CFLAGS variable which can be added to the per directory AM_CFLAGS where appropriate. By default all symbols will be hidden via the VISIBILITY_CFLAGS. The drm_public macro can be used to mark symbols that should be exported. Signed-off-by: Thierry Reding <treding at nvidia.com> --- Changes in v3:...

...e_CFLAGS > I'm not sure we want/need this one ? > # Enable -fvisibility=hidden if using a gcc that supports it As spotted by Sedat, please update the comment. > - save_CFLAGS="$CFLAGS" > - AC_MSG_CHECKING([whether $CC supports -fvisibility=hidden]) > - VISIBILITY_CFLAGS="-fvisibility=hidden" > - CFLAGS="$CFLAGS $VISIBILITY_CFLAGS" > - AC_LINK_IFELSE([AC_LANG_PROGRAM()], AC_MSG_RESULT([yes]), > - [VISIBILITY_CFLAGS=""; AC_MSG_RESULT([no])]); > - > - # Restore CFLAGS; VISIBILITY_CFLAGS are added to it where...

Patch 1 adds a check for the compilers visibility macro to configure.ac. Patch 2 avoids redefined symbol errors in clang of the tls entry points. Based on a suggestion from Rafael Ávila de Espíndola <rafael.espindola at gmail.com> in http://llvm.org/bugs/show_bug.cgi?id=19778. Tested with gcc 4.9 and clang 3.6(rc) Marc Dietrich (2): configure: add visibility macro detection to configure

...supported by your clang. > Interestingly, it is supported here (also clang 3.6 from yesterday). What does > config.log say about it? > Here is my config.log. $ grep -i visibility config.log configure:18401: checking for __attribute__((visibility)) ax_cv_have_func_attribute_visibility=no VISIBILITY_CFLAGS='' VISIBILITY_CXXFLAGS='' - Sedat - -------------- next part -------------- A non-text attachment was scrubbed... Name: config.log Type: text/x-log Size: 325727 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150217/61facd8b/attachment.bin...

...uveau: annotate the private symbols nouveau: add symbols test libkms: annotate private symbols libkms: add symbols test exynos: add symbols test omap: add symbols test tegra: add symbols test drm: rename libdrm{,_macros}.h drm: remove no longer needed VISIBILITY_CFLAGS drm: remove drm_public macro configure: request/set the compiler in C99 mode drm: use c99 __func__ over __FUNCTION__ man: rework the Makefile.am android: set the HAVE_VISIBILITY define freedreno: link against CLOCK_LIB Greg Hackmann (1): Add missing <s...

On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich <marvin24 at gmx.de> wrote: > Avoid redefined symbol errors in clang. Based on a suggestion from > Rafael Ávila de Espíndola <rafael.espindola at gmail.com> in > http://llvm.org/bugs/show_bug.cgi?id=19778. > > Signed-off-by: Marc Dietrich <marvin24 at gmx.de> > --- > v2: - no change > v3: - include util

...| 1 + nouveau/pushbuf.c | 20 ++++++++++---------- 5 files changed, 37 insertions(+), 35 deletions(-) diff --git a/nouveau/Makefile.am b/nouveau/Makefile.am index 206e892..73cff9f 100644 --- a/nouveau/Makefile.am +++ b/nouveau/Makefile.am @@ -1,5 +1,6 @@ AM_CFLAGS = \ $(WARN_CFLAGS) \ + $(VISIBILITY_CFLAGS) \ -I$(top_srcdir) \ -I$(top_srcdir)/nouveau \ $(PTHREADSTUBS_CFLAGS) \ diff --git a/nouveau/bufctx.c b/nouveau/bufctx.c index 23d6f09..fdd3164 100644 --- a/nouveau/bufctx.c +++ b/nouveau/bufctx.c @@ -68,7 +68,7 @@ nouveau_bufctx(struct nouveau_bufctx *bctx) return (struct nouveau_bufctx_p...

...f_t... yes checking for immediate structures... yes LIBREPLACE_CC_CHECKS: END checking whether we are really using the Sun C compiler... no checking for C99 designated initializers... yes checking that the C compiler understands negative enum values... yes checking for test routines... yes checking VISIBILITY_CFLAGS for gcc -fvisibility=hidden... -fvisibility=hidden checking whether the C compiler supports the visibility attribute... yes checking DEVELOPER_CFLAGS for gcc -Wall... -Wall checking DEVELOPER_CFLAGS for gcc -Wshadow... -Wshadow checking DEVELOPER_CFLAGS for gcc -Werror-implicit-function-declaratio...