search for: virtuqueue_enable_cb_delay

...either >>> always call virtqueue_enable_cb_delayed or virtqueue_enable_cb >>> but not both? >> We need call them both when tx interrupt is enabled I believe. > Can you pls reply to my patch and document issues you see? > In the previous reply you said you're using virtuqueue_enable_cb_delayed(), so no race in your patch.

...either >>> always call virtqueue_enable_cb_delayed or virtqueue_enable_cb >>> but not both? >> We need call them both when tx interrupt is enabled I believe. > Can you pls reply to my patch and document issues you see? > In the previous reply you said you're using virtuqueue_enable_cb_delayed(), so no race in your patch.

...tqueue_enable_cb_delayed or virtqueue_enable_cb > >>> but not both? > >> We need call them both when tx interrupt is enabled I believe. > > Can you pls reply to my patch and document issues you see? > > > > In the previous reply you said you're using > virtuqueue_enable_cb_delayed(), so no race in your patch. OK so you think my patch is also correct, but that yours gives better efficiency? -- MST

On 10/15/2014 05:34 PM, Michael S. Tsirkin wrote: > On Wed, Oct 15, 2014 at 03:25:25PM +0800, Jason Wang wrote: >> This patch checks the new event idx to make sure used event idx never >> goes back. This is used to synchronize the calls between >> virtqueue_enable_cb_delayed() and virtqueue_enable_cb(). >> >> Cc: Rusty Russell <rusty at rustcorp.com.au>

On 10/15/2014 05:34 PM, Michael S. Tsirkin wrote: > On Wed, Oct 15, 2014 at 03:25:25PM +0800, Jason Wang wrote: >> This patch checks the new event idx to make sure used event idx never >> goes back. This is used to synchronize the calls between >> virtqueue_enable_cb_delayed() and virtqueue_enable_cb(). >> >> Cc: Rusty Russell <rusty at rustcorp.com.au>