search for: virtscsi_add_cmd

On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab at linux-iscsi.org> > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > level protection resources. (currently hardcoded to 1) > > It changes virtscsi_add_cmd() to attach outgoing / incoming > protection SGLs preceeding the data payload, and is using the > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > to signal to vhost/scsi how many prot_sgs to expect. > > v3 changes: > - Use VIRTIO_SCSI_F_T10_PI to determine PI or n...

On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab at linux-iscsi.org> > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > level protection resources. (currently hardcoded to 1) > > It changes virtscsi_add_cmd() to attach outgoing / incoming > protection SGLs preceeding the data payload, and is using the > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > to signal to vhost/scsi how many prot_sgs to expect. > > v3 changes: > - Use VIRTIO_SCSI_F_T10_PI to determine PI or n...

...A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > level protection resources. (currently hardcoded to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: >...

...A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > level protection resources. (currently hardcoded to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: >...

...Bellinger <nab at linux-iscsi.org> > > > > > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > > > level protection resources. (currently hardcoded to 1) > > > > > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > > protection SGLs preceeding the data payload, and is using the > > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > &g...

...Bellinger <nab at linux-iscsi.org> > > > > > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > > > level protection resources. (currently hardcoded to 1) > > > > > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > > protection SGLs preceeding the data payload, and is using the > > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > &g...

...A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > level protection resources. (currently hardcoded to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: >...

...A. Bellinger wrote: > > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > level protection resources. (currently hardcoded to 1) > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > protection SGLs preceeding the data payload, and is using the > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > v3 changes: >...

Hi all, this series adds multiqueue support to the virtio-scsi driver, based on Jason Wang's work on virtio-net. It uses a simple queue steering algorithm that expects one queue per CPU. LUNs in the same target always use the same queue (so that commands are not reordered); queue switching occurs when the request being queued is the only one for the target. Also based on Jason's

Hi all, this series adds multiqueue support to the virtio-scsi driver, based on Jason Wang's work on virtio-net. It uses a simple queue steering algorithm that expects one queue per CPU. LUNs in the same target always use the same queue (so that commands are not reordered); queue switching occurs when the request being queued is the only one for the target. Also based on Jason's

On Thu, Aug 10, 2017 at 05:40:34PM +0100, Richard W.M. Jones wrote: > If using indirect descriptors, you can make the total_sg as large as > you want. That would be a spec violation though, even if it happens to work on current QEMU. The spec says: A driver MUST NOT create a descriptor chain longer than the Queue Size of the device. What prompted this patch? Do we ever encounter this

On Thu, Aug 10, 2017 at 05:40:34PM +0100, Richard W.M. Jones wrote: > If using indirect descriptors, you can make the total_sg as large as > you want. That would be a spec violation though, even if it happens to work on current QEMU. The spec says: A driver MUST NOT create a descriptor chain longer than the Queue Size of the device. What prompted this patch? Do we ever encounter this

...at 09:32:09PM +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > level protection resources. (currently hardcoded to 1) > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > protection SGLs preceeding the data payload, and is using the > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > to signal to vhost/scsi how many prot_sgs to expect. > > > > v3 changes: > > - Use VIRTIO_SCSI...

...> > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > > level protection resources. (currently hardcoded to 1) > > > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > protection SGLs preceeding the data payload, and is using the > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > &...

...> > From: Nicholas Bellinger <nab at linux-iscsi.org> > > > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > > level protection resources. (currently hardcoded to 1) > > > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > protection SGLs preceeding the data payload, and is using the > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > to signal to vhost/scsi how many prot_sgs to expect. > > > > > > &...

...ux-iscsi.org> > > > > > > > > > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > > > > > level protection resources. (currently hardcoded to 1) > > > > > > > > > > > > It changes virtscsi_add_cmd() to attach outgoing / incoming > > > > > > protection SGLs preceeding the data payload, and is using the > > > > > > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal > > > > > > to signal to vhost/scsi how many prot_sgs to expect. &g...

...0000080050033 [ 4.044942] CR2: 00007fcff02e931c CR3: 000000001d23b000 CR4: 00000000003406f0 [ 4.045815] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 4.046684] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 4.047559] Call Trace: [ 4.047876] virtscsi_add_cmd+0x1c9/0x280 [virtio_scsi] [ 4.048528] virtscsi_kick_cmd+0x38/0x90 [virtio_scsi] [ 4.049161] virtscsi_queuecommand+0x104/0x280 [virtio_scsi] [ 4.049875] virtscsi_queuecommand_single+0x38/0x40 [virtio_scsi] [ 4.050628] scsi_dispatch_cmd+0xf9/0x390 [ 4.051128] scsi_queue_rq+0x5e5/0...

....044942] CR2: 00007fcff02e931c CR3: 000000001d23b000 CR4: 00000000003406f0 > [ 4.045815] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 4.046684] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 4.047559] Call Trace: > [ 4.047876] virtscsi_add_cmd+0x1c9/0x280 [virtio_scsi] > [ 4.048528] virtscsi_kick_cmd+0x38/0x90 [virtio_scsi] > [ 4.049161] virtscsi_queuecommand+0x104/0x280 [virtio_scsi] > [ 4.049875] virtscsi_queuecommand_single+0x38/0x40 [virtio_scsi] > [ 4.050628] scsi_dispatch_cmd+0xf9/0x390 > [ 4.05112...

....044942] CR2: 00007fcff02e931c CR3: 000000001d23b000 CR4: 00000000003406f0 > [ 4.045815] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 4.046684] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 4.047559] Call Trace: > [ 4.047876] virtscsi_add_cmd+0x1c9/0x280 [virtio_scsi] > [ 4.048528] virtscsi_kick_cmd+0x38/0x90 [virtio_scsi] > [ 4.049161] virtscsi_queuecommand+0x104/0x280 [virtio_scsi] > [ 4.049875] virtscsi_queuecommand_single+0x38/0x40 [virtio_scsi] > [ 4.050628] scsi_dispatch_cmd+0xf9/0x390 > [ 4.05112...

OK, this is (ab)uses some of Paolo's patches. The first 7 are candidates for this merge window (maybe), the rest I'm not so sure about. Thanks, Rusty. Paolo Bonzini (3): scatterlist: introduce sg_unmark_end virtio-blk: reorganize virtblk_add_req virtio-blk: use virtqueue_add_sgs on req path Rusty Russell (13): virtio_ring: virtqueue_add_sgs, to add multiple sgs. virtio-blk: