search for: virtqueue_enable

...see that as compared to my original patch, you have > added a new flag: VRING_AVAIL_F_NO_URGENT_INTERRUPT > I don't think it's necessary, see below. > > As such, I think this patch should be split: > - original patch adding support for urgent descriptors > - a patch adding virtqueue_enable/disable_cb_urgent(_prepare)? Not sure this is a good idea, since the api of first patch is in-completed. > >> --- >> drivers/virtio/virtio_ring.c | 75 +++++++++++++++++++++++++++++++++++++--- >> include/linux/virtio.h | 14 ++++++++ >> include/uapi/linux/...

...see that as compared to my original patch, you have > added a new flag: VRING_AVAIL_F_NO_URGENT_INTERRUPT > I don't think it's necessary, see below. > > As such, I think this patch should be split: > - original patch adding support for urgent descriptors > - a patch adding virtqueue_enable/disable_cb_urgent(_prepare)? Not sure this is a good idea, since the api of first patch is in-completed. > >> --- >> drivers/virtio/virtio_ring.c | 75 +++++++++++++++++++++++++++++++++++++--- >> include/linux/virtio.h | 14 ++++++++ >> include/uapi/linux/...

...alled. Otherwise callback will never be used. > > Cheers, > Rusty. > > Hi Rusty, Thank you for your response. I mean should we set VRING_AVAIL_F_NO_INTERRUPT when virtqueue is initialized whether there is callback or not? As it would be set in function virtqueue_disable_cb and virtqueue_enable_cb_prepare later. Regards, Haifeng

...alled. Otherwise callback will never be used. > > Cheers, > Rusty. > > Hi Rusty, Thank you for your response. I mean should we set VRING_AVAIL_F_NO_INTERRUPT when virtqueue is initialized whether there is callback or not? As it would be set in function virtqueue_disable_cb and virtqueue_enable_cb_prepare later. Regards, Haifeng

...asowang at redhat.com> I see that as compared to my original patch, you have added a new flag: VRING_AVAIL_F_NO_URGENT_INTERRUPT I don't think it's necessary, see below. As such, I think this patch should be split: - original patch adding support for urgent descriptors - a patch adding virtqueue_enable/disable_cb_urgent(_prepare)? > --- > drivers/virtio/virtio_ring.c | 75 +++++++++++++++++++++++++++++++++++++--- > include/linux/virtio.h | 14 ++++++++ > include/uapi/linux/virtio_ring.h | 5 ++- > 3 files changed, 89 insertions(+), 5 deletions(-) > > diff...

...vq->vring.desc[head].flags |= VRING_DESC_F_URGENT; + urgent = false; + } vq->vring.desc[i].addr = sg_phys(sg); vq->vring.desc[i].len = sg->length; prev = i; @@ -305,6 +317,8 @@ add_head: /** * virtqueue_add_sgs - expose buffers to other end + * @urgent: in case virtqueue_enable_cb_delayed was called, cause an interrupt + * after this descriptor was completed * @vq: the struct virtqueue we're talking about. * @sgs: array of terminated scatterlists. * @out_num: the number of scatterlists readable by other side @@ -337,7 +351,7 @@ int virtqueue_add_sgs(str...

...vq->vring.desc[head].flags |= VRING_DESC_F_URGENT; + urgent = false; + } vq->vring.desc[i].addr = sg_phys(sg); vq->vring.desc[i].len = sg->length; prev = i; @@ -305,6 +317,8 @@ add_head: /** * virtqueue_add_sgs - expose buffers to other end + * @urgent: in case virtqueue_enable_cb_delayed was called, cause an interrupt + * after this descriptor was completed * @vq: the struct virtqueue we're talking about. * @sgs: array of terminated scatterlists. * @out_num: the number of scatterlists readable by other side @@ -337,7 +351,7 @@ int virtqueue_add_sgs(str...

Hello all: We free old transmitted packets in ndo_start_xmit() currently, so any packet must be orphaned also there. This was used to reduce the overhead of tx interrupt to achieve better performance. But this may not work for some protocols such as TCP stream. TCP depends on the value of sk_wmem_alloc to implement various optimization for small packets stream such as TCP small queue and auto

Hello all: We free old transmitted packets in ndo_start_xmit() currently, so any packet must be orphaned also there. This was used to reduce the overhead of tx interrupt to achieve better performance. But this may not work for some protocols such as TCP stream. TCP depends on the value of sk_wmem_alloc to implement various optimization for small packets stream such as TCP small queue and auto