search for: virtio_vsock_default_rx_buf_size

Displaying 20 results from an estimated 134 matches for "virtio_vsock_default_rx_buf_size".

[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
2019 Aug 01
2
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
...at 04:42:25PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2019 at 11:35:39AM +0200, Stefano Garzarella wrote: (...) > > > > The problem here is the compatibility. Before this series virtio-vsock > > and vhost-vsock modules had the RX buffer size hard-coded > > (VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE = 4K). So, if we send a buffer smaller > > of 4K, there might be issues. > > Shouldn't be if they are following the spec. If not let's fix > the broken parts. > > > > > Maybe it is the time to add add 'features' to virtio-vsock device. > > &gt...
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
2019 Aug 01
2
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
...at 04:42:25PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2019 at 11:35:39AM +0200, Stefano Garzarella wrote: (...) > > > > The problem here is the compatibility. Before this series virtio-vsock > > and vhost-vsock modules had the RX buffer size hard-coded > > (VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE = 4K). So, if we send a buffer smaller > > of 4K, there might be issues. > > Shouldn't be if they are following the spec. If not let's fix > the broken parts. > > > > > Maybe it is the time to add add 'features' to virtio-vsock device. > > &gt...
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
2019 Sep 01
3
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
...> > > > (...) > > > > > > > > > > > > > > > > The problem here is the compatibility. Before this series virtio-vsock > > > > > > and vhost-vsock modules had the RX buffer size hard-coded > > > > > > (VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE = 4K). So, if we send a buffer smaller > > > > > > of 4K, there might be issues. > > > > > > > > > > Shouldn't be if they are following the spec. If not let's fix > > > > > the broken parts. > > > > > > >...
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
2019 Sep 01
3
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
...> > > > (...) > > > > > > > > > > > > > > > > The problem here is the compatibility. Before this series virtio-vsock > > > > > > and vhost-vsock modules had the RX buffer size hard-coded > > > > > > (VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE = 4K). So, if we send a buffer smaller > > > > > > of 4K, there might be issues. > > > > > > > > > > Shouldn't be if they are following the spec. If not let's fix > > > > > the broken parts. > > > > > > >...
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
2019 Aug 01
2
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
...019 at 11:35:39AM +0200, Stefano Garzarella wrote: > > > > (...) > > > > > > > > > > The problem here is the compatibility. Before this series virtio-vsock > > > > and vhost-vsock modules had the RX buffer size hard-coded > > > > (VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE = 4K). So, if we send a buffer smaller > > > > of 4K, there might be issues. > > > > > > Shouldn't be if they are following the spec. If not let's fix > > > the broken parts. > > > > > > > > > > > Maybe it is the tim...
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
2019 Aug 01
2
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
...019 at 11:35:39AM +0200, Stefano Garzarella wrote: > > > > (...) > > > > > > > > > > The problem here is the compatibility. Before this series virtio-vsock > > > > and vhost-vsock modules had the RX buffer size hard-coded > > > > (VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE = 4K). So, if we send a buffer smaller > > > > of 4K, there might be issues. > > > > > > Shouldn't be if they are following the spec. If not let's fix > > > the broken parts. > > > > > > > > > > > Maybe it is the tim...
[PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed
2019 Apr 04
1
[PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed
Since now we are able to split packets, we can avoid limiting their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max packet size. Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- net/vmw_vsock/virtio_transport_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b...
[PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed
2019 Apr 05
2
[PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed
On Fri, Apr 05, 2019 at 09:24:47AM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > > Since now we are able to split packets, we can avoid limiting > > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > > Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max > > packet size. > > > > Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> > > --- > > net/vmw_vsock/virtio_transport_common.c | 4 ++-- > > 1 file changed, 2 insertions(+),...
[PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed
2019 Apr 05
2
[PATCH RFC 3/4] vsock/virtio: change the maximum packet size allowed
On Fri, Apr 05, 2019 at 09:24:47AM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 04, 2019 at 12:58:37PM +0200, Stefano Garzarella wrote: > > Since now we are able to split packets, we can avoid limiting > > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > > Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max > > packet size. > > > > Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> > > --- > > net/vmw_vsock/virtio_transport_common.c | 4 ++-- > > 1 file changed, 2 insertions(+),...
[PATCH v4 5/5] vsock/virtio: change the maximum packet size allowed
2019 Jul 17
2
[PATCH v4 5/5] vsock/virtio: change the maximum packet size allowed
On Wed, Jul 17, 2019 at 01:30:30PM +0200, Stefano Garzarella wrote: > Since now we are able to split packets, we can avoid limiting > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max > packet size. > > Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> OK so this is kind of like GSO where we are passing 64K packets to the vsock and then split at the low level. > --- > net/vmw_v...
[PATCH v4 5/5] vsock/virtio: change the maximum packet size allowed
2019 Jul 17
2
[PATCH v4 5/5] vsock/virtio: change the maximum packet size allowed
On Wed, Jul 17, 2019 at 01:30:30PM +0200, Stefano Garzarella wrote: > Since now we are able to split packets, we can avoid limiting > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max > packet size. > > Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> OK so this is kind of like GSO where we are passing 64K packets to the vsock and then split at the low level. > --- > net/vmw_v...
[PATCH v2 7/8] vsock/virtio: increase RX buffer size to 64 KiB
2019 May 13
2
[PATCH v2 7/8] vsock/virtio: increase RX buffer size to 64 KiB
...f 100644 > --- a/include/linux/virtio_vsock.h > +++ b/include/linux/virtio_vsock.h > @@ -10,7 +10,7 @@ > #define VIRTIO_VSOCK_DEFAULT_MIN_BUF_SIZE 128 > #define VIRTIO_VSOCK_DEFAULT_BUF_SIZE (1024 * 256) > #define VIRTIO_VSOCK_DEFAULT_MAX_BUF_SIZE (1024 * 256) > -#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 4) > +#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 64) > #define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL > #define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64) > We probably don't want such high order allocation. It's better to switch to use order 0 pages in...
[PATCH v2 7/8] vsock/virtio: increase RX buffer size to 64 KiB
2019 May 13
2
[PATCH v2 7/8] vsock/virtio: increase RX buffer size to 64 KiB
...f 100644 > --- a/include/linux/virtio_vsock.h > +++ b/include/linux/virtio_vsock.h > @@ -10,7 +10,7 @@ > #define VIRTIO_VSOCK_DEFAULT_MIN_BUF_SIZE 128 > #define VIRTIO_VSOCK_DEFAULT_BUF_SIZE (1024 * 256) > #define VIRTIO_VSOCK_DEFAULT_MAX_BUF_SIZE (1024 * 256) > -#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 4) > +#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 64) > #define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL > #define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64) > We probably don't want such high order allocation. It's better to switch to use order 0 pages in...
[PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable
2019 May 13
2
[PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable
...t; 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h > index 5a9d25be72df..b9f8c3d91f80 100644 > --- a/include/linux/virtio_vsock.h > +++ b/include/linux/virtio_vsock.h > @@ -13,6 +13,7 @@ > #define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 64) > #define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL > #define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64) > +#define VIRTIO_VSOCK_MIN_PKT_BUF_SIZE (1024 * 4) > > enum { > VSOCK_VQ_RX = 0, /* for host to guest data */ > diff --git a/net/vmw_vsock/virtio...
[PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable
2019 May 13
2
[PATCH v2 8/8] vsock/virtio: make the RX buffer size tunable
...t; 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h > index 5a9d25be72df..b9f8c3d91f80 100644 > --- a/include/linux/virtio_vsock.h > +++ b/include/linux/virtio_vsock.h > @@ -13,6 +13,7 @@ > #define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 64) > #define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL > #define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64) > +#define VIRTIO_VSOCK_MIN_PKT_BUF_SIZE (1024 * 4) > > enum { > VSOCK_VQ_RX = 0, /* for host to guest data */ > diff --git a/net/vmw_vsock/virtio...
[PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput
2019 Apr 04
15
[PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput
...se the throughput of virtio-vsock with slight changes: - patch 1/4: reduces the number of credit update messages sent to the transmitter - patch 2/4: allows the host to split packets on multiple buffers, in this way, we can remove the packet size limit to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE - patch 3/4: uses VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max packet size allowed - patch 4/4: increases RX buffer size to 64 KiB (affects only host->guest) RFC: - maybe patch 4 can be replaced with multiple queues with different buffer sizes or using EWMA to adapt the buffer s...
[PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput
2019 Apr 04
15
[PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput
...se the throughput of virtio-vsock with slight changes: - patch 1/4: reduces the number of credit update messages sent to the transmitter - patch 2/4: allows the host to split packets on multiple buffers, in this way, we can remove the packet size limit to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE - patch 3/4: uses VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max packet size allowed - patch 4/4: increases RX buffer size to 64 KiB (affects only host->guest) RFC: - maybe patch 4 can be replaced with multiple queues with different buffer sizes or using EWMA to adapt the buffer s...
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
2019 Sep 02
0
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
....) > > > > > > > > > > > > > > > > > > > The problem here is the compatibility. Before this series virtio-vsock > > > > > > > and vhost-vsock modules had the RX buffer size hard-coded > > > > > > > (VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE = 4K). So, if we send a buffer smaller > > > > > > > of 4K, there might be issues. > > > > > > > > > > > > Shouldn't be if they are following the spec. If not let's fix > > > > > > the broken parts. > > > &...
[PATCH RFC 4/4] vsock/virtio: increase RX buffer size to 64 KiB
2019 Apr 04
1
[PATCH RFC 4/4] vsock/virtio: increase RX buffer size to 64 KiB
...sock.h index 6d7a22cc20bf..43cce304408e 100644 --- a/include/linux/virtio_vsock.h +++ b/include/linux/virtio_vsock.h @@ -10,7 +10,7 @@ #define VIRTIO_VSOCK_DEFAULT_MIN_BUF_SIZE 128 #define VIRTIO_VSOCK_DEFAULT_BUF_SIZE (1024 * 256) #define VIRTIO_VSOCK_DEFAULT_MAX_BUF_SIZE (1024 * 256) -#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 4) +#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 64) #define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL #define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64) -- 2.20.1
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
2019 Aug 01
0
[PATCH v4 1/5] vsock/virtio: limit the memory used per-socket
...wrote: > > On Tue, Jul 30, 2019 at 11:35:39AM +0200, Stefano Garzarella wrote: > > (...) > > > > > > > The problem here is the compatibility. Before this series virtio-vsock > > > and vhost-vsock modules had the RX buffer size hard-coded > > > (VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE = 4K). So, if we send a buffer smaller > > > of 4K, there might be issues. > > > > Shouldn't be if they are following the spec. If not let's fix > > the broken parts. > > > > > > > > Maybe it is the time to add add 'features' to...