search for: virtio_vdpa

...ffinity without checking if the op is valid. This patch adds the check. Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading mechanism") Reviewed-by: Gal Pressman <gal at nvidia.com> Signed-off-by: Dragos Tatulea <dtatulea at nvidia.com> --- drivers/virtio/virtio_vdpa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index eb6aee8c06b2..989e2d7184ce 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_vdpa.c @@ -385,7 +385,9 @@ static int virtio_vdpa_find_vqs(stru...

...s > valid. This patch adds the check. > > Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading mechanism") > Reviewed-by: Gal Pressman <gal at nvidia.com> > Signed-off-by: Dragos Tatulea <dtatulea at nvidia.com> > --- > drivers/virtio/virtio_vdpa.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > index eb6aee8c06b2..989e2d7184ce 100644 > --- a/drivers/virtio/virtio_vdpa.c > +++ b/drivers/virtio/virtio_vdpa.c > @@ -385,7 +385,9 @@...

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 84d40e4b4bc64456abf5ef5663871053b40e84ac commit: 03750f7fa49f9384911059fe16f5367b7e86f99d [40/45] virtio_vdpa: legacy features handling config: nds32-randconfig-r003-20200728 (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross...

On 2020/7/13 ??6:20, Zhu, Lingshan wrote: > > > On 7/13/2020 4:28 PM, Jason Wang wrote: >> >> On 2020/7/12 ??10:49, Zhu Lingshan wrote: >>> This commit initialize IRQ offloading function pointers in >>> virtio_vdpa_driver to NULL. Becasue irq offloading only focus >>> on VMs for vhost_vdpa. >>> >>> Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> >>> --- >>> ? drivers/virtio/virtio_vdpa.c | 2 ++ >>> ? 1 file changed, 2 insertions(+) >>&g...

On 2020/7/12 ??10:49, Zhu Lingshan wrote: > This commit initialize IRQ offloading function pointers in > virtio_vdpa_driver to NULL. Becasue irq offloading only focus > on VMs for vhost_vdpa. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/virtio/virtio_vdpa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/virtio/virtio_vdpa.c b/driv...

We normally expect vdpa to use the modern interface. However for consistency, let's use same APIs as vhost for legacy guests. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_vdpa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index c30eb55030be..4a9ddb44b2a7 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_vdpa.c @@ -57,9 +57,8 @@ static void virtio_vdpa_get(stru...

...> > > > Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading > > mechanism") > > Reviewed-by: Gal Pressman <gal at nvidia.com> > > Signed-off-by: Dragos Tatulea <dtatulea at nvidia.com> > > --- > > ? drivers/virtio/virtio_vdpa.c | 4 +++- > > ? 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > > index eb6aee8c06b2..989e2d7184ce 100644 > > --- a/drivers/virtio/virtio_vdpa.c > > +++ b/drivers/virtio/virtio_vd...

...the check. > > > > Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading mechanism") > > Reviewed-by: Gal Pressman <gal at nvidia.com> > > Signed-off-by: Dragos Tatulea <dtatulea at nvidia.com> > > --- > > drivers/virtio/virtio_vdpa.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > > index eb6aee8c06b2..989e2d7184ce 100644 > > --- a/drivers/virtio/virtio_vdpa.c > > +++ b/drivers/virtio/virtio_vd...

...ich adds support for the MMIO, channel I/O and modern PCI transports. This patch needs to be applied on top of Viktor's patch. [1] https://lore.kernel.org/lkml/20230324195029.2410503-1-viktor at daynix.com/ Signed-off-by: Alvaro Karsz <alvaro.karsz at solid-run.com> --- drivers/virtio/virtio_vdpa.c | 20 ++++++++++++++++++-- include/linux/vdpa.h | 6 ++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index d7f5af62dda..bdaf30f7fbf 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_vdp...

...> Add eventfd for the vdpa callback so that user > can signal it directly instead of running the > callback. It will be used for vhost-vdpa case. > > Signed-off-by: Xie Yongji <xieyongji at bytedance.com> > --- > drivers/vhost/vdpa.c | 2 ++ > drivers/virtio/virtio_vdpa.c | 1 + > include/linux/vdpa.h | 3 +++ > 3 files changed, 6 insertions(+) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index dc12dbd5b43b..ae89c0ccc2bb 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -599,9 +599,11 @@ stati...

...tory for hardware vDPA to >> work. > Hmm I don't really see why. Assume host maps guest memory properly, > VM does not have an IOMMU, legacy guest can just work. Yes, guest may not set IOMMU_PLATFORM. > > Care explaining what's wrong with this picture? The problem is virtio_vdpa, without IOMMU_PLATFORM it uses PA which can not work if IOMMU is enabled. Thanks > > >> So it can only work for modern device ... >> >> Thanks >> >> >>> >>>

...tory for hardware vDPA to >> work. > Hmm I don't really see why. Assume host maps guest memory properly, > VM does not have an IOMMU, legacy guest can just work. Yes, guest may not set IOMMU_PLATFORM. > > Care explaining what's wrong with this picture? The problem is virtio_vdpa, without IOMMU_PLATFORM it uses PA which can not work if IOMMU is enabled. Thanks > > >> So it can only work for modern device ... >> >> Thanks >> >> >>> >>>

...t vdpa device driver can > get the interrupt affinity hint from the virtio > device driver. The interrupt affinity hint would > be needed by the interrupt affinity spreading > mechanism. > > Signed-off-by: Xie Yongji <xieyongji at bytedance.com> > --- > drivers/virtio/virtio_vdpa.c | 4 ++++ > include/linux/vdpa.h | 9 +++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > index f72696b4c1c2..9eee8afabda8 100644 > --- a/drivers/virtio/virtio_vdpa.c > +++ b/drivers/virtio/virti...

...ruct virtio_device *vdev) > > break; > > case VIRTIO_F_ORDER_PLATFORM: > > break; > > + case VIRTIO_F_NOTIFICATION_DATA: > > + break; > > This function is used by virtio_vdpa as well (drivers/virtio/virtio_vdpa.c:virtio_vdpa_finalize_features). > A vDPA device can offer this feature and it will be accepted, even though VIRTIO_F_NOTIFICATION_DATA is not a thing for the vDPA transport at the moment. > > I don't know if this is bad, since offering VIRTIO_F_NO...

...; [1] https://lore.kernel.org/lkml/20230324195029.2410503-1-viktor at daynix.com/ > > Signed-off-by: Alvaro Karsz <alvaro.karsz at solid-run.com> Hmm so I conclude that drivers without kick_vq_with_data should not accept VIRTIO_F_NOTIFICATION_DATA then? > --- > drivers/virtio/virtio_vdpa.c | 20 ++++++++++++++++++-- > include/linux/vdpa.h | 6 ++++++ > 2 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > index d7f5af62dda..bdaf30f7fbf 100644 > --- a/drivers/virtio/virtio_vdpa.c &...

...l I/O and modern PCI transports. > > This patch needs to be applied on top of Viktor's patch. > > [1] https://lore.kernel.org/lkml/20230324195029.2410503-1-viktor at daynix.com/ > > Signed-off-by: Alvaro Karsz <alvaro.karsz at solid-run.com> > --- > drivers/virtio/virtio_vdpa.c | 20 ++++++++++++++++++-- > include/linux/vdpa.h | 6 ++++++ > 2 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > index d7f5af62dda..bdaf30f7fbf 100644 > --- a/drivers/virtio/virtio_vdpa.c &g...

...viktor at daynix.com/ Signed-off-by: Alvaro Karsz <alvaro.karsz at solid-run.com> --- v2: - clear the feature bit if kick_vq_with_data is not implemented. - Fix kick_vq_with_data comment in include/linux/vdpa.h - Write in more detail about the extra data in the commit log drivers/virtio/virtio_vdpa.c | 23 +++++++++++++++++++++-- include/linux/vdpa.h | 9 +++++++++ 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index d7f5af62dda..737c1f36d32 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virt...

...ig ops. This means it is a software transport between vDPA driver and vDPA device. The transport was implemented through bus_ops of vDPA parent. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/virtio/Kconfig | 13 ++ drivers/virtio/Makefile | 1 + drivers/virtio/virtio_vdpa.c | 392 +++++++++++++++++++++++++++++++++++ 3 files changed, 406 insertions(+) create mode 100644 drivers/virtio/virtio_vdpa.c diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 9c4fdb64d9ac..0df3676b0f4f 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -43,6 +...

...ig ops. This means it is a software transport between vDPA driver and vDPA device. The transport was implemented through bus_ops of vDPA parent. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/virtio/Kconfig | 13 ++ drivers/virtio/Makefile | 1 + drivers/virtio/virtio_vdpa.c | 392 +++++++++++++++++++++++++++++++++++ 3 files changed, 406 insertions(+) create mode 100644 drivers/virtio/virtio_vdpa.c diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 9c4fdb64d9ac..0df3676b0f4f 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -43,6 +...

...@@ void vring_transport_features(struct virtio_device *vdev) > break; > case VIRTIO_F_ORDER_PLATFORM: > break; > + case VIRTIO_F_NOTIFICATION_DATA: > + break; This function is used by virtio_vdpa as well (drivers/virtio/virtio_vdpa.c:virtio_vdpa_finalize_features). A vDPA device can offer this feature and it will be accepted, even though VIRTIO_F_NOTIFICATION_DATA is not a thing for the vDPA transport at the moment. I don't know if this is bad, since offering VIRTIO_F_NOTIFICATION_DATA...