Displaying 6 results from an estimated 6 matches for "virtio_set_features_nocheck".
2014 Dec 12
1
[PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1
...set_features(VirtIODevice *vdev, uint64_t val)
> > > +static int __virtio_set_features(VirtIODevice *vdev, uint64_t val)
> >
> > Maybe avoid the double underscores here? But unfortunately, I also fail
> > to come up with a better suggestion for a name here ...
>
> virtio_set_features_nocheck()?
Sounds ok to me.
> This function is only called within virtio.c anyway...
Right, so the double underscores should be ok here, too. (I still do
not like them very much, but that's just my personal taste in this case)
> > > {
> > > BusState *qbus = qdev_get_paren...
2014 Dec 12
1
[PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1
...set_features(VirtIODevice *vdev, uint64_t val)
> > > +static int __virtio_set_features(VirtIODevice *vdev, uint64_t val)
> >
> > Maybe avoid the double underscores here? But unfortunately, I also fail
> > to come up with a better suggestion for a name here ...
>
> virtio_set_features_nocheck()?
Sounds ok to me.
> This function is only called within virtio.c anyway...
Right, so the double underscores should be ok here, too. (I still do
not like them very much, but that's just my personal taste in this case)
> > > {
> > > BusState *qbus = qdev_get_paren...
2014 Dec 12
2
[PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1
On Thu, 11 Dec 2014 14:25:14 +0100
Cornelia Huck <cornelia.huck at de.ibm.com> wrote:
> For virtio-1 devices, the driver must not attempt to set feature bits
> after it set FEATURES_OK in the device status. Simply reject it in
> that case.
>
> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com>
> ---
> hw/virtio/virtio.c | 16 ++++++++++++++--
2014 Dec 12
2
[PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1
On Thu, 11 Dec 2014 14:25:14 +0100
Cornelia Huck <cornelia.huck at de.ibm.com> wrote:
> For virtio-1 devices, the driver must not attempt to set feature bits
> after it set FEATURES_OK in the device status. Simply reject it in
> that case.
>
> Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com>
> ---
> hw/virtio/virtio.c | 16 ++++++++++++++--
2014 Dec 12
0
[PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1
...; >
> > -int virtio_set_features(VirtIODevice *vdev, uint64_t val)
> > +static int __virtio_set_features(VirtIODevice *vdev, uint64_t val)
>
> Maybe avoid the double underscores here? But unfortunately, I also fail
> to come up with a better suggestion for a name here ...
virtio_set_features_nocheck()?
This function is only called within virtio.c anyway...
>
> > {
> > BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
> > VirtioBusClass *vbusk = VIRTIO_BUS_GET_CLASS(qbus);
> > @@ -994,6 +994,18 @@ int virtio_set_features(VirtIODevice *vdev, uint64_t va...
2014 Dec 12
0
[PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1
...; >
> > -int virtio_set_features(VirtIODevice *vdev, uint64_t val)
> > +static int __virtio_set_features(VirtIODevice *vdev, uint64_t val)
>
> Maybe avoid the double underscores here? But unfortunately, I also fail
> to come up with a better suggestion for a name here ...
virtio_set_features_nocheck()?
This function is only called within virtio.c anyway...
>
> > {
> > BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
> > VirtioBusClass *vbusk = VIRTIO_BUS_GET_CLASS(qbus);
> > @@ -994,6 +994,18 @@ int virtio_set_features(VirtIODevice *vdev, uint64_t va...