search for: virtio_ring_no_legaci

On Fri, Dec 07, 2018 at 04:48:41PM +0800, Tiwei Bie wrote: > Introduce VIRTIO_RING_NO_LEGACY to support disabling legacy > macros and layout definitions. > > Suggested-by: Michael S. Tsirkin <mst at redhat.com> > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > VRING_AVAIL_ALIGN_SIZE, VRING_USED_ALIGN_SIZE and VRING_DESC_ALIGN_SIZE > are not pre-virtio

Introduce VIRTIO_RING_NO_LEGACY to support disabling legacy macros and layout definitions. Suggested-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- VRING_AVAIL_ALIGN_SIZE, VRING_USED_ALIGN_SIZE and VRING_DESC_ALIGN_SIZE are not pre-virtio 1.0, but can also be disabled by VIRTIO_RING_NO_LEGACY in this patch, because their names are not

On Tue, Sep 10, 2019 at 05:53:44PM +0000, Matej Genci wrote: > Add macro to disable legacy functions vring_init and vring_size. > > Signed-off-by: Matej Genci <matej.genci at nutanix.com> > --- > > V2: Put all legacy APIs inside guards. > > --- > include/uapi/linux/virtio_ring.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git

On Tue, Sep 10, 2019 at 05:53:44PM +0000, Matej Genci wrote: > Add macro to disable legacy functions vring_init and vring_size. > > Signed-off-by: Matej Genci <matej.genci at nutanix.com> And I guess we should be able to define this macro in drivers/virtio/virtio_pci_modern.c ? Will be handy to make sure we don't mask too much. > --- > > V2: Put all legacy APIs

From: Matej Genci <matej.genci at nutanix.com> Add macro to disable legacy vring functions. Signed-off-by: Matej Genci <matej.genci at nutanix.com> Link: https://lore.kernel.org/r/20190911124942.243713-1-matej.genci at nutanix.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 1 + include/uapi/linux/virtio_ring.h | 4 ++++ 2

From: Matej Genci <matej.genci at nutanix.com> Add macro to disable legacy vring functions. Signed-off-by: Matej Genci <matej.genci at nutanix.com> Link: https://lore.kernel.org/r/20190911124942.243713-1-matej.genci at nutanix.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 1 + include/uapi/linux/virtio_ring.h | 4 ++++ 2

From: Matej Genci <matej.genci at nutanix.com> Add macro to disable legacy vring functions. Signed-off-by: Matej Genci <matej.genci at nutanix.com> Link: https://lore.kernel.org/r/20190911124942.243713-1-matej.genci at nutanix.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 1 + include/uapi/linux/virtio_ring.h | 4 ++++ 2

From: Matej Genci <matej.genci at nutanix.com> Add macro to disable legacy vring functions. Signed-off-by: Matej Genci <matej.genci at nutanix.com> Link: https://lore.kernel.org/r/20190911124942.243713-1-matej.genci at nutanix.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 1 + include/uapi/linux/virtio_ring.h | 4 ++++ 2

From: Matej Genci <matej.genci at nutanix.com> Add macro to disable legacy vring functions. Signed-off-by: Matej Genci <matej.genci at nutanix.com> Link: https://lore.kernel.org/r/20190911124942.243713-1-matej.genci at nutanix.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 1 + include/uapi/linux/virtio_ring.h | 4 ++++ 2

From: Matej Genci <matej.genci at nutanix.com> Add macro to disable legacy vring functions. Signed-off-by: Matej Genci <matej.genci at nutanix.com> Link: https://lore.kernel.org/r/20190911124942.243713-1-matej.genci at nutanix.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 1 + include/uapi/linux/virtio_ring.h | 4 ++++ 2

On Fri, Sep 06, 2019 at 12:42:14PM +0000, Matej Genci wrote: > Add macro to disable legacy functions vring_init and vring_size. > > Signed-off-by: Matej Genci <matej.genci at nutanix.com> > --- > include/uapi/linux/virtio_ring.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h >

This is a follow up of the discussion in this thread: https://patchwork.ozlabs.org/patch/1001015/#2042353 Tiwei Bie (3): virtio_ring: define flags as shifts consistently virtio_ring: add VIRTIO_RING_NO_LEGACY virtio_ring: use new vring flags drivers/virtio/virtio_ring.c | 100 ++++++++++++++++++------------- include/uapi/linux/virtio_ring.h | 61 +++++++++++++------ 2 files changed,

This is a follow up of the discussion in this thread: https://patchwork.ozlabs.org/patch/1001015/#2042353 Tiwei Bie (3): virtio_ring: define flags as shifts consistently virtio_ring: add VIRTIO_RING_NO_LEGACY virtio_ring: use new vring flags drivers/virtio/virtio_ring.c | 100 ++++++++++++++++++------------- include/uapi/linux/virtio_ring.h | 61 +++++++++++++------ 2 files changed,

On Fri, Nov 30, 2018 at 10:53:07AM -0500, Michael S. Tsirkin wrote: > On Fri, Nov 30, 2018 at 11:37:37PM +0800, Tiwei Bie wrote: > > On Fri, Nov 30, 2018 at 08:52:42AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Nov 30, 2018 at 02:01:06PM +0100, Maxime Coquelin wrote: > > > > On 11/30/18 1:47 PM, Michael S. Tsirkin wrote: > > > > > On Fri, Nov 30,

On Fri, Nov 30, 2018 at 10:53:07AM -0500, Michael S. Tsirkin wrote: > On Fri, Nov 30, 2018 at 11:37:37PM +0800, Tiwei Bie wrote: > > On Fri, Nov 30, 2018 at 08:52:42AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Nov 30, 2018 at 02:01:06PM +0100, Maxime Coquelin wrote: > > > > On 11/30/18 1:47 PM, Michael S. Tsirkin wrote: > > > > > On Fri, Nov 30,

The ring element addresses are passed between components with different alignments assumptions. Thus, if guest/userspace selects a pointer and host then gets and dereferences it, we might need to decrease the compiler-selected alignment to prevent compiler on the host from assuming pointer is aligned. This actually triggers on ARM with -mabi=apcs-gnu - which is a deprecated configuration, but it

The ring element addresses are passed between components with different alignments assumptions. Thus, if guest/userspace selects a pointer and host then gets and dereferences it, we might need to decrease the compiler-selected alignment to prevent compiler on the host from assuming pointer is aligned. This actually triggers on ARM with -mabi=apcs-gnu - which is a deprecated configuration, but it

The ring element addresses are passed between components with different alignments assumptions. Thus, if guest/userspace selects a pointer and host then gets and dereferences it, we might need to decrease the compiler-selected alignment to prevent compiler on the host from assuming pointer is aligned. This actually triggers on ARM with -mabi=apcs-gnu - which is a deprecated configuration, but it

The ring element addresses are passed between components with different alignments assumptions. Thus, if guest/userspace selects a pointer and host then gets and dereferences it, we might need to decrease the compiler-selected alignment to prevent compiler on the host from assuming pointer is aligned. This actually triggers on ARM with -mabi=apcs-gnu - which is a deprecated configuration, but it

On Fri, Dec 07, 2018 at 04:48:39PM +0800, Tiwei Bie wrote: > This is a follow up of the discussion in this thread: > https://patchwork.ozlabs.org/patch/1001015/#2042353 How was this tested? I'd suggest building virtio before and after the changes, stripped binary should be exactly the same. > Tiwei Bie (3): > virtio_ring: define flags as shifts consistently > virtio_ring: