Displaying 12 results from an estimated 12 matches for "virtio_pci_set_host_notifier_intern".
Did you mean:
virtio_pci_set_host_notifier_internal
2015 Mar 11
4
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...debugging shows that the TX vring number (16-bit) is supposed to
> > be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
> > QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> > default.
> >
> > This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> > to negate the one that is done in adjust_endianness(). Since this is not
> > a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> > whether the guest is bi-endian or not.
> >
> > Reported-by: C?dric Le Goater <clg at fr.ibm.com>...
2015 Mar 11
4
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...debugging shows that the TX vring number (16-bit) is supposed to
> > be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
> > QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> > default.
> >
> > This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> > to negate the one that is done in adjust_endianness(). Since this is not
> > a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> > whether the guest is bi-endian or not.
> >
> > Reported-by: C?dric Le Goater <clg at fr.ibm.com>...
2015 Mar 11
2
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...e() returns false for all registered vrings
Extra debugging shows that the TX vring number (16-bit) is supposed to
be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
default.
This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
to negate the one that is done in adjust_endianness(). Since this is not
a hot path and we want to keep virtio-pci.o in common-obj, we don't care
whether the guest is bi-endian or not.
Reported-by: C?dric Le Goater <clg at fr.ibm.com>
Suggested-by: Michael Roth <mdroth at linux.vn...
2015 Mar 11
2
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...e() returns false for all registered vrings
Extra debugging shows that the TX vring number (16-bit) is supposed to
be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
default.
This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
to negate the one that is done in adjust_endianness(). Since this is not
a hot path and we want to keep virtio-pci.o in common-obj, we don't care
whether the guest is bi-endian or not.
Reported-by: C?dric Le Goater <clg at fr.ibm.com>
Suggested-by: Michael Roth <mdroth at linux.vn...
2015 Mar 11
1
[Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...; > > +}
But but but ... The above ... won't it do things like break x86 ? Ie,
shouldn't we swap only if TARGET_BIG_ENDIAN and !virtio_is_big_endian ?
Or better, "fixed target endian" ^ "virtio endian" to cover all cases ?
Cheers,
Ben.
> > > static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy,
> > > int n, bool assign, bool set_handler)
> > > {
> > > @@ -150,10 +155,12 @@ static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy,
> > > }
> > >...
2015 Mar 11
1
[Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...; > > +}
But but but ... The above ... won't it do things like break x86 ? Ie,
shouldn't we swap only if TARGET_BIG_ENDIAN and !virtio_is_big_endian ?
Or better, "fixed target endian" ^ "virtio endian" to cover all cases ?
Cheers,
Ben.
> > > static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy,
> > > int n, bool assign, bool set_handler)
> > > {
> > > @@ -150,10 +155,12 @@ static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy,
> > > }
> > >...
2015 Mar 11
0
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...d vrings
>
> Extra debugging shows that the TX vring number (16-bit) is supposed to
> be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
> QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> default.
>
> This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> to negate the one that is done in adjust_endianness(). Since this is not
> a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> whether the guest is bi-endian or not.
>
> Reported-by: C?dric Le Goater <clg at fr.ibm.com>
> Suggested-by: Micha...
2015 Mar 11
0
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...d vrings
>
> Extra debugging shows that the TX vring number (16-bit) is supposed to
> be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
> QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> default.
>
> This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> to negate the one that is done in adjust_endianness(). Since this is not
> a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> whether the guest is bi-endian or not.
>
> Reported-by: C?dric Le Goater <clg at fr.ibm.com>
> Suggested-by: Micha...
2015 Mar 12
0
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...TX vring number (16-bit) is supposed to
> > > be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
> > > QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> > > default.
> > >
> > > This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> > > to negate the one that is done in adjust_endianness(). Since this is not
> > > a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> > > whether the guest is bi-endian or not.
> > >
> > > Reported-by: C?dric Le Goater...
2015 Mar 12
0
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...TX vring number (16-bit) is supposed to
> > > be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
> > > QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> > > default.
> > >
> > > This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> > > to negate the one that is done in adjust_endianness(). Since this is not
> > > a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> > > whether the guest is bi-endian or not.
> > >
> > > Reported-by: C?dric Le Goater...
2015 Mar 11
0
[Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...pci.o being built per target, we can use virtio_default_endian()
instead (to be exported from virtio.c):
return vdev->device_endian() != virtio_default_endian() ? val : bswap16(val);
I shall test on x86 and post a v2.
Thanks.
--
G
> Cheers,
> Ben.
>
> > > > static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy,
> > > > int n, bool assign, bool set_handler)
> > > > {
> > > > @@ -150,10 +155,12 @@ static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy,
> > > >...
2015 Mar 11
0
[Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...pci.o being built per target, we can use virtio_default_endian()
instead (to be exported from virtio.c):
return vdev->device_endian() != virtio_default_endian() ? val : bswap16(val);
I shall test on x86 and post a v2.
Thanks.
--
G
> Cheers,
> Ben.
>
> > > > static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy,
> > > > int n, bool assign, bool set_handler)
> > > > {
> > > > @@ -150,10 +155,12 @@ static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy,
> > > >...