search for: virtio_pci_device_plug

On Mon, 13 Apr 2015 13:26:31 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote: > > Also, doesn't get_features need to be modified as well so that > > VERSION_1 is advertised? > > virtio_pci_device_plugged seems to set it ATM. I'll re-test to confirm. Indeed, pci sets it, but ccw does not. And virtio-net, for example, sets it explicitly as well. We need to unify this :)

On Mon, 13 Apr 2015 13:26:31 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote: > > Also, doesn't get_features need to be modified as well so that > > VERSION_1 is advertised? > > virtio_pci_device_plugged seems to set it ATM. I'll re-test to confirm. Indeed, pci sets it, but ccw does not. And virtio-net, for example, sets it explicitly as well. We need to unify this :)

On Mon, Mar 20, 2017 at 05:21:22PM +0200, Marcel Apfelbaum wrote: > On 03/17/2017 11:57 PM, James Hogan wrote: > > Hi, > > > > I've bisected the following failure of the virtio_net linux v4.10 driver > > to probe in QEMU v2.9.0-rc1 emulating a MIPS Malta machine: > > > > virtio_net virtio0: virtio: device uses modern interface but does not have

On Mon, Mar 20, 2017 at 05:21:22PM +0200, Marcel Apfelbaum wrote: > On 03/17/2017 11:57 PM, James Hogan wrote: > > Hi, > > > > I've bisected the following failure of the virtio_net linux v4.10 driver > > to probe in QEMU v2.9.0-rc1 emulating a MIPS Malta machine: > > > > virtio_net virtio0: virtio: device uses modern interface but does not have

On Sun, 12 Apr 2015 17:00:48 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > Virtio 1.0 doesn't include a modern balloon device. At some point we'll > likely define an incompatible interface with a different ID and > different semantics. But for now, it's not a big effort to support a > transitional balloon device: this has the advantage of

On Sun, 12 Apr 2015 17:00:48 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > Virtio 1.0 doesn't include a modern balloon device. At some point we'll > likely define an incompatible interface with a different ID and > different semantics. But for now, it's not a big effort to support a > transitional balloon device: this has the advantage of

...00 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote: > > > > Also, doesn't get_features need to be modified as well so that > > > VERSION_1 is advertised? > > > > virtio_pci_device_plugged seems to set it ATM. I'll re-test to confirm. > > Indeed, pci sets it, but ccw does not. And virtio-net, for example, > sets it explicitly as well. We need to unify this :) I'm inclined to set it in transport and black-list in specific devices. -- MST

...e is. > Hi James, Can you please check if the below patch fixes the problem? Please note it is not a solution. diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index f9b7244..5b4d429 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1671,9 +1671,7 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp) } pci_register_bar(&proxy->pci_dev, proxy->modern_mem_bar_idx, - PCI_BASE_ADDRESS_SPACE_MEMORY | - PCI_BASE_ADDRESS_MEM_PREFETCH | - PCI_BASE_ADDRESS_MEM_TYPE_64,...

...you wouldn't need the above change at all, > would you? I think so, yes. BTW I suspect the stats code is broken for cross-endian platforms: it should do LE unconditinally, should it not? > Also, doesn't get_features need to be modified as well so that > VERSION_1 is advertised? virtio_pci_device_plugged seems to set it ATM. I'll re-test to confirm. -- MST

--- drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 32 ++++++++++++++++++++++++++++++-- drivers/virtio/virtio_pci_common.c | 7 ++++++- 2 files changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c index 56bd4ed..33d12d5 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c +++

--- drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 32 ++++++++++++++++++++++++++++++-- drivers/virtio/virtio_pci_common.c | 7 ++++++- 2 files changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c index 56bd4ed..33d12d5 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c +++

...gth = size; + + return cap; +} + +static void virtio_pci_cap_del(VirtIOPCIProxy *proxy, MemoryRegion *reg) +{ + memory_region_del_subregion(&proxy->config_bar, reg); + memory_region_destroy(reg); +} + /* This is called by virtio-bus just after the device is plugged. */ static void virtio_pci_device_plugged(DeviceState *d) { VirtIOPCIProxy *proxy = VIRTIO_PCI(d); VirtioBusState *bus = &proxy->bus; + struct virtio_pci_notify_cap *notify_cap; uint8_t *config; uint32_t size; @@ -986,6 +1291,59 @@ static void virtio_pci_device_plugged(DeviceState *d) pci_register_b...

...gth = size; + + return cap; +} + +static void virtio_pci_cap_del(VirtIOPCIProxy *proxy, MemoryRegion *reg) +{ + memory_region_del_subregion(&proxy->config_bar, reg); + memory_region_destroy(reg); +} + /* This is called by virtio-bus just after the device is plugged. */ static void virtio_pci_device_plugged(DeviceState *d) { VirtIOPCIProxy *proxy = VIRTIO_PCI(d); VirtioBusState *bus = &proxy->bus; + struct virtio_pci_notify_cap *notify_cap; uint8_t *config; uint32_t size; @@ -986,6 +1291,59 @@ static void virtio_pci_device_plugged(DeviceState *d) pci_register_b...

...+static void virtio_pci_cap_del(VirtIOPCIProxy *proxy, MemoryRegion *reg) > +{ > + memory_region_del_subregion(&proxy->config_bar, reg); > + memory_region_destroy(reg); > +} > + > /* This is called by virtio-bus just after the device is plugged. */ > static void virtio_pci_device_plugged(DeviceState *d) > { > VirtIOPCIProxy *proxy = VIRTIO_PCI(d); > VirtioBusState *bus = &proxy->bus; > + struct virtio_pci_notify_cap *notify_cap; > uint8_t *config; > uint32_t size; > > @@ -986,6 +1291,59 @@ static void virtio_pci_device_plu...

...dev_features(&proxy->bus, proxy->host_features); } diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index dde1d73..e7969bf 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -996,8 +996,8 @@ static void virtio_pci_device_plugged(DeviceState *d) proxy->flags &= ~VIRTIO_PCI_FLAG_USE_IOEVENTFD; } - proxy->host_features |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY; - proxy->host_features |= 0x1 << VIRTIO_F_BAD_FEATURE; + virtio_add_feature(&proxy->host_features, VIRTIO_F_NOTIFY...

...dev_features(&proxy->bus, proxy->host_features); } diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index dde1d73..e7969bf 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -996,8 +996,8 @@ static void virtio_pci_device_plugged(DeviceState *d) proxy->flags &= ~VIRTIO_PCI_FLAG_USE_IOEVENTFD; } - proxy->host_features |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY; - proxy->host_features |= 0x1 << VIRTIO_F_BAD_FEATURE; + virtio_add_feature(&proxy->host_features, VIRTIO_F_NOTIFY...

...et_features(DeviceState *d, unsigned int index) { VirtIOPCIProxy *proxy = to_virtio_pci_proxy(d); - return proxy->host_features; + + return index == 0 ? proxy->host_features : 0; } static int kvm_virtio_pci_vq_vector_use(VirtIOPCIProxy *proxy, @@ -1006,7 +1007,7 @@ static void virtio_pci_device_plugged(DeviceState *d) proxy->host_features |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY; proxy->host_features |= 0x1 << VIRTIO_F_BAD_FEATURE; - proxy->host_features = virtio_bus_get_vdev_features(bus, + proxy->host_features = virtio_bus_get_vdev_features(bus, 0,...

...et_features(DeviceState *d, unsigned int index) { VirtIOPCIProxy *proxy = to_virtio_pci_proxy(d); - return proxy->host_features; + + return index == 0 ? proxy->host_features : 0; } static int kvm_virtio_pci_vq_vector_use(VirtIOPCIProxy *proxy, @@ -1006,7 +1007,7 @@ static void virtio_pci_device_plugged(DeviceState *d) proxy->host_features |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY; proxy->host_features |= 0x1 << VIRTIO_F_BAD_FEATURE; - proxy->host_features = virtio_bus_get_vdev_features(bus, + proxy->host_features = virtio_bus_get_vdev_features(bus, 0,...

..._get_features(DeviceState *d, unsigned int index) { VirtIOPCIProxy *proxy = to_virtio_pci_proxy(d); - return proxy->host_features; + + return index == 0 ? proxy->host_features : 0; } static int kvm_virtio_pci_vq_vector_use(VirtIOPCIProxy *proxy, @@ -998,7 +999,7 @@ static void virtio_pci_device_plugged(DeviceState *d) proxy->host_features |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY; proxy->host_features |= 0x1 << VIRTIO_F_BAD_FEATURE; - proxy->host_features = virtio_bus_get_vdev_features(bus, + proxy->host_features = virtio_bus_get_vdev_features(bus, 0,...

..._get_features(DeviceState *d, unsigned int index) { VirtIOPCIProxy *proxy = to_virtio_pci_proxy(d); - return proxy->host_features; + + return index == 0 ? proxy->host_features : 0; } static int kvm_virtio_pci_vq_vector_use(VirtIOPCIProxy *proxy, @@ -998,7 +999,7 @@ static void virtio_pci_device_plugged(DeviceState *d) proxy->host_features |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY; proxy->host_features |= 0x1 << VIRTIO_F_BAD_FEATURE; - proxy->host_features = virtio_bus_get_vdev_features(bus, + proxy->host_features = virtio_bus_get_vdev_features(bus, 0,...