Displaying 15 results from an estimated 15 matches for "virtio_net_hdr_v1_hash".
2023 Aug 16
1
[PATCH net v1] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
..._buffers; /* Number of merged rx buffers */
>>>>> };
>>>>> +
>>>>> +struct virtio_net_common_hdr {
>>>>> + union {
>>>>> + struct virtio_net_hdr_mrg_rxbuf mrg_hdr;
>>>>> + struct virtio_net_hdr_v1_hash hash_v1_hdr;
>>>>> + };
>>>>> +};
>>>>
>>>> Does this belong in the UAPI?
>>>> I would have assumed it's a Kernel implementation detail.
>>>>
>>> The existing codes, virtio_net.h is in uapi/linux/, I adde...
2023 Aug 15
1
[PATCH net v1] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
...Paolo Abeni <pabeni at redhat.com>
> > >
> > Thanks for adding David S. Miller.
> >
> > > > The virtio_net driver currently deals with different versions and types
> > > > of virtio net headers, such as virtio_net_hdr_mrg_rxbuf,
> > > > virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies
> > > > on multiple type casts to convert memory between different structures,
> > > > potentially leading to bugs when there are changes in these structures.
> > > >
> > > > Introduces the "struct s...
2023 Aug 15
1
[PATCH net v1] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
...Paolo Abeni <pabeni at redhat.com>
> > >
> > Thanks for adding David S. Miller.
> >
> > > > The virtio_net driver currently deals with different versions and types
> > > > of virtio net headers, such as virtio_net_hdr_mrg_rxbuf,
> > > > virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies
> > > > on multiple type casts to convert memory between different structures,
> > > > potentially leading to bugs when there are changes in these structures.
> > > >
> > > > Introduces the "struct s...
2023 Aug 21
3
[PATCH net-next v3] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
The virtio_net driver currently deals with different versions and types
of virtio net headers, such as virtio_net_hdr_mrg_rxbuf,
virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies
on multiple type casts to convert memory between different structures,
potentially leading to bugs when there are changes in these structures.
Introduces the "struct skb_vnet_common_hdr" as a unifying header
structure using a union. With thi...
2023 Aug 17
1
[PATCH net-next v2] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
...Use caution opening links or attachments
>
>
> On Thu, Aug 17, 2023 at 11:20?AM Feng Liu <feliu at nvidia.com> wrote:
>>
>> The virtio_net driver currently deals with different versions and types
>> of virtio net headers, such as virtio_net_hdr_mrg_rxbuf,
>> virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies
>> on multiple type casts to convert memory between different structures,
>> potentially leading to bugs when there are changes in these structures.
>>
>> Introduces the "struct skb_vnet_common_hdr" as a unifying heade...
2023 Aug 17
1
[PATCH net-next v2] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
...chments
> >
> >
> > On Thu, Aug 17, 2023 at 11:20?AM Feng Liu <feliu at nvidia.com> wrote:
> >>
> >> The virtio_net driver currently deals with different versions and types
> >> of virtio net headers, such as virtio_net_hdr_mrg_rxbuf,
> >> virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies
> >> on multiple type casts to convert memory between different structures,
> >> potentially leading to bugs when there are changes in these structures.
> >>
> >> Introduces the "struct skb_vnet_common_hdr"...
2023 Aug 17
1
[PATCH net-next v2] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
On Thu, Aug 17, 2023 at 11:20?AM Feng Liu <feliu at nvidia.com> wrote:
>
> The virtio_net driver currently deals with different versions and types
> of virtio net headers, such as virtio_net_hdr_mrg_rxbuf,
> virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies
> on multiple type casts to convert memory between different structures,
> potentially leading to bugs when there are changes in these structures.
>
> Introduces the "struct skb_vnet_common_hdr" as a unifying header
> structure...
2023 Aug 17
1
[PATCH net-next v2] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
The virtio_net driver currently deals with different versions and types
of virtio net headers, such as virtio_net_hdr_mrg_rxbuf,
virtio_net_hdr_v1_hash, etc. Due to these variations, the code relies
on multiple type casts to convert memory between different structures,
potentially leading to bugs when there are changes in these structures.
Introduces the "struct skb_vnet_common_hdr" as a unifying header
structure using a union. With thi...
2023 Aug 16
1
[PATCH net v1] virtio_net: Introduce skb_vnet_common_hdr to avoid typecasting
...the
> > benefit to the implementation.
> >
> > [1] https://patches.linaro.org/project/netdev/patch/20210208185558.995292-3-willemdebruijn.kernel at gmail.com/
> Hi, William and Simon
>
> Thanks for the detailed explanation.
>
> I kept virtio_net_hdr_mrg_rxbuf and virtio_net_hdr_v1_hash structures in
> virtio_net.h, which can be forward compatible with existing user
> applications which use these structures.
They're UAPI, so we cannot modify or remove them anyway.
Which is exactly why we want to be careful with adding anything new.
> virtio_net_hdr_v1_hash canno...
2020 Mar 01
0
[PATCH 3/3] virtio-net: Introduce hash report feature
...g */
> #define VIRTIO_NET_F_RSC_EXT 61 /* extended coalescing info */
> #define VIRTIO_NET_F_STANDBY 62 /* Act as standby for another device
> @@ -144,6 +145,23 @@ struct virtio_net_hdr_v1 {
> __virtio16 num_buffers; /* Number of merged rx buffers */
> };
>
> +struct virtio_net_hdr_v1_hash {
> + struct virtio_net_hdr_v1 hdr;
> + __virtio32 hash_value;
> +#define VIRTIO_NET_HASH_REPORT_NONE 0
> +#define VIRTIO_NET_HASH_REPORT_IPv4 1
> +#define VIRTIO_NET_HASH_REPORT_TCPv4 2
> +#define VIRTIO_NET_HASH_REPORT_UDPv4 3
> +#def...
2020 Mar 02
3
[PATCH v4 0/3] virtio-net: introduce features defined in the spec
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Changes from v3: reformatted structure in patch 1
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive steering feature
virtio-net: Introduce hash report feature
include/uapi/linux/virtio_net.h | 102 ++++++++++++++++++++++++++++++--
2020 Mar 01
6
[PATCH v2 0/3] virtio-net: introduce features defined in the spec
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Changes from v1:
__virtio -> __le
maximal -> maximum
minor style fixes
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive steering feature
virtio-net: Introduce hash report feature
include/uapi/linux/virtio_net.h | 90
2020 Mar 01
6
[PATCH v2 0/3] virtio-net: introduce features defined in the spec
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Changes from v1:
__virtio -> __le
maximal -> maximum
minor style fixes
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive steering feature
virtio-net: Introduce hash report feature
include/uapi/linux/virtio_net.h | 90
2020 Mar 01
7
[PATCH v3 0/3] virtio-net: introduce features defined in the spec
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Changes from v2: reformatted structure in patch 1
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive steering feature
virtio-net: Introduce hash report feature
include/uapi/linux/virtio_net.h | 100 ++++++++++++++++++++++++++++++--
2020 Mar 01
7
[PATCH v3 0/3] virtio-net: introduce features defined in the spec
This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
Changes from v2: reformatted structure in patch 1
Yuri Benditovich (3):
virtio-net: Introduce extended RSC feature
virtio-net: Introduce RSS receive steering feature
virtio-net: Introduce hash report feature
include/uapi/linux/virtio_net.h | 100 ++++++++++++++++++++++++++++++--