search for: virtio_net_hdr_gso_ecn

Hi, This patches introduce virtio_net_hdr_{from,to}_skb functions for conversion of GSO information between skb and virtio_net_hdr. Mike Rapoport (6): virtio_net: add _UAPI prefix to virtio_net header guards virtio_net: introduce virtio_net_hdr_{from,to}_skb macvtap: use common code for virtio_net_hdr and skb GSO conversion tuntap: use common code for virtio_net_hdr and skb GSO

Hi, This patches introduce virtio_net_hdr_{from,to}_skb functions for conversion of GSO information between skb and virtio_net_hdr. Mike Rapoport (6): virtio_net: add _UAPI prefix to virtio_net header guards virtio_net: introduce virtio_net_hdr_{from,to}_skb macvtap: use common code for virtio_net_hdr and skb GSO conversion tuntap: use common code for virtio_net_hdr and skb GSO

1) Turn GSO on virtio net into an all-or-nothing (keep checksumming separate). Having multiple bits is a pain: if you can't support something you should handle it in software, which is still a performance win. 2) Make VIRTIO_NET_HDR_GSO_ECN a flag in the header, so it can apply to IPv6 or v4. 3) Rename VIRTIO_NET_F_NO_CSUM to VIRTIO_NET_F_CSUM (ie. means we do checksumming). 4) Add csum and gso params to virtio_net to allow more testing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- drivers/net/virtio_net.c...

1) Turn GSO on virtio net into an all-or-nothing (keep checksumming separate). Having multiple bits is a pain: if you can't support something you should handle it in software, which is still a performance win. 2) Make VIRTIO_NET_HDR_GSO_ECN a flag in the header, so it can apply to IPv6 or v4. 3) Rename VIRTIO_NET_F_NO_CSUM to VIRTIO_NET_F_CSUM (ie. means we do checksumming). 4) Add csum and gso params to virtio_net to allow more testing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- drivers/net/virtio_net.c...

...ype & SKB_GSO_TCPV6) hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; - else - return -EINVAL; + else { + if (skb->data_len == 0) + hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; + else + return -EINVAL; + } if (sinfo->gso_type & SKB_GSO_TCP_ECN) hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; } else -- 2.20.1

...??? hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; > > > > +??????????? else > > > > +??????????????? return -EINVAL; > > > > +??????? } > > > > ????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) > > > > ????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > > > > ????? } else > > > > > > > > > > ping. > > > > > > > Do you mean gso_size is set but gso_type is not? Looks like a bug > > elsewhere. > > > > Thanks > > > > > Yes. > > I could not...

...??? hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; > > > > +??????????? else > > > > +??????????????? return -EINVAL; > > > > +??????? } > > > > ????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) > > > > ????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > > > > ????? } else > > > > > > > > > > ping. > > > > > > > Do you mean gso_size is set but gso_type is not? Looks like a bug > > elsewhere. > > > > Thanks > > > > > Yes. > > I could not...

...????? if (skb->data_len == 0) >> +??????????????? hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; >> +??????????? else >> +??????????????? return -EINVAL; >> +??????? } >> ????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) >> ????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; >> ????? } else >> > > ping. > Do you mean gso_size is set but gso_type is not? Looks like a bug elsewhere. Thanks

...????? if (skb->data_len == 0) >> +??????????????? hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; >> +??????????? else >> +??????????????? return -EINVAL; >> +??????? } >> ????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) >> ????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; >> ????? } else >> > > ping. > Do you mean gso_size is set but gso_type is not? Looks like a bug elsewhere. Thanks

...> > > > > +??????????? else > > > > > > +??????????????? return -EINVAL; > > > > > > +??????? } > > > > > > ????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) > > > > > > ????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > > > > > > ????? } else > > > > > > > > > > > > > > > > ping. > > > > > > > > > > > > > Do you mean gso_size is set but gso_type is not? Looks like a bug > > > > elsewhere. &g...

...> > > > > +??????????? else > > > > > > +??????????????? return -EINVAL; > > > > > > +??????? } > > > > > > ????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) > > > > > > ????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > > > > > > ????? } else > > > > > > > > > > > > > > > > ping. > > > > > > > > > > > > > Do you mean gso_size is set but gso_type is not? Looks like a bug > > > > elsewhere. &g...

...they set this only in the event > vnet header has been used with a GSO type. In this case, the user > already knows the the type. Imagine you are receiving a packet: if (vnet_hdr.gso_type != VIRTIO_NET_HDR_GSO_NONE) { switch (vnet_hdr.gso_type & ~VIRTIO_NET_HDR_GSO_ECN) { case VIRTIO_NET_HDR_GSO_TCPV4: gso_type = SKB_GSO_TCPV4; break; case VIRTIO_NET_HDR_GSO_TCPV6: gso_type = SKB_GSO_TCPV6;...

...they set this only in the event > vnet header has been used with a GSO type. In this case, the user > already knows the the type. Imagine you are receiving a packet: if (vnet_hdr.gso_type != VIRTIO_NET_HDR_GSO_NONE) { switch (vnet_hdr.gso_type & ~VIRTIO_NET_HDR_GSO_ECN) { case VIRTIO_NET_HDR_GSO_TCPV4: gso_type = SKB_GSO_TCPV4; break; case VIRTIO_NET_HDR_GSO_TCPV6: gso_type = SKB_GSO_TCPV6;...

...;>> +??????????? else > >>>>>>> +??????????????? return -EINVAL; > >>>>>>> +??????? } > >>>>>>> ????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) > >>>>>>> ????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > >>>>>>> ????? } else > >>>>>>> > >>>>>> > >>>>>> ping. > >>>>>> > >>>>> > >>>>> Do you mean gso_size is set but gso_type is not? Looks like a bug &g...

...;>> +??????????? else > >>>>>>> +??????????????? return -EINVAL; > >>>>>>> +??????? } > >>>>>>> ????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) > >>>>>>> ????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > >>>>>>> ????? } else > >>>>>>> > >>>>>> > >>>>>> ping. > >>>>>> > >>>>> > >>>>> Do you mean gso_size is set but gso_type is not? Looks like a bug &g...

...IO_NET_HDR_GSO_NONE; >>>>>> +??????????? else >>>>>> +??????????????? return -EINVAL; >>>>>> +??????? } >>>>>> ?????????? if (sinfo->gso_type & SKB_GSO_TCP_ECN) >>>>>> ?????????????? hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; >>>>>> ?????? } else >>>>>> >>>>> >>>>> ping. >>>>> >>>> >>>> Do you mean gso_size is set but gso_type is not? Looks like a bug >>>> elsewhere. >>>> >>>> Tha...

Hi: Here are the patches I used for testing KVM with virtio-net using TSO. There are three patches for the tun device which are basically Rusty's patches with the mmap turned into copying (for correctness). Two patches are for the virtio-net frontend, one required to support receiving SG/TSO, and the other useful for testing SG per se. The other patch is to the KVM backend to make all this

Hi: Here are the patches I used for testing KVM with virtio-net using TSO. There are three patches for the tun device which are basically Rusty's patches with the mmap turned into copying (for correctness). Two patches are for the virtio-net frontend, one required to support receiving SG/TSO, and the other useful for testing SG per se. The other patch is to the KVM backend to make all this

...ude <linux/virtio_ids.h> #include <linux/virtio_config.h> +#include <linux/virtio_types.h> #include <linux/if_ether.h> /* The feature bitmap for virtio net */ @@ -84,17 +85,17 @@ struct virtio_net_hdr { #define VIRTIO_NET_HDR_GSO_TCPV6 4 // GSO frame, IPv6 TCP #define VIRTIO_NET_HDR_GSO_ECN 0x80 // TCP has ECN set __u8 gso_type; - __u16 hdr_len; /* Ethernet + IP + tcp/udp hdrs */ - __u16 gso_size; /* Bytes to append to hdr_len per frame */ - __u16 csum_start; /* Position to start checksumming from */ - __u16 csum_offset; /* Offset after that to place checksum */ + __virtio16 hdr_...

...ude <linux/virtio_ids.h> #include <linux/virtio_config.h> +#include <linux/virtio_types.h> #include <linux/if_ether.h> /* The feature bitmap for virtio net */ @@ -84,17 +85,17 @@ struct virtio_net_hdr { #define VIRTIO_NET_HDR_GSO_TCPV6 4 // GSO frame, IPv6 TCP #define VIRTIO_NET_HDR_GSO_ECN 0x80 // TCP has ECN set __u8 gso_type; - __u16 hdr_len; /* Ethernet + IP + tcp/udp hdrs */ - __u16 gso_size; /* Bytes to append to hdr_len per frame */ - __u16 csum_start; /* Position to start checksumming from */ - __u16 csum_offset; /* Offset after that to place checksum */ + __virtio16 hdr_...