search for: virtio_net_f_ctrl_guest_offload

The only way for guest to control offloads (as enabled by VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands through CTRL_VQ. So it does not make sense to acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without VIRTIO_NET_F_CTRL_VQ. The spec does not outlaw devices with such a configuration, so we have to support it. Simply clear VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. Note that Linux is...

The only way for guest to control offloads (as enabled by VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands through CTRL_VQ. So it does not make sense to acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without VIRTIO_NET_F_CTRL_VQ. The spec does not outlaw devices with such a configuration, so we have to support it. Simply clear VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. Note that Linux is...

On Mon, Jan 06, 2020 at 10:47:35AM +0800, Jason Wang wrote: > > On 2020/1/5 ??9:22, Michael S. Tsirkin wrote: > > The only way for guest to control offloads (as enabled by > > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands > > through CTRL_VQ. So it does not make sense to > > acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without > > VIRTIO_NET_F_CTRL_VQ. > > > > The spec does not outlaw devices with such a configuration, so we have > > to support it. Simply...

On Mon, Jan 06, 2020 at 10:47:35AM +0800, Jason Wang wrote: > > On 2020/1/5 ??9:22, Michael S. Tsirkin wrote: > > The only way for guest to control offloads (as enabled by > > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands > > through CTRL_VQ. So it does not make sense to > > acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without > > VIRTIO_NET_F_CTRL_VQ. > > > > The spec does not outlaw devices with such a configuration, so we have > > to support it. Simply...

...n Wang wrote: > > On 2020/1/6 ??8:54, Michael S. Tsirkin wrote: > > On Mon, Jan 06, 2020 at 10:47:35AM +0800, Jason Wang wrote: > > > On 2020/1/5 ??9:22, Michael S. Tsirkin wrote: > > > > The only way for guest to control offloads (as enabled by > > > > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands > > > > through CTRL_VQ. So it does not make sense to > > > > acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without > > > > VIRTIO_NET_F_CTRL_VQ. > > > > > > > > The spec does not outlaw devices with such a configu...

...gt; > > > > > > > > > Instead of checking for this in virtnet_set_features, how about we > > > > > > make configurability contingent on cvq in virtnet_probe: > > > > > > > > > > > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS)) > > > > > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) && > > > > > > + virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > > > > > > dev->hw_features |= NETIF_F_LRO; > > &g...

...return 0; > > > > > + > > > > > > > > Instead of checking for this in virtnet_set_features, how about we > > > > make configurability contingent on cvq in virtnet_probe: > > > > > > > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS)) > > > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) && > > > > + virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > > > > dev->hw_features |= NETIF_F_LRO; > > > > > > > > Ba...

...return 0; > > > > > + > > > > > > > > Instead of checking for this in virtnet_set_features, how about we > > > > make configurability contingent on cvq in virtnet_probe: > > > > > > > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS)) > > > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) && > > > > + virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > > > > dev->hw_features |= NETIF_F_LRO; > > > > > > > > Ba...

On Fri, Feb 24, 2023 at 3:38 AM Rob Bradford via B4 Relay <devnull+rbradford.rivosinc.com at kernel.org> wrote: > > From: Rob Bradford <rbradford at rivosinc.com> > > kvmtool does not support the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS feature > but does advertise the VIRTIO_NET_F_GUEST_TSO{4,6} features. Check that > the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS feature is present before setting > the NETIF_F_GRO_HW feature bit as otherwise an attempt will be made to > program the virtio-net device using the ctrl queue which...

On Thu, Feb 23, 2023 at 07:38:25PM +0000, Rob Bradford via B4 Relay wrote: > From: Rob Bradford <rbradford at rivosinc.com> > > kvmtool does not support the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS feature > but does advertise the VIRTIO_NET_F_GUEST_TSO{4,6} features. Check that > the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS feature is present before setting > the NETIF_F_GRO_HW feature bit as otherwise an attempt will be made to > program the virtio-net device using the ctrl queue which...

From: Dmitry Fleytman <dfleytma at redhat.com> V4 changes: 1. Feature definitions re-used for command bitmask 2. Command data made uint64 3. Commit messsages fixed Reported-by: Rusty Russell rusty at rustcorp.com.au V3 changes: 1. Compat macro added 2. Feature name beautification V2 changes: 1. _GUEST_ added to command and feature names 2. Live migration logic fixed

From: Dmitry Fleytman <dfleytma at redhat.com> V4 changes: 1. Feature definitions re-used for command bitmask 2. Command data made uint64 3. Commit messsages fixed Reported-by: Rusty Russell rusty at rustcorp.com.au V3 changes: 1. Compat macro added 2. Feature name beautification V2 changes: 1. _GUEST_ added to command and feature names 2. Live migration logic fixed

...AM +0800, xiangxia.m.yue at gmail.com wrote: > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Jason Wang <jasowang at redhat.com> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com> > --- > drivers/net/virtio_net.c | 40 ++++++++++++++++++++++++++++------------ > 1 file changed, 28 inser...

...AM +0800, xiangxia.m.yue at gmail.com wrote: > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Jason Wang <jasowang at redhat.com> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com> > --- > drivers/net/virtio_net.c | 40 ++++++++++++++++++++++++++++------------ > 1 file changed, 28 inser...

On 2020/1/5 ??9:22, Michael S. Tsirkin wrote: > The only way for guest to control offloads (as enabled by > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands > through CTRL_VQ. So it does not make sense to > acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without > VIRTIO_NET_F_CTRL_VQ. > > The spec does not outlaw devices with such a configuration, so we have > to support it. Simply clear VIRTIO_NET_F_CTRL_GUEST_...

00fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > ? preempt_count_add+0x58/0xb0 > > ? _raw_spin_lock_irqsave+0x36/0x70 > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > ? __wake_up+0x70/0x190 > > virtnet_set_features+0x90/0xf0 [virtio_net] > > __netdev_update_features+0x271/0x980 > > ? nlmsg_notify+0x5b/0xa0 > >

00fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > ? preempt_count_add+0x58/0xb0 > > ? _raw_spin_lock_irqsave+0x36/0x70 > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > ? __wake_up+0x70/0x190 > > virtnet_set_features+0x90/0xf0 [virtio_net] > > __netdev_update_features+0x271/0x980 > > ? nlmsg_notify+0x5b/0xa0 > >

On 2020/1/6 ??8:54, Michael S. Tsirkin wrote: > On Mon, Jan 06, 2020 at 10:47:35AM +0800, Jason Wang wrote: >> On 2020/1/5 ??9:22, Michael S. Tsirkin wrote: >>> The only way for guest to control offloads (as enabled by >>> VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands >>> through CTRL_VQ. So it does not make sense to >>> acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without >>> VIRTIO_NET_F_CTRL_VQ. >>> >>> The spec does not outlaw devices with such a configuration, so we have >>> to s...

...; > > + > > > > > > > > > > Instead of checking for this in virtnet_set_features, how about we > > > > > make configurability contingent on cvq in virtnet_probe: > > > > > > > > > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS)) > > > > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) && > > > > > + virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > > > > > dev->hw_features |= NETIF_F_LRO; > > > > > &g...

The only way for guest to control offloads (as enabled by VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands through CTRL_VQ. So it does not make sense to acknowledge VIRTIO_NET_F_CTRL_GUEST_OFFLOADS without VIRTIO_NET_F_CTRL_VQ. The spec does not outlaw devices with such a configuration, but Linux assumed that with VIRTIO_NET_F_CTRL_GUEST_OFFLOADS control vq is always there, res...