search for: virtio_net_ctrl_announce_ack

...ough a dedicated command looks suitable for all platforms (especially for the ones who don't trap the status read or write) with a ctrl vq and can solve the race between host and guest. So this patch makes VIRTIO_NET_F_ANNOUNCE depends on VIRTIO_NET_F_CTRL_VQ and introduces a dedicated command VIRTIO_NET_CTRL_ANNOUNCE_ACK to let device clear the VIRTIO_NET_S_ANNOUNCE bit in the status field. Changes from v1: - Send the gratuitous packets or mark them as pending before send VIRTIO_NET_CTRL_ANNOUNCE_ACK command. Signed-off-by: Jason Wang <jasowang at redhat.com> --- virtio-0.9.4.lyx | 76 +++++++++++++++++++...

...ough a dedicated command looks suitable for all platforms (especially for the ones who don't trap the status read or write) with a ctrl vq and can solve the race between host and guest. So this patch makes VIRTIO_NET_F_ANNOUNCE depends on VIRTIO_NET_F_CTRL_VQ and introduces a dedicated command VIRTIO_NET_CTRL_ANNOUNCE_ACK to let device clear the VIRTIO_NET_S_ANNOUNCE bit in the status field. Changes from v1: - Send the gratuitous packets or mark them as pending before send VIRTIO_NET_CTRL_ANNOUNCE_ACK command. Signed-off-by: Jason Wang <jasowang at redhat.com> --- virtio-0.9.4.lyx | 76 +++++++++++++++++++...

...ough a dedicated command looks suitable for all platforms (especially for the ones who don't trap the status read or write) with a ctrl vq and can solve the race between host and guest. So this patch makes VIRTIO_NET_F_ANNOUNCE depends on VIRTIO_NET_F_CTRL_VQ and introduces a dedicated command VIRTIO_NET_CTRL_ANNOUNCE_ACK to let device clear the VIRTIO_NET_S_ANNOUNCE bit in the status field. Signed-off-by: Jason Wang <jasowang at redhat.com> --- virtio-0.9.4.lyx | 63 +++++++++++++++++++++++++++++++++++++++++++++++++----- 1 files changed, 57 insertions(+), 6 deletions(-) diff --git a/virtio-0.9.4.lyx b/vi...

...ough a dedicated command looks suitable for all platforms (especially for the ones who don't trap the status read or write) with a ctrl vq and can solve the race between host and guest. So this patch makes VIRTIO_NET_F_ANNOUNCE depends on VIRTIO_NET_F_CTRL_VQ and introduces a dedicated command VIRTIO_NET_CTRL_ANNOUNCE_ACK to let device clear the VIRTIO_NET_S_ANNOUNCE bit in the status field. Signed-off-by: Jason Wang <jasowang at redhat.com> --- virtio-0.9.4.lyx | 63 +++++++++++++++++++++++++++++++++++++++++++++++++----- 1 files changed, 57 insertions(+), 6 deletions(-) diff --git a/virtio-0.9.4.lyx b/vi...

...tr. */ struct page *pages; @@ -781,12 +784,30 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd, return status == VIRTIO_NET_OK; } +static void virtnet_ack_link_announce(struct virtnet_info *vi) +{ + if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_ANNOUNCE, + VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL, + 0, 0)) { + dev_warn(&vi->dev->dev, "Failed to ack link nnounce.\n"); + } +} + +static void announce_work(struct work_struct *work) +{ + struct virtnet_info *vi = container_of(work, struct virtnet_info, + announce); + netif_notify_peers(vi->dev); + vi...

...tr. */ struct page *pages; @@ -781,12 +784,30 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd, return status == VIRTIO_NET_OK; } +static void virtnet_ack_link_announce(struct virtnet_info *vi) +{ + if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_ANNOUNCE, + VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL, + 0, 0)) { + dev_warn(&vi->dev->dev, "Failed to ack link nnounce.\n"); + } +} + +static void announce_work(struct work_struct *work) +{ + struct virtnet_info *vi = container_of(work, struct virtnet_info, + announce); + netif_notify_peers(vi->dev); + vi...

...t page *pages; @@ -781,6 +790,16 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd, return status == VIRTIO_NET_OK; } +static void virtnet_ack_link_announce(struct virtnet_info *vi) +{ + rtnl_lock(); + if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_ANNOUNCE, + VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL, + 0, 0)) + dev_warn(&vi->dev->dev, "Failed to ack link announce.\n"); + rtnl_unlock(); +} + static int virtnet_close(struct net_device *dev) { struct virtnet_info *vi = netdev_priv(dev); @@ -952,20 +971,31 @@ static const struct net_device_ops virtnet_netdev = {...

...t page *pages; @@ -781,6 +790,16 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd, return status == VIRTIO_NET_OK; } +static void virtnet_ack_link_announce(struct virtnet_info *vi) +{ + rtnl_lock(); + if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_ANNOUNCE, + VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL, + 0, 0)) + dev_warn(&vi->dev->dev, "Failed to ack link announce.\n"); + rtnl_unlock(); +} + static int virtnet_close(struct net_device *dev) { struct virtnet_info *vi = netdev_priv(dev); @@ -952,20 +971,31 @@ static const struct net_device_ops virtnet_netdev = {...

...TIO_NET_CTRL_MAC_ADDR_SET, &sg)) { dev_warn(&vdev->dev, "Failed to set mac address by vq command.\n"); return -EINVAL; @@ -1008,7 +1003,7 @@ static void virtnet_ack_link_announce(st { rtnl_lock(); if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_ANNOUNCE, - VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL, NULL)) + VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL)) dev_warn(&vi->dev->dev, "Failed to ack link announce.\n"); rtnl_unlock(); } @@ -1026,7 +1021,7 @@ static int virtnet_set_queues(struct vir sg_init_one(&sg, &s, sizeof(s)); if (!virtnet_send_command(vi,...

The virtio_net driver never sends the multicast address list to the host. This is because send command takes a pointer to scatter list to send but only inserts that one entry into the outgoing scatter list. This bug has been there since: commit f565a7c259d71cc186753653d978c646d2354b36 Author: Alex Williamson <alex.williamson at hp.com> Date: Wed Feb 4 09:02:45 2009 +0000 virtio_net:

The virtio_net driver never sends the multicast address list to the host. This is because send command takes a pointer to scatter list to send but only inserts that one entry into the outgoing scatter list. This bug has been there since: commit f565a7c259d71cc186753653d978c646d2354b36 Author: Alex Williamson <alex.williamson at hp.com> Date: Wed Feb 4 09:02:45 2009 +0000 virtio_net:

...t;> -static void virtnet_ack_link_announce(struct virtnet_info *vi) >> +static void virtnet_ack(struct virtnet_info *vi, u8 class, u8 cmd) >> { >> rtnl_lock(); >> - if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_ANNOUNCE, >> - VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL)) >> - dev_warn(&vi->dev->dev, "Failed to ack link announce.\n"); >> + if (!virtnet_send_command(vi, class, cmd, NULL)) >> + dev_warn(&vi->dev->dev, "Failed to ack %u.%u\n", class, cmd); >> rtnl_...

...t;> -static void virtnet_ack_link_announce(struct virtnet_info *vi) >> +static void virtnet_ack(struct virtnet_info *vi, u8 class, u8 cmd) >> { >> rtnl_lock(); >> - if (!virtnet_send_command(vi, VIRTIO_NET_CTRL_ANNOUNCE, >> - VIRTIO_NET_CTRL_ANNOUNCE_ACK, NULL)) >> - dev_warn(&vi->dev->dev, "Failed to ack link announce.\n"); >> + if (!virtnet_send_command(vi, class, cmd, NULL)) >> + dev_warn(&vi->dev->dev, "Failed to ack %u.%u\n", class, cmd); >> rtnl_...

...acket-Steering" + +\end_inset + +. +\end_layout + +\begin_layout Subsection* Packet Transmission Interrupt \end_layout @@ -4988,8 +5310,24 @@ status open The Guest needs to check VIRTIO_NET_S_ANNOUNCE bit in status field when it notices the changes of device configuration. The command VIRTIO_NET_CTRL_ANNOUNCE_ACK is used to indicate that driver - has recevied the notification and device would clear the VIRTIO_NET_S_ANNOUNCE - bit in the status filed after it received this command. + has rece +\change_inserted 1986246365 1346663932 +i +\change_unchanged +v +\change_deleted 1986246365 1346663934 +i +\change_u...

...acket-Steering" + +\end_inset + +. +\end_layout + +\begin_layout Subsection* Packet Transmission Interrupt \end_layout @@ -4988,8 +5310,24 @@ status open The Guest needs to check VIRTIO_NET_S_ANNOUNCE bit in status field when it notices the changes of device configuration. The command VIRTIO_NET_CTRL_ANNOUNCE_ACK is used to indicate that driver - has recevied the notification and device would clear the VIRTIO_NET_S_ANNOUNCE - bit in the status filed after it received this command. + has rece +\change_inserted 1986246365 1346663932 +i +\change_unchanged +v +\change_deleted 1986246365 1346663934 +i +\change_u...

...r the VIRTIO_NET_F_MRG_RXBUF \end_inset +\change_deleted 1986246365 1346932640 + \end_layout \begin_layout Subsection* @@ -4988,8 +5117,24 @@ status open The Guest needs to check VIRTIO_NET_S_ANNOUNCE bit in status field when it notices the changes of device configuration. The command VIRTIO_NET_CTRL_ANNOUNCE_ACK is used to indicate that driver - has recevied the notification and device would clear the VIRTIO_NET_S_ANNOUNCE - bit in the status filed after it received this command. + has rece +\change_inserted 1986246365 1346663932 +i +\change_unchanged +v +\change_deleted 1986246365 1346663934 +i +\change_u...

...r the VIRTIO_NET_F_MRG_RXBUF \end_inset +\change_deleted 1986246365 1346932640 + \end_layout \begin_layout Subsection* @@ -4988,8 +5117,24 @@ status open The Guest needs to check VIRTIO_NET_S_ANNOUNCE bit in status field when it notices the changes of device configuration. The command VIRTIO_NET_CTRL_ANNOUNCE_ACK is used to indicate that driver - has recevied the notification and device would clear the VIRTIO_NET_S_ANNOUNCE - bit in the status filed after it received this command. + has rece +\change_inserted 1986246365 1346663932 +i +\change_unchanged +v +\change_deleted 1986246365 1346663934 +i +\change_u...

...So unless VIRTIO_NET_F_MRG_RXBUF is negotiated, every buffer in the receive queue needs to be at least this length \begin_inset Foot -status open +status collapsed \begin_layout Plain Layout Obviously each one can be split across multiple descriptor elements. @@ -4980,6 +5075,83 @@ Sending VIRTIO_NET_CTRL_ANNOUNCE_ACK command through control vq. \begin_layout Enumerate . +\change_inserted 2090695081 1340693446 + +\end_layout + +\begin_layout Subsection* + +\change_inserted 2090695081 1340693500 +Negotiating the number of queue pairs +\end_layout + +\begin_layout Standard + +\change_inserted 2090695081 13406...

...So unless VIRTIO_NET_F_MRG_RXBUF is negotiated, every buffer in the receive queue needs to be at least this length \begin_inset Foot -status open +status collapsed \begin_layout Plain Layout Obviously each one can be split across multiple descriptor elements. @@ -4980,6 +5075,83 @@ Sending VIRTIO_NET_CTRL_ANNOUNCE_ACK command through control vq. \begin_layout Enumerate . +\change_inserted 2090695081 1340693446 + +\end_layout + +\begin_layout Subsection* + +\change_inserted 2090695081 1340693500 +Negotiating the number of queue pairs +\end_layout + +\begin_layout Standard + +\change_inserted 2090695081 13406...

...yout + +\begin_layout Standard + +\change_inserted 1986246365 1353594638 +If VIRTIO_NET_F_RFS is negotiated, each of the receiveq0...receiveqN that will + be used should be populated with receive buffers. +\change_unchanged + \end_layout \begin_layout Subsection* @@ -5293,8 +5410,143 @@ Sending VIRTIO_NET_CTRL_ANNOUNCE_ACK command through control vq. \end_layout -\begin_layout Enumerate +\begin_layout Subsection* + +\change_inserted 1986246365 1353593879 +Packet Receive Flow Steering +\end_layout + +\begin_layout Standard + +\change_inserted 1986246365 1353594403 +If the driver negotiates the VIRTIO_NET_F_RFS (...