search for: virtio_mmio_version

...F ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#ifndef _LINUX_VIRTIO_MMIO_H +#define _LINUX_VIRTIO_MMIO_H + +/* + * Control registers + */ + +/* Magic value ("virt" string) - Read Only */ +#define VIRTIO_MMIO_MAGIC_VALUE 0x000 + +/* Virtio device version - Read Only */ +#define VIRTIO_MMIO_VERSION 0x004 + +/* Virtio device ID - Read Only */ +#define VIRTIO_MMIO_DEVICE_ID 0x008 + +/* Virtio vendor ID - Read Only */ +#define VIRTIO_MMIO_VENDOR_ID 0x00c + +/* Bitmask of the features supported by the device (host) + * (32 bits per set) - Read Only */ +#define VIRTIO_MMIO_DEVICE_FEATURES 0x010...

...F ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#ifndef _LINUX_VIRTIO_MMIO_H +#define _LINUX_VIRTIO_MMIO_H + +/* + * Control registers + */ + +/* Magic value ("virt" string) - Read Only */ +#define VIRTIO_MMIO_MAGIC_VALUE 0x000 + +/* Virtio device version - Read Only */ +#define VIRTIO_MMIO_VERSION 0x004 + +/* Virtio device ID - Read Only */ +#define VIRTIO_MMIO_DEVICE_ID 0x008 + +/* Virtio vendor ID - Read Only */ +#define VIRTIO_MMIO_VENDOR_ID 0x00c + +/* Bitmask of the features supported by the device (host) + * (32 bits per set) - Read Only */ +#define VIRTIO_MMIO_DEVICE_FEATURES 0x010...

...> > Yes but the point is the same info is already available > in core: just look at feature bit 31. > If you think it's important enough to expose in a decoded > way, let's add this in core? How do you mean "in core"? It's a mmio-specific value. Content of the VIRTIO_MMIO_VERSION control register. > > > > @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) > > > > > > > > /* Check device version */ > > > > vm_dev->version = readl(vm_dev->base + VIRTIO_MMIO_VERSION); > > &gt...

...> > Yes but the point is the same info is already available > in core: just look at feature bit 31. > If you think it's important enough to expose in a decoded > way, let's add this in core? How do you mean "in core"? It's a mmio-specific value. Content of the VIRTIO_MMIO_VERSION control register. > > > > @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) > > > > > > > > /* Check device version */ > > > > vm_dev->version = readl(vm_dev->base + VIRTIO_MMIO_VERSION); > > &gt...

...ally, to see what version of control registers are available. Useful - I strongly believe so. > > @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) > > > > /* Check device version */ > > vm_dev->version = readl(vm_dev->base + VIRTIO_MMIO_VERSION); > > - if (vm_dev->version != 1) { > > + if (vm_dev->version < 1 || vm_dev->version > 2) { > > dev_err(&pdev->dev, "Version %ld not supported!\n", > > vm_dev->version); > >...

...ally, to see what version of control registers are available. Useful - I strongly believe so. > > @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) > > > > /* Check device version */ > > vm_dev->version = readl(vm_dev->base + VIRTIO_MMIO_VERSION); > > - if (vm_dev->version != 1) { > > + if (vm_dev->version < 1 || vm_dev->version > 2) { > > dev_err(&pdev->dev, "Version %ld not supported!\n", > > vm_dev->version); > >...

...s the same info is already available > > in core: just look at feature bit 31. > > If you think it's important enough to expose in a decoded > > way, let's add this in core? > > How do you mean "in core"? It's a mmio-specific value. Content of the > VIRTIO_MMIO_VERSION control register. Yes but if driver loaded, then revision is always in sync with the feature bit. If driver failed to attach, attribute is not there so can't be used for debugging. > > > > > @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) >...

...s the same info is already available > > in core: just look at feature bit 31. > > If you think it's important enough to expose in a decoded > > way, let's add this in core? > > How do you mean "in core"? It's a mmio-specific value. Content of the > VIRTIO_MMIO_VERSION control register. Yes but if driver loaded, then revision is always in sync with the feature bit. If driver failed to attach, attribute is not there so can't be used for debugging. > > > > > @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) >...

...ilable > > > in core: just look at feature bit 31. > > > If you think it's important enough to expose in a decoded > > > way, let's add this in core? > > > > How do you mean "in core"? It's a mmio-specific value. Content of the > > VIRTIO_MMIO_VERSION control register. > > Yes but if driver loaded, then revision is always in sync > with the feature bit. Well, not quite: as of now I've got legacy block device driver happily working on top of compliant (so v2 in MMIO speech) MMIO device - the transport if completely transparent here...

...ilable > > > in core: just look at feature bit 31. > > > If you think it's important enough to expose in a decoded > > > way, let's add this in core? > > > > How do you mean "in core"? It's a mmio-specific value. Content of the > > VIRTIO_MMIO_VERSION control register. > > Yes but if driver loaded, then revision is always in sync > with the feature bit. Well, not quite: as of now I've got legacy block device driver happily working on top of compliant (so v2 in MMIO speech) MMIO device - the transport if completely transparent here...

...e bit 31. > > > > > If you think it's important enough to expose in a decoded > > > > > way, let's add this in core? > > > > > > > > How do you mean "in core"? It's a mmio-specific value. Content of the > > > > VIRTIO_MMIO_VERSION control register. > > > > > > Yes but if driver loaded, then revision is always in sync > > > with the feature bit. > > > > Well, not quite: as of now I've got legacy block device driver happily > > working on top of compliant (so v2 in MMIO speech...

...e bit 31. > > > > > If you think it's important enough to expose in a decoded > > > > > way, let's add this in core? > > > > > > > > How do you mean "in core"? It's a mmio-specific value. Content of the > > > > VIRTIO_MMIO_VERSION control register. > > > > > > Yes but if driver loaded, then revision is always in sync > > > with the feature bit. > > > > Well, not quite: as of now I've got legacy block device driver happily > > working on top of compliant (so v2 in MMIO speech...

...RUGO, vm_dev_attr_version_show, NULL); + static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) /* Check device version */ vm_dev->version = readl(vm_dev->base + VIRTIO_MMIO_VERSION); - if (vm_dev->version != 1) { + if (vm_dev->version < 1 || vm_dev->version > 2) { dev_err(&pdev->dev, "Version %ld not supported!\n", vm_dev->version); return -ENXIO; } vm_dev->vdev.id.device = readl(vm_dev->base + VIRTIO_MMIO_DEVICE_ID);...

...RUGO, vm_dev_attr_version_show, NULL); + static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) /* Check device version */ vm_dev->version = readl(vm_dev->base + VIRTIO_MMIO_VERSION); - if (vm_dev->version != 1) { + if (vm_dev->version < 1 || vm_dev->version > 2) { dev_err(&pdev->dev, "Version %ld not supported!\n", vm_dev->version); return -ENXIO; } vm_dev->vdev.id.device = readl(vm_dev->base + VIRTIO_MMIO_DEVICE_ID);...

...important enough to expose in a decoded way, let's add this in core? > > > @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) > > > > > > /* Check device version */ > > > vm_dev->version = readl(vm_dev->base + VIRTIO_MMIO_VERSION); > > > - if (vm_dev->version != 1) { > > > + if (vm_dev->version < 1 || vm_dev->version > 2) { > > > dev_err(&pdev->dev, "Version %ld not supported!\n", > > > vm_dev->version)...

...important enough to expose in a decoded way, let's add this in core? > > > @@ -476,16 +501,26 @@ static int virtio_mmio_probe(struct platform_device *pdev) > > > > > > /* Check device version */ > > > vm_dev->version = readl(vm_dev->base + VIRTIO_MMIO_VERSION); > > > - if (vm_dev->version != 1) { > > > + if (vm_dev->version < 1 || vm_dev->version > 2) { > > > dev_err(&pdev->dev, "Version %ld not supported!\n", > > > vm_dev->version)...

...core: just look at feature bit 31. > > > > If you think it's important enough to expose in a decoded > > > > way, let's add this in core? > > > > > > How do you mean "in core"? It's a mmio-specific value. Content of the > > > VIRTIO_MMIO_VERSION control register. > > > > Yes but if driver loaded, then revision is always in sync > > with the feature bit. > > Well, not quite: as of now I've got legacy block device driver happily > working on top of compliant (so v2 in MMIO speech) MMIO device - the > trans...

...core: just look at feature bit 31. > > > > If you think it's important enough to expose in a decoded > > > > way, let's add this in core? > > > > > > How do you mean "in core"? It's a mmio-specific value. Content of the > > > VIRTIO_MMIO_VERSION control register. > > > > Yes but if driver loaded, then revision is always in sync > > with the feature bit. > > Well, not quite: as of now I've got legacy block device driver happily > working on top of compliant (so v2 in MMIO speech) MMIO device - the > trans...

On Mon, 2011-10-24 at 03:33 +0100, Rusty Russell wrote: > No, that's it I think. Please send a diff for the documentation, since > I'm updating the LyX master and I've already applied your previous > version. Here it goes (below). Also do you think you would be able to merge the driver (corresponding v4 patch follows) in the 3.2 merge window that seems to have just opened?

On Mon, 2011-10-24 at 03:33 +0100, Rusty Russell wrote: > No, that's it I think. Please send a diff for the documentation, since > I'm updating the LyX master and I've already applied your previous > version. Here it goes (below). Also do you think you would be able to merge the driver (corresponding v4 patch follows) in the 3.2 merge window that seems to have just opened?