search for: virtio_input_bitmap_copi

Displaying 10 results from an estimated 10 matches for "virtio_input_bitmap_copi".

2015 Mar 21
3
[PATCH 1/1] Add virtio-input driver.
On Fri, Mar 20, 2015 at 11:28:47AM +0100, Gerd Hoffmann wrote: > Hi, > > > > +static int virtinput_send_status(struct virtio_input *vi, > > > + u16 type, u16 code, s32 value) > > > +{ > > > + struct virtio_input_event *stsbuf; > > > + struct scatterlist sg[1]; > > > + > > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC);
2015 Mar 21
3
[PATCH 1/1] Add virtio-input driver.
On Fri, Mar 20, 2015 at 11:28:47AM +0100, Gerd Hoffmann wrote: > Hi, > > > > +static int virtinput_send_status(struct virtio_input *vi, > > > + u16 type, u16 code, s32 value) > > > +{ > > > + struct virtio_input_event *stsbuf; > > > + struct scatterlist sg[1]; > > > + > > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC);
2015 Mar 23
2
[PATCH 1/1] Add virtio-input driver.
Hi, > > At least, this needs a comment explaining what the function does, > > and maybe wrap it in a helper like virtio_input_bitmap_copy or > > virtio_bitmap_or. > > Can do that, sure. Well, the function where this is in already cares about the bitmap copy only. Can add a comment though. > > You are doing leXXX everywhere, that's VERSION_1 dependency. >
2015 Mar 23
2
[PATCH 1/1] Add virtio-input driver.
Hi, > > At least, this needs a comment explaining what the function does, > > and maybe wrap it in a helper like virtio_input_bitmap_copy or > > virtio_bitmap_or. > > Can do that, sure. Well, the function where this is in already cares about the bitmap copy only. Can add a comment though. > > You are doing leXXX everywhere, that's VERSION_1 dependency. >
2015 Mar 23
0
[PATCH 1/1] Add virtio-input driver.
Hi, > > > > + if (cfg & (1 << (bit % 8))) > > > > + set_bit(bit, bits); > > > > > > what if not set? does something clear the mask? > > > > kzalloc? > > So you are really just reading in array of bytes? > All this set bit trickery is just to convert things from LE? Trickery? Just checking each bit from virtio config
2015 Mar 23
0
[PATCH 1/1] Add virtio-input driver.
On Mon, Mar 23, 2015 at 02:44:52PM +0100, Gerd Hoffmann wrote: > Hi, > > > > At least, this needs a comment explaining what the function does, > > > and maybe wrap it in a helper like virtio_input_bitmap_copy or > > > virtio_bitmap_or. > > > > Can do that, sure. > > Well, the function where this is in already cares about the bitmap copy >
2015 Mar 23
0
[PATCH 1/1] Add virtio-input driver.
Hi, > > > > + if (cfg & (1 << (bit % 8))) > > > > + set_bit(bit, bits); > > > > > > what if not set? does something clear the mask? > > > > kzalloc? > > So you are really just reading in array of bytes? > All this set bit trickery is just to convert things from LE? Trickery? Just checking each bit from virtio config
2015 Mar 23
0
[PATCH 1/1] Add virtio-input driver.
On Mon, Mar 23, 2015 at 02:44:52PM +0100, Gerd Hoffmann wrote: > Hi, > > > > At least, this needs a comment explaining what the function does, > > > and maybe wrap it in a helper like virtio_input_bitmap_copy or > > > virtio_bitmap_or. > > > > Can do that, sure. > > Well, the function where this is in already cares about the bitmap copy >
2015 Mar 19
2
[PATCH 1/1] Add virtio-input driver.
On Thu, Mar 19, 2015 at 10:13:11AM +0100, Gerd Hoffmann wrote: > virtio-input is basically evdev-events-over-virtio, so this driver isn't > much more than reading configuration from config space and forwarding > incoming events to the linux input layer. > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> What worries me is how well are these events specified. Will we
2015 Mar 19
2
[PATCH 1/1] Add virtio-input driver.
On Thu, Mar 19, 2015 at 10:13:11AM +0100, Gerd Hoffmann wrote: > virtio-input is basically evdev-events-over-virtio, so this driver isn't > much more than reading configuration from config space and forwarding > incoming events to the linux input layer. > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> What worries me is how well are these events specified. Will we