search for: virtio_gpu_resp_resource_info

...truct virtio_gpu_ctrl_hdr hdr; + __le32 resource_id; + __le32 format; + __le32 width; + __le32 height; + /* 3d only */ + __le32 target; + __le32 bind; + __le32 depth; + __le32 array_size; + __le32 last_level; + __le32 nr_samples; + __le32 flags; +}; + +/* VIRTIO_GPU_RESP_OK_RESOURCE_INFO */ +struct virtio_gpu_resp_resource_info { + struct virtio_gpu_ctrl_hdr hdr; + __le32 stride[4]; + __le32 size[4]; +}; + #define VIRTIO_GPU_CAPSET_VIRGL 1 #define VIRTIO_GPU_CAPSET_VIRGL2 2 -- 2.18.1

...we want the option for the guest allocate? Allocation options are handled by VIRTIO_GPU_CMD_MEMORY_CREATE (initially guest allocated only, i.e. what virtio-gpu supports today, the plan is to add other allocation types later on). > > +/* VIRTIO_GPU_RESP_OK_RESOURCE_INFO */ > > +struct virtio_gpu_resp_resource_info { > > + struct virtio_gpu_ctrl_hdr hdr; > > + __le32 stride[4]; > > + __le32 size[4]; > > +}; > > offsets[4] needed too That is in VIRTIO_GPU_CMD_RESOURCE_MEMORY_ATTACH ... cheers, Gerd

...quite different from the guest-allocated case. Maybe we even need a virtio_gpu_cmd_memory_create_host_for_resource variant, given that gbm doesn't have raw memory buffers without any format attached to it. > > > > +/* VIRTIO_GPU_RESP_OK_RESOURCE_INFO */ > > > > +struct virtio_gpu_resp_resource_info { > > > > + struct virtio_gpu_ctrl_hdr hdr; > > > > + __le32 stride[4]; > > > > + __le32 size[4]; > > > > +}; > > > > > > offsets[4] needed too > > > > That is in VIRTIO_GPU_CMD_RESOURCE_MEMORY_ATTACH .....

...quite different from the guest-allocated case. Maybe we even need a virtio_gpu_cmd_memory_create_host_for_resource variant, given that gbm doesn't have raw memory buffers without any format attached to it. > > > > +/* VIRTIO_GPU_RESP_OK_RESOURCE_INFO */ > > > > +struct virtio_gpu_resp_resource_info { > > > > + struct virtio_gpu_ctrl_hdr hdr; > > > > + __le32 stride[4]; > > > > + __le32 size[4]; > > > > +}; > > > > > > offsets[4] needed too > > > > That is in VIRTIO_GPU_CMD_RESOURCE_MEMORY_ATTACH .....

...mory will only be attachable to the given (or compatible) resource, right? Vulkan is much more explicit than any pre-existing API. I guess we will have to add this to cover APIs beyond Vulkan. > > > > > > +/* VIRTIO_GPU_RESP_OK_RESOURCE_INFO */ > > > > > +struct virtio_gpu_resp_resource_info { > > > > > + struct virtio_gpu_ctrl_hdr hdr; > > > > > + __le32 stride[4]; > > > > > + __le32 size[4]; > > > > > +}; > > > > > > > > offsets[4] needed too > > > > > > That is in...