search for: virtio_f_guest_must_tell_host

Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: > At this point I am confused. I think there are two changes in your patch: > > 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST > Is this functionally identical to what I proposed? > If yes, I am fine with either change being applied. Yes. > 2. New SILENT_DEFLATE feature > Since guest can get same functionality by not acking > TELL_HOST, I still don't see what good it does: > Historically a host...

...2013 16:29, Michael S. Tsirkin ha scritto: > On Tue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: >> Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: >>> At this point I am confused. I think there are two changes in your patch: >>> >>> 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST >>> Is this functionally identical to what I proposed? >>> If yes, I am fine with either change being applied. >> >> Yes. >> >>> 2. New SILENT_DEFLATE feature >>> Since guest can get same functionality by not acking >>> TELL_HOST, I...

Il 28/05/2013 13:44, Michael S. Tsirkin ha scritto: > negotiated in spec means "present and acked by guest". > We can try and replace "negotiated" by "present and acked by guest" > everywhere - think it will be clearer? No, I understand what negotiated means. But in this case, "negotiated" is not the word that you want. >>>> Now

On Tue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: > Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: > > At this point I am confused. I think there are two changes in your patch: > > > > 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST > > Is this functionally identical to what I proposed? > > If yes, I am fine with either change being applied. > > Yes. > > > 2. New SILENT_DEFLATE feature > > Since guest can get same functionality by not acking > > TELL_HOST, I still don't see what...

...c patch says > > they should. Instead they treat it as they would treat your new bit. > > How so? I even changed the name of the existing bit to > VIRTIO_F_GUEST_TELLS_HOST. > > Paolo At this point I am confused. I think there are two changes in your patch: 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST Is this functionally identical to what I proposed? If yes, I am fine with either change being applied. 2. New SILENT_DEFLATE feature Since guest can get same functionality by not acking TELL_HOST, I still don't see what good it does: Historically a host with no features supports silent d...

...irkin ha scritto: > > On Tue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: > >> Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: > >>> At this point I am confused. I think there are two changes in your patch: > >>> > >>> 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST > >>> Is this functionally identical to what I proposed? > >>> If yes, I am fine with either change being applied. > >> > >> Yes. > >> > >>> 2. New SILENT_DEFLATE feature > >>> Since guest can get same functionality by no...

...o: >>> On Tue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: >>>> Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: >>>>> At this point I am confused. I think there are two changes in your patch: >>>>> >>>>> 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST >>>>> Is this functionally identical to what I proposed? >>>>> If yes, I am fine with either change being applied. >>>> >>>> Yes. >>>> >>>>> 2. New SILENT_DEFLATE feature >>>>> Since guest can get sam...

...ue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: > >>>> Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: > >>>>> At this point I am confused. I think there are two changes in your patch: > >>>>> > >>>>> 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST > >>>>> Is this functionally identical to what I proposed? > >>>>> If yes, I am fine with either change being applied. > >>>> > >>>> Yes. > >>>> > >>>>> 2. New SILENT_DEFLATE feature > >>&g...